Bug 852092 - NullPointerException in DriftServerServiceImpl.getDriftDefinitions
Summary: NullPointerException in DriftServerServiceImpl.getDriftDefinitions
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Inventory, Plugin Container
Version: JON 3.1.0
Hardware: All
OS: All
unspecified
medium
Target Milestone: ER01
: JON 3.2.0
Assignee: RHQ Project Maintainer
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On: 850572
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-27 15:20 UTC by Charles Crouch
Modified: 2015-02-01 23:28 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 850572
Environment:
Last Closed: 2014-01-02 20:43:17 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Charles Crouch 2012-08-27 15:20:24 UTC
+++ This bug was initially created as a clone of Bug #850572 +++

From Heiko:

(2:35:01 PM) pilhuhn: 14:30:21,072 WARN  [DiscoveryBossBean] Could not perform commit synchronization with agent for server [snert.local]
(2:35:01 PM) pilhuhn: java.lang.RuntimeException: java.lang.NullPointerException
(2:35:09 PM) pilhuhn: Caused by: java.lang.NullPointerException
(2:35:10 PM) pilhuhn: 	at org.rhq.enterprise.server.drift.DriftServerServiceImpl.getDriftDefinitions(DriftServerServiceImpl.java:93)
(3:13:18 PM) pilhuhn: saw that flying by when importing servers that were on the Q for some time. It may be that the resource types have changed since - I may have them discovered yesterday or earlier and did a source build this morning. I can't reproduce it on purpose, jshaughn
(3:14:23 PM) jshaughn: had you been doing anything with drift definitions?
(3:16:18 PM) pilhuhn: no, not at all

--- Additional comment from jshaughn on 2012-08-21 16:50:20 EDT ---

master commit 5ffd6e1eb155bf0208690cce526fb18b832ba344

Make drift def sync more efficient, and possibly avoid an NPE that was
seen intermittently.
- DriftServerServiceImpl.getDriftDefinitions() now only generates
  Map entries for resources with drift definitions, avoiding unnecessary
  list creation and subsequent processing.
- Added jdoc to that effect
- Changed private DriftSyncManager.syncConfigs() to syncDriftDefinitions
  for clarity.



Test Notes:
Inventory Sync testing would be appropriate for this.

Comment 1 Heiko W. Rupp 2013-08-12 11:35:45 UTC
This has been fixed in upstream long time ago and will be in ER1


Note You need to log in before you can comment on or make changes to this bug.