Bug 852106 - rhevm installation: Local nfs iso export should not default to /usr/local/exports/iso or anywhere else under a system /usr
Summary: rhevm installation: Local nfs iso export should not default to /usr/local/ex...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-setup
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Juan Hernández
QA Contact: Pavel Stehlik
URL:
Whiteboard: integration
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-08-27 16:04 UTC by Simon Grinberg
Modified: 2013-07-29 00:02 UTC (History)
9 users (show)

Fixed In Version: si18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 20:01:26 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Simon Grinberg 2012-08-27 16:04:04 UTC
Description of problem:

From bug 847833#c13
"Another thing that I just noticed, after looking at the logs again, was that we're exporting /usr/local/exports/iso as r/w. IMHO exporting anything in /usr as r/w is a bad idea.  If the installer is going to set up an export for /usr it should be 'read' only and not r/w.  R/W should be in /var or something."


Expected results:

Create the export according best practice

Comment 1 Itamar Heim 2012-08-27 16:40:31 UTC
if doing this, need to consider upgrade implications

Comment 2 Juan Hernández 2012-08-27 18:11:02 UTC
This is just the default value that we suggest during installation, before that we didn't suggest anything. So from the upgrade point of view there shouldn't be any additional implication: the upgrade must support any directory, as the user can choose any directory.

I agree that we should suggest something outside of /usr and that something under /var makes more sense. What about /var/lib/ovirt-engine/exports? We already put other variable data under /var/lib/ovirt-engine, and we create and track that directory as part of the RPMs.

Comment 3 Alon Bar-Lev 2012-08-27 18:28:03 UTC
I don't think this should be under /var/lib/ovirt-engine, too sensitive. Better /var/lib/exports/XXXX.

Comment 4 Juan Hernández 2012-08-29 09:19:45 UTC
If we all agree that /var/lib/exports is better than /usr/local/exports then the following change can fix it:

http://gerrit.ovirt.org/7563

Comment 5 Simon Grinberg 2012-08-29 09:56:24 UTC
(In reply to comment #4)
> If we all agree that /var/lib/exports is better than /usr/local/exports then
> the following change can fix it:
> 
> http://gerrit.ovirt.org/7563

+1

Comment 6 Juan Hernández 2012-08-29 11:16:15 UTC
The proposed change has been merged upstream:

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=dcd746d6e4faf9fac5cf1894ab6896aef4541b48

Comment 8 Pavel Stehlik 2012-09-13 13:24:37 UTC
ok - si18


Note You need to log in before you can comment on or make changes to this bug.