Bug 852416 - Review Request: pangox-compat - Compatibility library for pangox
Review Request: pangox-compat - Compatibility library for pangox
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Gwyn Ciesla
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-28 08:41 EDT by Parag Nemade
Modified: 2012-09-19 03:44 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-19 03:44:35 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Parag Nemade 2012-08-28 08:41:50 EDT
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/pangox-compat.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/pangox-compat-0.0.1-1.fc17.src.rpm
Description: This is a compatibility library providing the obsolete pangox library
that is not shipped by Pango itself anymore.
Fedora Account System Username: pnemade
Comment 1 Parag Nemade 2012-08-28 09:11:03 EDT
koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4429668
Comment 2 Gwyn Ciesla 2012-08-28 09:25:54 EDT
Reviewing, I need this for gnugb. . .
Comment 3 Gwyn Ciesla 2012-08-28 09:30:13 EDT
Good:

- rpmlint checks return:

pangox-compat.x86_64: W: conffile-without-noreplace-flag /etc/pango/pangox.aliases
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

pangox-compat.x86_64: E: incorrect-fsf-address /usr/share/doc/pangox-compat-0.0.1/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

pangox-compat-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

3 packages and 0 specfiles checked; 1 errors, 2 warnings.

All ignorable given it's a compat package.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream  with sha512
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Really clean, good.  Working on mock build to confirm BRs.  Will approve if that's good.
Comment 4 Gwyn Ciesla 2012-08-28 09:41:34 EDT
Looks good, APPROVED.
Comment 5 Parag Nemade 2012-08-28 09:42:36 EDT
New Package SCM Request
=======================
Package Name: pangox-compat
Short Description: Compatibility library for pangox
Owners: pnemade
Branches: f18
InitialCC:
Comment 6 Gwyn Ciesla 2012-08-28 09:43:14 EDT
Git done (by process-git-requests).
Comment 7 Parag Nemade 2012-09-19 03:44:35 EDT
Thanks.

Package is now available in f18 and rawhide as well.

Note You need to log in before you can comment on or make changes to this bug.