Bug 853379 - Review Request: perl-Net-CLI-Interact - Toolkit for CLI Automation
Summary: Review Request: perl-Net-CLI-Interact - Toolkit for CLI Automation
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
Depends On: 853378
Blocks: 853380
TreeView+ depends on / blocked
Reported: 2012-08-31 10:00 UTC by Simone Caronni
Modified: 2012-09-23 18:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-09-17 17:44:21 UTC
Type: ---
jplesnik: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Simone Caronni 2012-08-31 10:00:03 UTC
Spec URL: http://slaanesh.fedorapeople.org/perl-Net-CLI-Interact.spec
SRPM URL: http://slaanesh.fedorapeople.org/perl-Net-CLI-Interact-1.122100-1.fc17.src.rpm
Description: This module exists to support developers of applications and libraries which
must interact with a command line interface. This module aims to provide a
simple and manageable interface to CLI interactions, supporting:
- SSH, Telnet and Serial-Line connections
- Unix and Windows support
- Reuseable device command phrasebooks
Fedora Account System Username: slaanesh

Comment 1 Simone Caronni 2012-09-03 14:46:46 UTC
Regenerated spec file with cpanspec:

Spec URL: http://slaanesh.fedorapeople.org/perl-Net-CLI-Interact.spec
SRPM URL: http://slaanesh.fedorapeople.org/perl-Net-CLI-Interact-1.122100-2.fc17.src.rpm

Comment 2 Jitka Plesnikova 2012-09-04 08:20:07 UTC
Package Review

- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[-]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[-]: SHOULD Package does not include license text files separate from
[x]: SHOULD SourceX tarball generation or download is documented.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
[x]: SHOULD %check is present and all tests pass.
[-]: SHOULD Packages should try to preserve timestamps of original installed
[x]: SHOULD Spec use %global instead of %define.

* Missing BuildRequires
  perl(IO::Pty) - ./lib/Net/CLI/Interact/Transport/Role/ConnectCore.pm:47

Please update BR.

Package is APPROVED.
It could be commit when perl-Log-Dispatch-Configurator-Any is in

Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09

Comment 3 Simone Caronni 2012-09-04 09:00:55 UTC
(In reply to comment #2)
> Issues:
> * Missing BuildRequires
>   perl(IO::Pty) - ./lib/Net/CLI/Interact/Transport/Role/ConnectCore.pm:47
> Please update BR.

Thanks for the review, updated my local copy. It will be in git.

Comment 4 Simone Caronni 2012-09-04 09:01:53 UTC
New Package SCM Request
Package Name: perl-Net-CLI-Interact
Short Description: Toolkit for CLI Automation
Owners: slaanesh
Branches: f16 f17 f18 el6

Comment 5 Gwyn Ciesla 2012-09-04 13:48:16 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2012-09-04 14:57:49 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc16,perl-Net-Appliance-Session-3.122100-2.fc16,perl-Net-CLI-Interact-1.122100-2.fc16 has been submitted as an update for Fedora 16.

Comment 7 Fedora Update System 2012-09-04 14:58:30 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc17,perl-Net-Appliance-Session-3.122100-2.fc17,perl-Net-CLI-Interact-1.122100-2.fc17 has been submitted as an update for Fedora 17.

Comment 8 Fedora Update System 2012-09-04 14:59:07 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc18,perl-Net-Appliance-Session-3.122100-2.fc18,perl-Net-CLI-Interact-1.122100-2.fc18 has been submitted as an update for Fedora 18.

Comment 9 Fedora Update System 2012-09-04 15:02:34 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.el6,perl-Net-Appliance-Session-3.122100-2.el6,perl-Net-CLI-Interact-1.122100-2.el6 has been submitted as an update for Fedora EPEL 6.

Comment 10 Fedora Update System 2012-09-04 16:53:56 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc18, perl-Net-Appliance-Session-3.122100-2.fc18, perl-Net-CLI-Interact-1.122100-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 11 Fedora Update System 2012-09-17 17:44:21 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc17, perl-Net-Appliance-Session-3.122100-2.fc17, perl-Net-CLI-Interact-1.122100-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 12 Fedora Update System 2012-09-17 18:02:34 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc16, perl-Net-Appliance-Session-3.122100-2.fc16, perl-Net-CLI-Interact-1.122100-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 13 Fedora Update System 2012-09-17 22:47:53 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.fc18, perl-Net-Appliance-Session-3.122100-2.fc18, perl-Net-CLI-Interact-1.122100-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 14 Fedora Update System 2012-09-23 18:28:31 UTC
perl-Log-Dispatch-Configurator-Any-1.110690-5.el6, perl-Net-Appliance-Session-3.122100-2.el6, perl-Net-CLI-Interact-1.122100-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.