Bug 853489
| Summary: | Users#show cosmetic issue if user does not have Privilege::VIEW, User permission | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] CloudForms Cloud Engine | Reporter: | Matt Wagner <matt.wagner> | ||||
| Component: | aeolus-conductor | Assignee: | Angus Thomas <athomas> | ||||
| Status: | CLOSED EOL | QA Contact: | Rehana <aeolus-qa-list> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 1.0.0 | CC: | athomas, morazi | ||||
| Target Milestone: | rc | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-03-27 18:34:12 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Taking this to fix myself -- it should be a 10-second fix. Pull request sent: https://github.com/aeolusproject/conductor/pull/29 Oops, this has been committed for a while now. On master, picked from 1.1:
commit eab3cd906d3c14424c2114282a95c0c5a375a62d
Author: Matt Wagner <matt.wagner>
Date: Fri Aug 31 17:00:38 2012 -0400
Always show .obj_actions on Users#show
The content should be conditional on permissions, but omitting the
container itself causes styling problems.
(cherry picked from commit 117bbb67446b9535e442df929de15bec81b5d53e)
|
Created attachment 608587 [details] Styling with missing top row Description of problem: If a user is viewing their own profile (the default when clicking 'Administer' for unprivileged users), the "Return to Users" link is omitted if the user doesn't have permission to view that. This is correct, but we also omit its parent .obj_actions div, which causes the page to look ugly. See attached screenshot. Version-Release number of selected component (if applicable): Upstream master, probably all How reproducible: Whenever logged in as a user who cannot view user listing. Steps to Reproduce: 1. Log in as an unprivileged user (user should not have privilege to view user listing -- a default user with no special privileges is good for testing this) 2. Click "Administer" Actual results: "Return to Users" is not displayed (correct -- not a bug), nor is its parent container (the bug), causing styling issue. Expected results: .obj_actions div is displayed, allowing page to display properly, but "Return to Users" is still not displayed. Additional info: