Bug 854605 - Review Request: python-moksha-common - Common components for Moksha
Review Request: python-moksha-common - Common components for Moksha
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Patrick Uiterwijk
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 854608 854609
  Show dependency treegraph
 
Reported: 2012-09-05 08:25 EDT by Ralph Bean
Modified: 2012-09-05 20:24 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-09-05 20:24:16 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
puiterwijk: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ralph Bean 2012-09-05 08:25:30 EDT
Spec URL: http://threebean.org/rpm/python-moksha-common.spec
SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-1.fc17.src.rpm
Description: Common components for Moksha
Fedora Account System Username: ralph

rpmlint output:

python-moksha-common.noarch: W: no-manual-page-for-binary moksha
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

koji - f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4456765


There already exists a package moksha (version 0.8.8 in rawhide).  I've done work upstream to split it into three different namespace packages to lighten the dependency load on some machines.
Comment 1 Ralph Bean 2012-09-05 08:39:07 EDT
Quick second release: disable tests since they are failing in koji.  It's something odd with the version of python-mock.

Spec URL: http://threebean.org/rpm/python-moksha-common.spec
SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-2.fc17.src.rpm
Comment 2 Patrick Uiterwijk 2012-09-05 09:12:26 EDT
I'll review this soon.
Comment 3 Ralph Bean 2012-09-05 10:21:02 EDT
Quick third release changing license to the more correct "ASL 2.0 or MIT":


Spec URL: http://threebean.org/rpm/python-moksha-common.spec
SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-3.fc17.src.rpm
Comment 4 Ralph Bean 2012-09-05 10:42:18 EDT
Still another:  Use %{optflags}:

Spec URL: http://threebean.org/rpm/python-moksha-common.spec
SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-4.fc17.src.rpm
Comment 5 Patrick Uiterwijk 2012-09-05 11:03:05 EDT
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistent macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (ASL 2.0 or MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum.

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
See below - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 

1. This spec is not allowed for el5 as it misses the buildroot and %clean sections. 

2. rpmlint says: 
python-moksha-common.noarch: W: no-manual-page-for-binary moksha
2 packages and 1 specfiles checked; 0 errors, 1 warnings.


I see no blockers anymore, so this package is APPROVED.
Comment 6 Ralph Bean 2012-09-05 11:07:05 EDT
New Package SCM Request
=======================
Package Name: python-moksha-common
Short Description: Common components for Moksha
Owners: ralph lmacken
Branches: f16 f17 f18 el6
InitialCC:
Comment 7 Gwyn Ciesla 2012-09-05 11:20:07 EDT
Git done (by process-git-requests).
Comment 8 Ralph Bean 2012-09-05 20:23:44 EDT
Bodhi updates -> https://admin.fedoraproject.org/updates/python-moksha-common

Note You need to log in before you can comment on or make changes to this bug.