Red Hat Bugzilla – Bug 855451
libgpg-error should build static libs for gpgme unit testing
Last modified: 2012-09-26 01:55:23 EDT
Created attachment 610833 [details] Patch to reenable building static libs in libgpg-error-devel RPM The libgpg-error-devel RPM does not contain %{_libdir}/libgpg-error.a, needed by gpgme to run the basic gpg unit tests. gpgme unit tests would currently fail, except they've been disabled because they won't build without these static libs. (Soon will file a ticket dependent on this bug.) I'm attaching a patch to re-enable building the static libs. The patch also updates .gitignore to ignore fedpkg local build artifacts.
Could the tests in gpgme be patched to use the shared library? I'd like to avoid shipping static libraries just for tests of gpgme. Also the patch is not correct as it does not comply with the packaging guidelines in regards to static libraries.
Sorry for not getting back earlier. I'm ambivalent as to what package maintainers finally decide upon. I don't like shipping static libs just for this purpose, either. On the other hand, I think gpgme ought to run its unit tests, and especially if it's failing some of them. The package can be patched to use the shared library; that's how I first got the tests to work. If that's acceptable within the guidelines, it sounds like a nice workaround. (Still new to those guidelines; I don't mind doing the work for this fix, but appreciate advice on what's acceptable and what's not!) John
Patching gpgme to use shared libraries for tests is definitely acceptable and within guidelines.
Bug #855454: a patch to the gpgme package to link against shared libs has been submitted. Thanks- John