Bug 857223 - Errant HTML comment in source code
Summary: Errant HTML comment in source code
Keywords:
Status: CLOSED EOL
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 1.1.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
Assignee: Angus Thomas
QA Contact: Rehana
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-13 20:03 UTC by Matt Wagner
Modified: 2020-03-27 18:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-27 18:37:39 UTC
Embargoed:


Attachments (Terms of Use)

Description Matt Wagner 2012-09-13 20:03:42 UTC
Description of problem:
In Conductor (both 1.1 and upstream master), there is a bit of haml that's commented out -- but the way it's commented out causes it to display as an HTML comment. The head of the page shows:

<!-- = content_for :javascripts_block do -->


Steps to Reproduce:
1. Log into Conductor
2. View source (top of page)

  
Actual results:
haml displayed in HTML comment.


Expected results:
Random haml not displayed in HTML comments.


Additional info:
Since it's just commented out, we should just remove this, rather than trying to change the comment type.

Comment 2 Matt Wagner 2012-09-14 12:58:53 UTC
On master (_not_ in scope for 1.1):

commit f8cb475b839a159109620ee42b4f54c4111a17f7
Author: Matt Wagner <matt.wagner>
Date:   Thu Sep 13 16:05:59 2012 -0400

    BZ 857223 - Removes a malformed haml comment from layout
    
    This was displaying the haml as an HTML comment, which was
    kind of silly. Since it wasn't used, I'm just removing it.
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=857223


Note You need to log in before you can comment on or make changes to this bug.