RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 857281 - [qemu] speed unit of "block-job-set-speed" command mismatch descriped in qemu-monitor.hx
Summary: [qemu] speed unit of "block-job-set-speed" command mismatch descriped in qemu...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.4
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: ---
Assignee: Luiz Capitulino
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-14 02:38 UTC by Xu Tian
Modified: 2012-09-24 13:42 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-09-24 13:42:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Xu Tian 2012-09-14 02:38:48 UTC
Description of problem:

unit of value argurment for "block-job-set-speed" descripted in qemu-monitor.hx of source code, is "in bytes per second" but in fact, it's "Megabyte per second"
;

description in qemu-monitor.hx 

block-job-set-speed
-------------------

Set maximum speed for a background block operation.

This command can only be issued when there is an active block job.

Throttling can be disabled by setting the speed to 0.

Arguments:

- device: the device name
- value:  the maximum speed, in bytes per second


Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:

1. start a block-stream job by send below command to qmp monitor

{"execute": "human-monitor-command", "arguments": { "command-line": "block-stream drive-virtio-disk1"}}


2. set job speed by command 
{"execute": "human-monitor-command", "arguments": { "command-line": "block-job-set-speed drive-virtio-disk1 1 "}}

3. query job status by command:
{"execute": "query-block-jobs"}

  
Actual results:

speed: 1048576 

Expected results:

according description in qemu-monitor.hx  expect result should be speed:1 , but it's not human-read if values is very very big; so I hope to update qemu-monitor.hx to fix this issue; 

Additional info:

[xu@xutian-dev qemu-kvm]$ git config --list
.....
core.logallrefupdates=true
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
remote.origin.url=git://git.app.eng.bos.redhat.com/virt/rhel6/qemu-kvm.git
branch.rhel6/master.remote=origin
branch.rhel6/master.merge=refs/heads/rhel6/master

Comment 2 Luiz Capitulino 2012-09-24 13:42:42 UTC
That's correct.

The text you quoted describes the QMP interface, where the speed is in bytes per second. But the human-monitor-command uses the HMP interface, where the speed is in megabytes per second.


Note You need to log in before you can comment on or make changes to this bug.