Bug 858077 - Review Request: mingw-qt5-qtsensors - Qt5 for Windows - QtSensors component
Summary: Review Request: mingw-qt5-qtsensors - Qt5 for Windows - QtSensors component
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: greg.hellings
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 858058 858064
Blocks: 858084
TreeView+ depends on / blocked
 
Reported: 2012-09-17 22:46 UTC by Erik van Pienbroek
Modified: 2013-08-12 18:16 UTC (History)
5 users (show)

Fixed In Version: mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19
Clone Of:
Environment:
Last Closed: 2013-06-01 03:24:04 UTC
Type: Bug
Embargoed:
greg.hellings: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Erik van Pienbroek 2012-09-17 22:46:04 UTC
Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtsensors/mingw-qt5-qtsensors.spec
SRPM URL: http://ftd4linux.nl/contrib/mingw-qt5-qtsensors-5.0.0-0.1.beta1.fc17.src.rpm
Fedora Account System Username: epienbro
Description: 
This package contains the Qt software toolkit for developing
cross-platform applications.

This is the Windows version of Qt, for use in conjunction with the
Fedora Windows cross-compiler.

Comment 1 Erik van Pienbroek 2012-11-13 01:05:57 UTC
Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtsensors/mingw-qt5-qtsensors.spec
Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtsensors-5.0.0-0.2.beta1.git20121112.ac76c8d5.fc19.src.rpm

* Mon Nov 12 2012 Erik van Pienbroek <epienbro> - 5.0.0-0.2.beta1.git20121112.ac76c8d5
- Update to 20121112 snapshot (rev ac76c8d5)
- Rebuild against latest mingw-qt5-qtbase
- Dropped pkg-config rename hack as it's unneeded now

Comment 2 Erik van Pienbroek 2013-02-09 16:37:54 UTC
Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtsensors/mingw-qt5-qtsensors.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtsensors/5.0.0/0.4.git20130209.f7f1d56c.fc19/src/mingw-qt5-qtsensors-5.0.0-0.4.git20130209.f7f1d56c.fc19.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=127

* Sat Feb 09 2013 Erik van Pienbroek <epienbro> - 5.0.0-4.git20130209.f7f1d56c
- Update to 20130209 snapshot (rev f7f1d56c) (upstream hasn't done an official release yet)

* Thu Jan 03 2013 Erik van Pienbroek <epienbro> - 5.0.0-3.git20121112.ac76c8d5
- Fix filelist

Comment 3 Erik van Pienbroek 2013-05-11 17:24:58 UTC
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtsensors/mingw-qt5-qtsensors.spec
Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtsensors/5.0.0/0.5.git20130510.ceec1eda.fc20/src/mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc20.src.rpm
Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=141

* Fri May 10 2013 Erik van Pienbroek <epienbro> - 5.0.0-5.git20130510.ceec1eda
- Update to 20130510 snapshot (rev ceec1eda)

Comment 4 greg.hellings 2013-05-20 14:12:00 UTC
$ rpmlint mingw-qt5-qtsensors.spec 
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.spec: W: invalid-url Source0: qt5-qtsensors-ceec1eda.tar.gz
0 packages and 1 specfiles checked; 0 errors, 5 warnings.

$ rpmlint mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc20.src.rpm 
mingw-qt5-qtsensors.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.src: W: invalid-url Source0: qt5-qtsensors-ceec1eda.tar.gz
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

$ rpmlint results_mingw-qt5-qtsensors/5.0.0/0.5.git20130510.ceec1eda.fc18/mingw*.noarch.rpm
mingw32-qt5-qtsensors.noarch: W: no-documentation
mingw32-qt5-qtsensors-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtsensors.noarch: W: no-documentation
mingw64-qt5-qtsensors-debuginfo.noarch: E: debuginfo-without-sources
4 packages and 0 specfiles checked; 2 errors, 2 warnings.

$ rpm -q --requires mingw32-qt5-qtsensors
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
mingw32(qt5core.dll)
mingw32(qt5qml.dll)
mingw32(qt5sensors.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qtsensors
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
mingw64(qt5core.dll)
mingw64(qt5qml.dll)
mingw64(qt5sensors.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qtsensors
mingw32-qt5-qtsensors = 5.0.0-0.5.git20130510.ceec1eda.fc18
mingw32(qt5sensors.dll)
mingw32(qtsensorgestures_plugin.dll)
mingw32(qtsensorgestures_shakeplugin.dll)
mingw32(qtsensors_dummy.dll)
mingw32(qtsensors_generic.dll)
mingw32(declarative_sensors.dll)

$ rpm -q --provides mingw64-qt5-qtsensors
mingw64-qt5-qtsensors = 5.0.0-0.5.git20130510.ceec1eda.fc18
mingw64(qt5sensors.dll)
mingw64(qtsensorgestures_plugin.dll)
mingw64(qtsensorgestures_shakeplugin.dll)
mingw64(qtsensors_dummy.dll)
mingw64(qtsensors_generic.dll)
mingw64(declarative_sensors.dll)


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
    or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal

All of the discrepancies and warnings have been discussed before and are acceptable.

Comment 5 Erik van Pienbroek 2013-05-20 15:10:01 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: mingw-qt5-qtsensors
Short Description: Qt5 for Windows - QtSensors component
Owners: epienbro
Branches: f17 f18 f19
InitialCC:

Comment 6 Gwyn Ciesla 2013-05-20 15:21:16 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-05-21 17:43:49 UTC
mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19,mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19,mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc19

Comment 8 Fedora Update System 2013-05-22 22:41:10 UTC
mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19, mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-06-01 03:24:04 UTC
mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19, mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.