RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 858162 - improve virsh error msg when client reach max connection limit
Summary: improve virsh error msg when client reach max connection limit
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.4
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Gunannan Ren
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-18 08:10 UTC by zhpeng
Modified: 2013-09-09 00:03 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-09-18 13:54:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description zhpeng 2012-09-18 08:10:51 UTC
Description
Error msg is not clear when client reach max connection limit.

Version
libvirt-0.10.1-2.el6.x86_64

How reproducible:
100%

Steps:
1. modify libvirtd.conf, restart libvirtd
max_clients = 2

2. open 2 more terminal and connect libvirtd.
# virsh -c qemu+ssh://10.66.7.230/system
root.7.230's password:
...
virsh -c qemu+ssh://10.66.7.230/system
root.7.230's password:
...

3.make the third connection:
# virsh -c qemu:///system
error: Cannot recv data: Connection reset by peer
error: failed to connect to the hypervisor
# virsh  -c qemu+ssh://10.66.7.230/system
root.7.230's password:
error: End of file while reading data: : Input/output error
error: failed to connect to the hypervisor

So, virsh client got 2 kinds of error msg, actually libvirtd.log have a clear msg:

2012-09-18 07:05:49.265+0000: 30920: error : virNetServerAddClient:273 : Too many active clients (2), dropping connection from 127.0.0.1;0

So i think we should improve virsh client error msg, these error are very confused and dehumanization.


Actual result
Failed with not clear msg

Expect result
Show user why connection failed.

Additional info

Comment 2 Dave Allan 2012-09-18 12:54:45 UTC
I agree that this message could be better, simply reporting "Too many active clients" to the requesting client would be a great improvement.

Comment 3 Daniel Berrangé 2012-09-18 12:56:52 UTC
> I agree that this message could be better, simply reporting "Too many active
> clients" to the requesting client would be a great improvement.

A nice idea, but not possible. The whole point of this limit is to immediately drop any client connections *without* consuming resources to perform I/O with them. As such the server can't & won't send any error message back to the client.

Comment 4 Dave Allan 2012-09-18 13:10:22 UTC
(In reply to comment #3)
> > I agree that this message could be better, simply reporting "Too many active
> > clients" to the requesting client would be a great improvement.
> 
> A nice idea, but not possible. The whole point of this limit is to
> immediately drop any client connections *without* consuming resources to
> perform I/O with them. As such the server can't & won't send any error
> message back to the client.

Oh, ugh, so the client's just getting TCP connection refused or similar?

Comment 5 Daniel Berrangé 2012-09-18 13:14:59 UTC
No, it gets end-of-file from the server

Comment 6 Dave Allan 2012-09-18 13:54:34 UTC
Ok, given that the design doesn't expect huge numbers of connections, I'm willing to accept this behavior.


Note You need to log in before you can comment on or make changes to this bug.