Red Hat Bugzilla – Bug 859504
Review Request: php-xcache - Fast, stable PHP opcode cacher
Last modified: 2012-12-11 15:29:26 EST
Spec URL: https://raw.github.com/remicollet/remirepo/master/php/php-xcache/php-xcache.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-xcache-2.0.1-3.remi.src.rpm Description: XCache is a fast, stable PHP opcode cacher that has been tested and is now running on production servers under high load. It is tested (on linux) and supported on all of the latest PHP release. ThreadSafe is also perfectly supported. It overcomes a lot of problems that has been with other competing opcachers such as being able to be used with new PHP versions. Fedora Account System Username: remi Target: F17+, EPEL6+ I keep compatibility stuff to allow backport to older release and will work on fixing the EL-5 build.
* Sat Oct 27 2012 Remi Collet <remi@fedoraproject.org> - 2.0.1-4 - drop php prefix from sub packages - clean EL-5 stuff https://github.com/remicollet/remirepo/commit/d55126ec61ab2c558bc1193bf305e3e4174961fc Spec URL: https://raw.github.com/remicollet/remirepo/master/php/php-xcache/php-xcache.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-xcache-2.0.1-4.remi.src.rpm
EPEL-6 Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4630662
Update to new major version 3.0.0 https://github.com/remicollet/remirepo/commit/02335b381fb00c98a9bca31c0322db480116cf8b Spec URL: https://raw.github.com/remicollet/remirepo/master/php/php-xcache/php-xcache.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-xcache-3.0.0-1.remi.src.rpm
Created attachment 650714 [details] fedora-review results
Created attachment 650715 [details] source diff
BLOCKER: sources mismatch :( It seems that upstream has modified their tarball on november 9, adding some files and fixing release number... I guess the sed to remove -dev in your specfile is therefore no longer needeed. Also, it seems that your package should Requires php-common and not php. At last, review script complains about conflicts, but it seems that is ok for that package.
(In reply to comment #6) > BLOCKER: sources mismatch :( > > It seems that upstream has modified their tarball on november 9, adding some > files and fixing release number... Grr... fixed. https://github.com/remicollet/remirepo/commit/51ffa463f4c25df76928f1ff576b60b1ed6fe04f > I guess the sed to remove -dev in your specfile is therefore no longer > needeed. Yes (at least, it proves that my sanity check is useful) > Also, it seems that your package should Requires php-common and not php. fedora-review false positive. The library doesn't requires php (only php abi). The web-app requires httpd and mod_php as it provides a httpd config file. > At last, review script complains about conflicts, but it seems that is ok > for that package. Yes (we already have this conflicts in the other opcode caches, eAccelerator and APC) Spec URL: https://raw.github.com/remicollet/remirepo/master/php/php-xcache/php-xcache.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-xcache-3.0.0-1.remi.1.src.rpm
Ok, well: - sources matches upstream, - require on php abi is fine, - conflict is documented. ***** APPROVED *****
Thanks for the review New Package SCM Request ======================= Package Name: php-xcache Short Description: Fast, stable PHP opcode cacher Owners: remi Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-xcache-3.0.0-1.fc18.1 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-xcache-3.0.0-1.fc18.1
php-xcache-3.0.0-1.fc17.1 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-xcache-3.0.0-1.fc17.1
php-xcache-3.0.0-1.el6.1 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-xcache-3.0.0-1.el6.1
php-xcache-3.0.0-1.el6.1 has been pushed to the Fedora EPEL 6 testing repository.
php-xcache-3.0.0-1.fc18.1 has been pushed to the Fedora 18 stable repository.
php-xcache-3.0.0-1.fc17.1 has been pushed to the Fedora 17 stable repository.
php-xcache-3.0.0-1.el6.1 has been pushed to the Fedora EPEL 6 stable repository.