Bug 859962

Tomas Repel:
I've read the document, here are my observations. Hopefully at least some of them are relevant:

1.2.1. Using the Command Line
 - currently latest version of archetype available in maven central is 1.0.0.M4
 - at the very end of page there is a note about QUnit. What I miss is to tell the reader that the application server has to be up and running and the example should be deployed for QUnit tests to pass

1.2.2. Using JBoss Developer Studio
 - in Procedure 1.3. Deploying the Project with JBoss Developer Studio, after step 3.,Figure 1.2 Management tab picture is redundant, can be deleted

2.1. Client Source Code
 - the file index.html has a bit different content than the one shown in source code border, e.g. the title text and the paths to *.js files have changed

2.1.1. HTML5 Semantic Tags and Structure
 - in generated example in index.html, footer element is outside the the section element, not inside as shown in source code border

2.1.2. HTML5 Form API
 - in source code border, 'Register a user' should by replaced by 'Register a member'
 - typo in paragraph Input Validation: 'Safari,a nd' should be 'Safari, and'

2.1.4. CSS Files
 - it is said that there are two css files: screen.css and m.screen.css, but in the generated example there is third css file: d.screen.css

2.1.6.1. Member.java (and a few further sections too)
 - the package 'org/jboss/as/quickstarts/html5_mobile' used in the document does not correspond to the default package value 'org.jboss.tools.example.html5'

2.1.6.2. MemberService.java, the text between 2nd and 3rd source code border
 - It starts with 'The methods above...', but I think it is related to the methods in the source code border below, not above
 - I can't see the way how to access the members in XML format in the example, but the last sentence claims that it is possible
 - there is neither createMemberGet nor createMemberPost method in MemberService.java, only one createMember method. The 3rd and 4th source code border show code that is not in the example at all
 - only the last comment and last command from the code in the last (7th) source code border remain in MemberServce.java, the rest of code is shifted to the MemberRegistration's register method

1.2.1: Correct version shown and QUnit testing text updated

1.2.2: Agreed the image is redundant but may assist a user with their understanding of the procedure. 

2.1: Can you please provide the correct title and *.js file paths please

2.1.1: The footer element can be used inside or outside of a section.

2.1.2: code updated and typo fixed

2.1.4: Can you please let me know what the third CSS file is for? d.screen.css. The text in the book describes what the other two are for so I would like to be able to do the same for this third one. 

Thanks :)

2.1.6.1: Sorry I'm not sure what has to be changed here? Is the file location in the document wrong and should be pointing to a different file? If so, can you please let me know the filepath for the correct file. Thanks :D

2.1.6.2: All updated, though the text of below or above does refer to the above code sample.

For this: "I can't see the way how to access the members in XML format in the example" -> are you able to provide any missing XML?

In terms of 1.2.2, I now understand what you mean and have removed the image. Thanks for picking that up :) I didn't even notice the image was duplicated when looking over it again myself.

Hi Isaac, here's my notes:

1.2.1 - now OK, but meanwhile there are newer version available on maven central: 1.0.0.M6c

2.1 - see index.html in the attachment for content generated by 1.0.0.M6c archetype version

2.1.1 - hm, but if the footer is outside the section in generated example, it is better if the same says the documentation, but I agree this is a minor thing.

2.1.4 - there is a m.screen.css for Mobile devices, d.screen.css for Desktop machines and screen.css with styles common for both.

2.1.6.1 - the paths to the classes depends on how you generated the example from archetype. See chapter 1.2.1, Step Three. The paths depends on value for Package. If you leave the Package blank, the value from GroupID is taken. So the 'org/jboss/as/quickstarts/html5_mobile' part is not necessarily correct because reader can provide different Package or GroupID during generation. The solution could be to add some example value for Package or GroupID in 1.2.1, Step Three and then use this value in paths to java classes, e.g.: <project-root>/src/main/java/<example_value_for_package>/rest/MemberService.java

2.1.6.2
 - 3rd paragraph: 'There are two ways of ...till the very end' - this section is not true anymore, currently there is only one way how to create member, the one using POST approach. Thus this has to be rewording accordingly. Something simple should be enough, there is also the code snippet of createMember method that is responsible for creating new members.

 - 3rd code border '//Create a new member class from fields ...' - this refers to removed GET approach, this code is no longer in the example. The two lines above relates to this code border, should be removed as well.

Hopefully it's a bit clearer now, I will see :)

Created attachment 646350 [details]
1.0.0.M6c index.html

2.1: Do we need to include the code? Since the code will continually change can we just remove it and explain the file without the code snippets included

2.1.6.1: As same as for 2.1 I feel that the code can become very outdated, very fast and doesn't add much to a users understanding of what is being explained (since they could easily look at the distributed code). So I think we could remove the code....what do you think?

All other issues have been corrected

I would say the code can be removed. You're right that users can look at the code directly.

2.1 (Header title): I have noticed that the all the paragraphs here refer to index.html with one exception - the 'The app.js...' paragraph. I would move this to the end of the section (right after the '3. When these are complete...')

Hey Tomas,

I've updated the guide with the fix in your last comment and have removed the code I feel doesn't need to be in the guide to assist with explanation.

Hello, few other issues:

1.2.1 - in '$JBOSS_HOME/bin/standalone.bat' path for windows the backslashes should be used. There are two occurrences of this path.

Chapter 2. Further Information - in very first paragraph, 'quickstarts that are part' should be replaced by 'quickstart that is part'

2.1.4. CSS Files
  - just reminder that note about d.screen.css still missing (see comment 5 and comment 10)
  - in code border, replace 'tr:' by '> div:'

2.1.6.2 MemberService.java - replace 'them' by 'then' in '...member is not valid them a map is created...'

for d.screen.css the text was rewritten based on the information given in the referenced comments and the note is no longer necessary for what is being described.

All other issues now fixed

Lucas Holmquist <lholmqui> made a comment on jira AEROGEAR-469

Hey guys,  just wanted to know how these changes will make it back to our repo,  will a PR be sent?

Karel Piwko <kpiwko> made a comment on jira AEROGEAR-469

Hi Lucas,

for some of those changes it would definitely make sense to do a PR and backport changes to upstream. I'll try to coordinate that next week.

Lucas Holmquist <lholmqui> made a comment on jira AEROGEAR-469

Hey Karel,  just wanted to see if there was any new status on this

Tomas Repel <trepel> made a comment on jira AEROGEAR-469

Hello Lucas,
Pull Request sent, if something unclear or something could be done better, just let me know. Pull Request URL: https://github.com/aerogear/aerogear.org/pull/16

Lucas Holmquist <lholmqui> updated the status of jira AEROGEAR-469 to Resolved

Verified in WFK 2.2.0.ER1.

Closed as CURRENTRELEASE, part of WFK 2.2.0 distributables.