Bug 860550 - do not recognize GASP table version 1
Summary: do not recognize GASP table version 1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fontforge
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-09-26 06:39 UTC by Pravin Satpute
Modified: 2012-12-20 15:22 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-20 15:22:23 UTC
Type: Bug


Attachments (Terms of Use)
Commit that fixed this (2.22 KB, patch)
2012-09-26 17:07 UTC, Paul Flo Williams
no flags Details | Diff

Description Pravin Satpute 2012-09-26 06:39:15 UTC
Description of problem:
In LiberatoinSans-Regular.sfd, i did changes and made GASP table version 1 and saved.
But when i again reopen it, it should me GASP table 1

Version-Release number of selected component (if applicable):
fontforge-20110222-7.fc17.x86_64

How reproducible:
everytime

Steps to Reproduce:
1. open LiberationSans-Regular.sfd
2. Element-> Font Information -> Grid Fitting
3. Select Version 1
4. Save and reopen
5. Again it shows Version 0

Actual results:
It does not recognize GASP table version 1

Expected results:
Once save, it should show Version 1 GASP table values

Additional info:
Liberation fonts sfd http://git.fedorahosted.org/cgit/liberation-fonts.git/tree/src/LiberationSans-Regular.sfd

Comment 2 Kevin Fenzi 2012-09-26 15:52:52 UTC
Thanks for filing this upstream. ;)

Comment 3 Paul Flo Williams 2012-09-26 17:07:23 UTC
Created attachment 617672 [details]
Commit that fixed this

The version of the GASP table didn't used to be saved to the SFD at all. This was fixed upstream on 2011-09-18 with commit a0fd436141fa402056ec9f247b3f50cf2b3ecb31, by appending the GASP version to the end of the GASPTable: line of the SFD, and reading it back correctly.

(Sorry, can't patch this today, but feel free if you have time, Kevin.)

Comment 4 Pravin Satpute 2012-09-27 10:08:45 UTC
Thanks Paul for pointing towards patch.

I have done scratch build with it http://koji.fedoraproject.org/koji/taskinfo?taskID=4532402

Still this does not solve problem fully. 
Fontforge is not able to store 4th and 5th column of GASP table
that is Symmetric Smoothing  and Grid Fitting W/ Sym-Smoothing.

Does any development happened on this as well?

Comment 5 Paul Flo Williams 2012-10-01 09:15:11 UTC
I think we need to move F17 to FontForge version 20120731-b. This is already in Rawhide (and, I think, F18). There have been plenty of common crashers fixed since the last release, and this is probably our last chance to update that doesn't bring with it a heap of user interface changes.

As an aside: Pravin, if you wish to file any more bugs upstream (and it's great that you're willing to do so), please use the tracker on GitHub instead of SourceForge, as that is the new upstream. The current list is here:

https://github.com/fontforge/fontforge/issues?state=open

Comment 6 Pravin Satpute 2012-10-01 09:24:52 UTC
Yes sure.
Might be we should update, upstream URL in spec file as well.

Comment 7 Kevin Fenzi 2012-10-01 14:28:28 UTC
I'm ok with a f17 bugfix only update... ;) 

Can you push it out Paul?

Comment 8 Fedora Update System 2012-10-01 20:53:54 UTC
fontforge-20120731b-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/fontforge-20120731b-1.fc17

Comment 9 Fedora Update System 2012-10-02 15:51:28 UTC
Package fontforge-20120731b-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing fontforge-20120731b-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-15195/fontforge-20120731b-1.fc17
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2012-12-20 15:22:25 UTC
fontforge-20120731b-1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.