Spec URL: http://mbartos.fedorapeople.org/libmongo-client.spec SRPM URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-1.fc17.src.rpm Description: Alternative C driver for MongoDB. Libmongo-client is meant to be a stable (API, ABI and quality alike), clean, well documented and well tested shared library, that strives to make the most common use cases as convenient as possible. Fedora Account System Username: mbartos Hi, there is a spec file and src.rpm file for libmongo-client, an alternative C driver for mongodb and I'd appreciate a review. Thanks, Milan Bartos
Hi Milan Initial Comments: %{name} = %{version}-%{release} has to be %{name}%{?_isa} = %{version}-%{release} to match the correct architecture. Please rpmlint out of the SRPMS, spec and RPMS and additionally Koji Builds of the versions where you want to build the package. Regards
New spec file and src.rpm are at http://mbartos.fedorapeople.org/libmongo_client-0.1.5-2/ rpmlint output: $ rpmlint ../RPMS/x86_64/libmongo-client-*0.1.5-2* ../SRPMS/libmongo-client-0.1.5-2.fc17.src.rpm libmongo-client.spec libmongo-client-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings.
Hi Milan - Spec files placed in sight, fedora-review seek the rpm release number for to check always the last - You have a warning : libmongo-client-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. **You don't have docs in devel packages *** - just as an example, although there are many right ways to do it find . -type f -name "FILE-TO-FIND" -exec rm -f {} \; - Because if you do not build specifically static libraries? %configure --disable-static You run rm -rf to delete file .a? Best Regards
> - Because if you do not build specifically static libraries? > %configure --disable-static > You run rm -rf to delete file .a? I run rm -f %{buildroot}/%{_libdir}/*.{a,la} to delete .a and .la files. I know that .a shouldn't be there because of --disable-static, it's there just to be sure.
Hi Milan Well, IMHO you should to remove this option, You will see in the compile time what not created this static libs Could put the docs in the devel package?
You could also put the link in Source0 of upstream, or document the way it was downloaded example https://github.com/algernon/libmongo-client # Sources from github # git://github.com/algernon/libmongo-client.git # cd libmongo # git archive ....
Hi Eduardo, > Well, IMHO you should to remove this option, Why? > Could put the docs in the devel package? Added. New src.rpm and spec files are at http://mbartos.fedorapeople.org/libmongo-client-0.1.5-3/ New rpmlint: $ rpmlint ../RPMS/x86_64/libmongo-client-* ../SRPMS/libmongo-client-0.1.5-3.fc17.src.rpm libmongoclient.spec 4 packages and 1 specfiles checked; 0 errors, 0 warnings. $ > You could also put the link in Source0 of upstream, or document the way it was > downloaded That's good suggestion. Added. Thanks, Milan
Hi Milan http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Cite: "Or if there's a lot of documentation, consider putting it into a subpackage. In this case, it is recommended to use *-doc as the subpackage name, and Documentation as the value of the Group tag". Note: No URL need in Source0 http://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs Regards
Spec URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-3/libmongo-client.spec SRPM URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-3/libmongo-client-0.1.5-3.fc17.src.rpm
Spec URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-4/libmongo-client.spec SRPM URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-4/libmongo-client-0.1.5-4.fc17.src.rpm Hi, I've added doc as a separate package and fixed "No URL need in Source0". Regards, Milan
Not build in Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=4554524 Output => ./autogen.sh ./autogen.sh: line 3: libtoolize: command not found ./autogen.sh: line 4: aclocal: command not found ./autogen.sh: line 5: autoheader: command not found ./autogen.sh: line 6: automake: command not found ./autogen.sh: line 7: autoconf: command not found RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.fZG7L7 (%build)
Spec URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-5/libmongo-client.spec SRPM URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-5/libmongo-client-0.1.5-5.fc17.src.rpm Sorry, forgot to add dependencies for autogen.sh New spec file and src.rpm. Tested with mock.
rpmlint output: > libmongo-client.src: W: invalid-url Source0: libmongo-client-0.1.5.tar.gz > libmongo-client-devel.x86_64: W: no-documentation both OK. Review blocker: * The /usr/include/mongo-client needs to be owned by the -devel package ACCEPTED assuming the above is fixed.
Spec URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-6/libmongo-client.spec SRPM URL: http://mbartos.fedorapeople.org/libmongo-client-0.1.5-6/libmongo-client-0.1.5-6.fc17.src.rpm Fixed. Thanks for review.
New Package SCM Request ======================= Package Name: libmongo-client Short Description: Alternative C driver for MongoDB Owners: mbartos Branches: f17 f18
(In reply to comment #14) > Spec URL: > http://mbartos.fedorapeople.org/libmongo-client-0.1.5-6/libmongo-client.spec > > Fixed. Thanks for review. ACK
Git done (by process-git-requests).
libmongo-client-0.1.5-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libmongo-client-0.1.5-6.fc17
libmongo-client-0.1.5-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libmongo-client-0.1.5-6.fc18
libmongo-client-0.1.5-6.fc18 has been pushed to the Fedora 18 testing repository.
Package Change Request ====================== Package Name: libmongo-client New Branches: epel7 Owners: theinric czanik