Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-2.fc18.src.rpm Description:SabreDAV allows you to easily add WebDAV support to a PHP application. The base package provides some functionality used by all packages. Currently this is only an autoloader. Fedora Account System Username: jmarrero
MUST: php-sabredav-Sabre.noarch: E: description-line-too-long C SabreDAV allows you to easily add WebDAV support to a PHP application. The base package provides some functionality used by all packages. Currently SHOULD: use %global instead of define drop "rm -rf $RPM_BUILD_ROOT docdir" you are switching 3 times cd %{pear_name}-%{version}, slightly confusing this comment is also valid for 862501 and probably all other sabredav packages, you are going to submit
Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-3.fc18.src.rpm old packages here: http://marreroj.com/fedora/review-packages/old/*
almost there... SHOULD: since we are not working with epel5 you can just use BuildRequires: php-pear(PEAR) MUST: according to https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires you must require all php extensions. use 'phpci print --recursive --report extension /usr/share/pear/<sabrepackage>' to list them. now add the requirements in form of: php-<extension> <extension> must be: lowercase and not in standard or Core the installation of the doc files is screwed up: documentation must be located in %{pear_docdir}/%{pear_name}-%{version} or %{pear_docdir}/%{pear_name} still applies to all sabredav packages
(In reply to comment #3) > the installation of the doc files is screwed up: documentation must be > located in %{pear_docdir}/%{pear_name}-%{version} or > %{pear_docdir}/%{pear_name} i.e. like that: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-Translation.spec
Fixed issues all build and installed on my machine Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-4.fc18.src.rpm old packages here: http://marreroj.com/fedora/review-packages/old/*
looks good, just one rpmlint issue left: php-sabredav-Sabre.noarch: E: description-line-too-long C The Base SabreDAV package provides some functionality used by all packages. Currently this is only an autoloader. you must add a line break
Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-5.fc18.src.rpm old packages here: http://marreroj.com/fedora/review-packages/old/*
Created attachment 627000 [details] review Sabre Base == APPROVED == Minor: just make sure to correct the summary before importing the package: php-sabredav-Sabre.noarch: W: summary-not-capitalized C base for Sabre_DAV packages
Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-6.fc18.src.rpm old packages here: http://marreroj.com/fedora/review-packages/old/*
New Package SCM Request ======================= Package Name: php-sabredav-Sabre Short Description: base for Sabre_DAV packages Owners: jmarrero Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18,php-sabredav-Sabre_DAVACL-1.6.0-3.fc18,php-sabredav-Sabre_VObject-1.3.5-2.fc18,php-sabredav-Sabre_HTTP-1.6.4-3.fc18,php-sabredav-Sabre_DAV-1.6.5-1.fc18,php-sabredav-Sabre-1.0.0-6.fc18,php-channel-sabredav-1.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-sabredav-Sabre_CardDAV-1.6.5-2.fc18,php-sabredav-Sabre_DAVACL-1.6.0-3.fc18,php-sabredav-Sabre_VObject-1.3.5-2.fc18,php-sabredav-Sabre_HTTP-1.6.4-3.fc18,php-sabredav-Sabre_DAV-1.6.5-1.fc18,php-sabredav-Sabre-1.0.0-6.fc18,php-channel-sabredav-1.3-3.fc18
php-channel-sabredav-1.3-3.fc17,php-sabredav-Sabre-1.0.0-6.fc17,php-sabredav-Sabre_DAV-1.6.5-1.fc17,php-sabredav-Sabre_HTTP-1.6.4-3.fc17,php-sabredav-Sabre_VObject-1.3.5-2.fc17,php-sabredav-Sabre_DAVACL-1.6.0-3.fc17,php-sabredav-Sabre_CalDAV-1.6.4-3.fc17,php-sabredav-Sabre_CardDAV-1.6.5-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-channel-sabredav-1.3-3.fc17,php-sabredav-Sabre-1.0.0-6.fc17,php-sabredav-Sabre_DAV-1.6.5-1.fc17,php-sabredav-Sabre_HTTP-1.6.4-3.fc17,php-sabredav-Sabre_VObject-1.3.5-2.fc17,php-sabredav-Sabre_DAVACL-1.6.0-3.fc17,php-sabredav-Sabre_CalDAV-1.6.4-3.fc17,php-sabredav-Sabre_CardDAV-1.6.5-2.fc17
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18, php-sabredav-Sabre_DAVACL-1.6.0-3.fc18, php-sabredav-Sabre_VObject-1.3.5-2.fc18, php-sabredav-Sabre_HTTP-1.6.4-3.fc18, php-sabredav-Sabre_DAV-1.6.5-1.fc18, php-sabredav-Sabre-1.0.0-6.fc18, php-channel-sabredav-1.3-3.fc18, php-sabredav-Sabre_CalDAV-1.6.4-3.fc18 has been pushed to the Fedora 18 testing repository.
php-channel-sabredav-1.3-3.el6,php-sabredav-Sabre-1.0.0-6.el6,php-sabredav-Sabre_DAVACL-1.6.0-3.el6,php-sabredav-Sabre_DAV-1.6.5-1.el6,php-sabredav-Sabre_HTTP-1.6.4-3.el6,php-sabredav-Sabre_VObject-1.3.5-2.el6,php-sabredav-Sabre_CardDAV-1.6.5-2.el6,php-sabredav-Sabre_CalDAV-1.6.4-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-channel-sabredav-1.3-3.el6,php-sabredav-Sabre-1.0.0-6.el6,php-sabredav-Sabre_DAVACL-1.6.0-3.el6,php-sabredav-Sabre_DAV-1.6.5-1.el6,php-sabredav-Sabre_HTTP-1.6.4-3.el6,php-sabredav-Sabre_VObject-1.3.5-2.el6,php-sabredav-Sabre_CardDAV-1.6.5-2.el6,php-sabredav-Sabre_CalDAV-1.6.4-3.el6
php-channel-sabredav-1.3-3.fc17, php-sabredav-Sabre-1.0.0-6.fc17, php-sabredav-Sabre_DAV-1.6.5-1.fc17, php-sabredav-Sabre_HTTP-1.6.4-3.fc17, php-sabredav-Sabre_VObject-1.3.5-2.fc17, php-sabredav-Sabre_DAVACL-1.6.0-3.fc17, php-sabredav-Sabre_CalDAV-1.6.4-3.fc17, php-sabredav-Sabre_CardDAV-1.6.5-2.fc17 has been pushed to the Fedora 17 stable repository.
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18, php-sabredav-Sabre_DAVACL-1.6.0-3.fc18, php-sabredav-Sabre_VObject-1.3.5-2.fc18, php-sabredav-Sabre_HTTP-1.6.4-3.fc18, php-sabredav-Sabre_DAV-1.6.5-1.fc18, php-sabredav-Sabre-1.0.0-6.fc18, php-channel-sabredav-1.3-3.fc18, php-sabredav-Sabre_CalDAV-1.6.4-3.fc18 has been pushed to the Fedora 18 stable repository.
php-channel-sabredav-1.3-3.el6, php-sabredav-Sabre-1.0.0-6.el6, php-sabredav-Sabre_DAVACL-1.6.0-3.el6, php-sabredav-Sabre_DAV-1.6.5-1.el6, php-sabredav-Sabre_HTTP-1.6.4-3.el6, php-sabredav-Sabre_VObject-1.3.5-2.el6, php-sabredav-Sabre_CardDAV-1.6.5-2.el6, php-sabredav-Sabre_CalDAV-1.6.4-3.el6 has been pushed to the Fedora EPEL 6 stable repository.