Bug 862502 - Review Request: php-sabredav-Sabre - base for Sabre_DAV packages
Summary: Review Request: php-sabredav-Sabre - base for Sabre_DAV packages
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gregor Tätzner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 859731
Blocks: 862501
TreeView+ depends on / blocked
 
Reported: 2012-10-03 05:04 UTC by Joseph Marrero
Modified: 2012-11-28 17:38 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-11-21 04:03:25 UTC
gregor: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
review Sabre Base (4.96 KB, text/plain)
2012-10-14 15:00 UTC, Gregor Tätzner
no flags Details

Description Joseph Marrero 2012-10-03 05:04:37 UTC
Spec URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre.spec
SRPM URL: http://marreroj.com/fedora/review-packages/php-sabredav-Sabre-1.0.0-2.fc18.src.rpm
Description:SabreDAV allows you to easily add WebDAV support to a PHP application. The base package provides some functionality used by all packages. Currently this is only an autoloader.
Fedora Account System Username: jmarrero

Comment 1 Gregor Tätzner 2012-10-03 07:20:17 UTC
MUST:
php-sabredav-Sabre.noarch: E: description-line-too-long C SabreDAV allows you to easily add WebDAV support to a PHP application. The base package provides some functionality used by all packages. Currently

SHOULD:
use %global instead of define

drop "rm -rf $RPM_BUILD_ROOT docdir"

you are switching 3 times cd %{pear_name}-%{version}, slightly confusing


this comment is also valid for 862501 and probably all other sabredav packages, you are going to submit

Comment 3 Gregor Tätzner 2012-10-04 07:00:50 UTC
almost there...

SHOULD:
since we are not working with epel5 you can just use
BuildRequires: php-pear(PEAR)

MUST:
according to https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires you must require all php extensions.

use 'phpci print --recursive --report extension /usr/share/pear/<sabrepackage>' to list them.

now add the requirements in form of: php-<extension>

<extension> must be: lowercase and not in standard or Core


the installation of the doc files is screwed up: documentation must be located in %{pear_docdir}/%{pear_name}-%{version} or %{pear_docdir}/%{pear_name}


still applies to all sabredav packages

Comment 4 Gregor Tätzner 2012-10-04 07:09:32 UTC
(In reply to comment #3)
> the installation of the doc files is screwed up: documentation must be
> located in %{pear_docdir}/%{pear_name}-%{version} or
> %{pear_docdir}/%{pear_name}

i.e. like that: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-Translation.spec

Comment 6 Gregor Tätzner 2012-10-14 09:35:39 UTC
looks good, just one rpmlint issue left:

php-sabredav-Sabre.noarch: E: description-line-too-long C The Base SabreDAV package provides some functionality used by all packages. Currently this is only an autoloader.

you must add a line break

Comment 8 Gregor Tätzner 2012-10-14 15:00:17 UTC
Created attachment 627000 [details]
review Sabre Base

== APPROVED ==

Minor:
just make sure to correct the summary before importing the package:

php-sabredav-Sabre.noarch: W: summary-not-capitalized C base for Sabre_DAV packages

Comment 10 Joseph Marrero 2012-11-03 04:31:46 UTC
New Package SCM Request
=======================
Package Name: php-sabredav-Sabre
Short Description: base for Sabre_DAV packages
Owners: jmarrero
Branches: f17 f18 el6
InitialCC:

Comment 11 Gwyn Ciesla 2012-11-03 16:00:14 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2012-11-11 11:00:02 UTC
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18,php-sabredav-Sabre_DAVACL-1.6.0-3.fc18,php-sabredav-Sabre_VObject-1.3.5-2.fc18,php-sabredav-Sabre_HTTP-1.6.4-3.fc18,php-sabredav-Sabre_DAV-1.6.5-1.fc18,php-sabredav-Sabre-1.0.0-6.fc18,php-channel-sabredav-1.3-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-sabredav-Sabre_CardDAV-1.6.5-2.fc18,php-sabredav-Sabre_DAVACL-1.6.0-3.fc18,php-sabredav-Sabre_VObject-1.3.5-2.fc18,php-sabredav-Sabre_HTTP-1.6.4-3.fc18,php-sabredav-Sabre_DAV-1.6.5-1.fc18,php-sabredav-Sabre-1.0.0-6.fc18,php-channel-sabredav-1.3-3.fc18

Comment 13 Fedora Update System 2012-11-11 11:04:15 UTC
php-channel-sabredav-1.3-3.fc17,php-sabredav-Sabre-1.0.0-6.fc17,php-sabredav-Sabre_DAV-1.6.5-1.fc17,php-sabredav-Sabre_HTTP-1.6.4-3.fc17,php-sabredav-Sabre_VObject-1.3.5-2.fc17,php-sabredav-Sabre_DAVACL-1.6.0-3.fc17,php-sabredav-Sabre_CalDAV-1.6.4-3.fc17,php-sabredav-Sabre_CardDAV-1.6.5-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-channel-sabredav-1.3-3.fc17,php-sabredav-Sabre-1.0.0-6.fc17,php-sabredav-Sabre_DAV-1.6.5-1.fc17,php-sabredav-Sabre_HTTP-1.6.4-3.fc17,php-sabredav-Sabre_VObject-1.3.5-2.fc17,php-sabredav-Sabre_DAVACL-1.6.0-3.fc17,php-sabredav-Sabre_CalDAV-1.6.4-3.fc17,php-sabredav-Sabre_CardDAV-1.6.5-2.fc17

Comment 14 Fedora Update System 2012-11-11 19:52:47 UTC
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18, php-sabredav-Sabre_DAVACL-1.6.0-3.fc18, php-sabredav-Sabre_VObject-1.3.5-2.fc18, php-sabredav-Sabre_HTTP-1.6.4-3.fc18, php-sabredav-Sabre_DAV-1.6.5-1.fc18, php-sabredav-Sabre-1.0.0-6.fc18, php-channel-sabredav-1.3-3.fc18, php-sabredav-Sabre_CalDAV-1.6.4-3.fc18 has been pushed to the Fedora 18 testing repository.

Comment 15 Fedora Update System 2012-11-11 21:10:41 UTC
php-channel-sabredav-1.3-3.el6,php-sabredav-Sabre-1.0.0-6.el6,php-sabredav-Sabre_DAVACL-1.6.0-3.el6,php-sabredav-Sabre_DAV-1.6.5-1.el6,php-sabredav-Sabre_HTTP-1.6.4-3.el6,php-sabredav-Sabre_VObject-1.3.5-2.el6,php-sabredav-Sabre_CardDAV-1.6.5-2.el6,php-sabredav-Sabre_CalDAV-1.6.4-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-channel-sabredav-1.3-3.el6,php-sabredav-Sabre-1.0.0-6.el6,php-sabredav-Sabre_DAVACL-1.6.0-3.el6,php-sabredav-Sabre_DAV-1.6.5-1.el6,php-sabredav-Sabre_HTTP-1.6.4-3.el6,php-sabredav-Sabre_VObject-1.3.5-2.el6,php-sabredav-Sabre_CardDAV-1.6.5-2.el6,php-sabredav-Sabre_CalDAV-1.6.4-3.el6

Comment 16 Fedora Update System 2012-11-21 04:03:27 UTC
php-channel-sabredav-1.3-3.fc17, php-sabredav-Sabre-1.0.0-6.fc17, php-sabredav-Sabre_DAV-1.6.5-1.fc17, php-sabredav-Sabre_HTTP-1.6.4-3.fc17, php-sabredav-Sabre_VObject-1.3.5-2.fc17, php-sabredav-Sabre_DAVACL-1.6.0-3.fc17, php-sabredav-Sabre_CalDAV-1.6.4-3.fc17, php-sabredav-Sabre_CardDAV-1.6.5-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 17 Fedora Update System 2012-11-23 07:16:17 UTC
php-sabredav-Sabre_CardDAV-1.6.5-2.fc18, php-sabredav-Sabre_DAVACL-1.6.0-3.fc18, php-sabredav-Sabre_VObject-1.3.5-2.fc18, php-sabredav-Sabre_HTTP-1.6.4-3.fc18, php-sabredav-Sabre_DAV-1.6.5-1.fc18, php-sabredav-Sabre-1.0.0-6.fc18, php-channel-sabredav-1.3-3.fc18, php-sabredav-Sabre_CalDAV-1.6.4-3.fc18 has been pushed to the Fedora 18 stable repository.

Comment 18 Fedora Update System 2012-11-28 17:38:14 UTC
php-channel-sabredav-1.3-3.el6, php-sabredav-Sabre-1.0.0-6.el6, php-sabredav-Sabre_DAVACL-1.6.0-3.el6, php-sabredav-Sabre_DAV-1.6.5-1.el6, php-sabredav-Sabre_HTTP-1.6.4-3.el6, php-sabredav-Sabre_VObject-1.3.5-2.el6, php-sabredav-Sabre_CardDAV-1.6.5-2.el6, php-sabredav-Sabre_CalDAV-1.6.4-3.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.