Spec URL: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit.spec SRPM URL: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-0.7.4-1.fc18.src.rpm Description: SlimIt is a JavaScript minifier written in Python. It compiles JavaScript into more compact code so that it downloads and runs faster. SlimIt also provides a library that includes a JavaScript parser, lexer, pretty printer and a tree visitor. Fedora Account System Username: sgallagh
Is this intended to go into EPEL5? If yes, you have to add a %clean section and the %defattr line in %files. If not, please remove the BuildRoot definition. Moreover, you should run the tests in the slimit/tests folder if possible. Place the appropriate commands in a %check section after %install.
Thanks, I fixed up the spec file to include a %clean section, the %defattr as well as the python sitelib/sitearch header. I added a %check section to run the two tests in the tests/ directory that have a test_suite() defined. This adds a BuildRequires for python-ply and python-odict, the latter of which is under review in BZ #862853 so I cannot do a Koji build until that one is approved. Spec: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-2.spec SRPM: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-0.7.4-2.fc18.src.rpm
(In reply to comment #2) > I added a %check section to run the two tests in the tests/ directory that > have a test_suite() defined. This adds a BuildRequires for python-ply and > python-odict, the latter of which is under review in BZ #862853 so I cannot > do a Koji build until that one is approved. OK, then I'll wait until the depending package is available from the Koji buildroot.
You can build it locally if you install the scratch build of python-odict from BZ #862853
Updated spec replaces 'slimit' with %{pkgname} Spec: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-3.spec SRPM: http://sgallagh.fedorapeople.org/packagereview/python-slimit/python-slimit-0.7.4-3.fc18.src.rpm
Please don't attach the release tag to the spec file name. It's unnecessary because we have the release tag in the file itself anyway. No matter for the time being, I will wait in any case until python-odict is up, because I've currently no Mock installation available.
The spec file in the SRPM itself doesn't have the release tag as part of the name. I just named it that way so you could do a diff of the -2 and -3 versions easily if you wanted to see what I changed. The package would use the correct spec naming when submitted.
python-odict has now been approved and built in rawhide. You can do a koji scratch-build against it in about twenty minutes in the rawhide branch.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4561072 $ rpmlint -i -v * python-slimit.src: I: checking python-slimit.src: W: spelling-error Summary(en_US) minifier -> magnifier The value of this tag appears to be misspelled. Please double-check. python-slimit.src: W: spelling-error %description -l en_US minifier -> magnifier The value of this tag appears to be misspelled. Please double-check. python-slimit.src: I: checking-url http://slimit.org/ (timeout 10 seconds) python-slimit.src: I: checking-url http://pypi.python.org/packages/source/s/slimit/slimit-0.7.4.zip (timeout 10 seconds) python-slimit.noarch: I: checking python-slimit.noarch: W: spelling-error Summary(en_US) minifier -> magnifier The value of this tag appears to be misspelled. Please double-check. python-slimit.noarch: W: spelling-error %description -l en_US minifier -> magnifier The value of this tag appears to be misspelled. Please double-check. python-slimit.noarch: I: checking-url http://slimit.org/ (timeout 10 seconds) python-slimit.noarch: W: no-manual-page-for-binary slimit Each executable in standard binary directories should have a man page. python-slimit.spec: I: checking-url http://pypi.python.org/packages/source/s/slimit/slimit-0.7.4.zip (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 5 warnings. No recognizable issues so far. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. MIT [.] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * 3916ff8b58545ee601d6fdc083dfd467f3709ea0f8e77ced35e1655e767496d7 slimit-0.7.4.zip 3916ff8b58545ee601d6fdc083dfd467f3709ea0f8e77ced35e1655e767496d7 slimit-0.7.4.zip.orig [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [.] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ---------------- PACKAGE APPROVED ----------------
New Package SCM Request ======================= Package Name: python-slimit Short Description: JavaScript minifier written in Python Owners: sgallagh Branches: f18 f17 f16 el6 el5 InitialCC:
Git done (by process-git-requests).
Just a note that defattr hasn't been needed since RHEL4, and is required by nothing at all in current Fedora or EPEL.
Packages for f17, f18 and Rawhide have been built successfully, but I can't find any updates in Bodhi. What's the matter?
python-slimit-0.7.4-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-slimit-0.7.4-3.fc18
python-slimit-0.7.4-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-slimit-0.7.4-3.fc17
python-slimit-0.7.4-3.fc18 has been pushed to the Fedora 18 testing repository.
python-slimit-0.7.4-3.fc17 has been pushed to the Fedora 17 stable repository.