Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 863277

Summary: Ovirt SDK: Can't add correlation id to restore active and deactive HotPlugNic
Product: Red Hat Enterprise Virtualization Manager Reporter: Avi Tal <atal>
Component: ovirt-engine-restapiAssignee: Ori Liel <oliel>
Status: CLOSED CURRENTRELEASE QA Contact: Yaniv Kaul <ykaul>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: amureini, dyasny, ecohen, iheim, jkt, masayag, mavital, mpastern, Rhev-m-bugs, sgrinber, srevivo, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: si21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 20:00:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine logs none

Description Avi Tal 2012-10-04 22:56:09 UTC 
Got the following ERRORS when try to active/deactive HotPlugNic

Active HotPlugNic ERROR:
TypeError: activate() got an unexpected keyword argument 'correlation_id'

Deactive HotPlugNic ERROR:
TypeError: deactivate() got an unexpected keyword argument 'correlation_id'
Comment 2 Avi Tal 2012-10-05 05:50:44 UTC 
Created attachment 621941 [details]
engine logs
Comment 7 Ori Liel 2012-10-09 12:54:48 UTC 
I successfully supply a correlation-ID to activate/deactivate VM nic using REST-API. Activation/deactivation succeeds, and the correlation-ID is displayed in the server log as expected. 

So this does not look like an API issue to me
Comment 8 Ori Liel 2012-10-15 09:54:40 UTC 
More in-depth check shows that API does not report the meta-data properly, so while the API itself works, metadata doesn't reach the SDK, cause SDK not to work. 

Posted patch upstream: 
  http://gerrit.ovirt.org/#/c/8548/

QA: please notice that the same problem happens for activate/deactivate VM disks; this patch fixes that as well.
Comment 9 Ori Liel 2012-10-15 13:55:58 UTC 
patch posted upstream:
   http://gerrit.ovirt.org/#/c/8548/

patch merged upstream: 
   commit 4f859b1bf173751c315582fdae68c321f2b3d278

patch posted downstream: 
   https://gerrit.eng.lab.tlv.redhat.com/#/c/2635/

patch merged downstream: 
   commit 0efdfeb6d91cc16c6b6b077ed4888554a194d55
Comment 10 Avi Tal 2012-10-21 16:41:17 UTC 
Verify of si21.1 - PASS