Bug 863571 - Review Request: flare - A single player, 2D-isometric, action Role-Playing Game
Summary: Review Request: flare - A single player, 2D-isometric, action Role-Playing Game
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Volker Fröhlich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-05 20:28 UTC by Erik Schilling
Modified: 2012-11-28 11:58 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-11-23 07:47:25 UTC
Type: ---
Embargoed:
volker27: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Erik Schilling 2012-10-05 20:28:13 UTC
Spec URL: http://ablu.fedorapeople.org/flare.spec
SRPM URL: http://ablu.fedorapeople.org/flare-0.17.1-1.fc17.src.rpm
koji build: koji.fedoraproject.org/koji/taskinfo?taskID=4564166
Fedora Account System Username: ablu
Description: 
Flare (Free Libre Action Roleplaying Engine) is a simple game engine built to
handle a very specific kind of game: single-player 2D action RPGs. Flare is not   a reimplementation of an existing game or engine. It is a tribute to and
exploration of the action RPG genre.

Rather than building a very abstract, robust game engine, the goal of this
project is to build several real games and harvest an engine from the common,
reusable code. The first game, in progress, is a fantasy dungeon crawl.

Flare uses simple file formats (INI style config files) for most of the game
data, allowing anyone to easily modify game contents. Open formats are
preferred (png, ogg). The game code is C++.
====

rpmlint:

flare.i686: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation
flare.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare.i686: W: spelling-error %description -l en_US png -> pg, ping, pang
flare.i686: W: spelling-error %description -l en_US ogg -> egg, org, boggy
flare.src: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation
flare.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare.src: W: spelling-error %description -l en_US png -> pg, ping, pang
flare.src: W: spelling-error %description -l en_US ogg -> egg, org, boggy
flare-data.i686: E: explicit-lib-dependency liberation-sans-fonts
flare-data.i686: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation
flare-data.i686: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare-data.i686: W: spelling-error %description -l en_US png -> pg, ping, pang
flare-data.i686: W: spelling-error %description -l en_US ogg -> egg, org, boggy
flare-data.i686: W: no-documentation
flare-data.i686: W: dangling-symlink /usr/share/games/flare/mods/default/fonts/LiberationSans-Regular.ttf /usr/share/fonts/liberation/LiberationSans-Regular.ttf
flare-data.i686: W: dangling-symlink /usr/share/games/flare/mods/fantasycore/fonts/LiberationSans-Regular.ttf /usr/share/fonts/liberation/LiberationSans-Regular.ttf
flare-data.i686: W: dangling-symlink /usr/share/games/flare/mods/fantasycore/fonts/LiberationSans-Bold.ttf /usr/share/fonts/liberation/LiberationSans-Bold.ttf
flare-data.i686: W: dangling-symlink /usr/share/games/flare/mods/fantasycore/fonts/LiberationSans-Italic.ttf /usr/share/fonts/liberation/LiberationSans-Italic.ttf
4 packages and 0 specfiles checked; 1 errors, 17 warnings.


I think the error about explicit libary is only because of the name starting with "lib". The dangling symlinks *should* be fine too i think.

Best regards and Have a nice weekend
Erik

Comment 1 Erik Schilling 2012-10-06 08:38:40 UTC
I added BuildArch: noarch for the data package.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4566158
srpm: http://ablu.fedorapeople.org/flare-0.17.1-2.fc17.src.rpm

Comment 2 Erik Schilling 2012-10-06 18:59:46 UTC
Dropped the use of /usr/share/games:
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4567075
srpm: http://ablu.fedorapeople.org/flare-0.17.1-3.fc17.src.rpm

Comment 3 Volker Fröhlich 2012-10-24 16:04:45 UTC
License is GPLv3+, not GPLv3.

You have to run scriplets for files in %{_datadir}/icons/hicolor: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

I suppose the main concept of having a separate data sub-package is making it noarch. The base package requires the data sub-package. Does the data sub-package make sense on its own? It doesn't require the base package.

You can remove the trailing slash on URL.

Comment 4 Erik Schilling 2012-10-24 16:28:41 UTC
Hello,

Thanks a lot for the comments.

Yes it does not make too much sense of having flare and flare-data seperate...
Shall i drop the subpackage?

Regards
Erik

Comment 5 Kevin Kofler 2012-10-24 20:03:02 UTC
The -data subpackage is OK to have because it is noarch whereas the main package is arch-specific, but Requires should be there in both directions (as is already the case for several games with split -data (sub)package).

Now is it worth it? That depends on the size. The larger the data, the more useful it is to have it split from the arch-specific stuff.

Comment 6 Kevin Kofler 2012-10-24 20:06:54 UTC
Apparently, in this case, the data is over 100 MiB whereas the code is less than 1 MiB, so I think having a separate -data noarch subpackage is useful here, please don't drop it.

Comment 7 Erik Schilling 2012-10-25 04:46:00 UTC
Ok. Thanks. I will fix that + the other issues as soon as possible and will upload new srpm/specfile.

Thanks for help
Erik

Comment 8 Erik Schilling 2012-10-25 18:05:05 UTC
Updated SRPM: http://ablu.fedorapeople.org/flare-0.17.1-4.fc17.src.rpm
Sorry i did no koji build because uploading this takes ages with my internet.
But i did local mock build.

Thanks for the suggestions!
Erik

Comment 9 Volker Fröhlich 2012-10-29 18:51:01 UTC
Can you explain why the license for the data sub-package is "CC-BY-SA and CC-BY and CC0 and Public Domain"? README claims it is "CC-BY-SA 3.0. Later versions are permitted.".

There's one more bundled font:

./mods/fantasycore/fonts/unifont-5.1.ttf

Please ask upstream to correct the permissions in the tarball.

Cosmetics:

You can remove all slashes between %{buildroot} and %{_datadir} macros.

I'd personally change the description for the data package, because 3 paragraphs describe things that are not specific to the sub-package. It's up to you, of course.

Comment 10 Erik Schilling 2012-10-30 05:48:07 UTC
About license: https://github.com/clintbellanger/flare-game/wiki/Credits
I simply listed all licenses

About the font: I was not able to find this version of the font in fedora. So i left it there. Is this wrong?

I already asked to fix permissions: https://github.com/clintbellanger/flare-game/issues/54

For cosmetics: I actually place them for cosmetics :) I can read it better with it. Is it preferred without?

Thanks a lot for comment and have a nice day
Erik

Comment 11 Volker Fröhlich 2012-10-30 12:55:35 UTC
This seems to be upstream: http://unifoundry.com/unifont.html

Please ask the font SIG whether there is a proper substitute available: https://fedoraproject.org/wiki/Category:Fonts_SIG

On the license question, please see my e-mail to the legal list, I CCed you on.

Comment 12 Erik Schilling 2012-10-30 15:49:52 UTC
The answer we got from the mailling list is correct i think. CC BY SA would be the most restrictive license. I *could* list only this license since all other mentioned licenses are less restrictive. I am not an expert in this area but i am rather sure that the way i did it is correct. However i am fine with only listing CC BY SA if you prefer that.

About fonts:
I will ask them.

Any comment about this?
> For cosmetics: I actually place them for cosmetics :) I can read it better with it. Is it preferred without?

Regards
Erik

Comment 13 Kevin Kofler 2012-10-30 15:58:12 UTC
We have one or two versions of the Unifont as actual bitmap fonts in Fedora, in particular, we definitely have WQY Bitmap Song, I'm not sure whether we also have it packaged as Unifont.

If you really need it as TTF (as a fake "vector" font which just defines the pixels as scalable rectangles), you will need to get this packaged into Fedora as a separate package (the license is suitable), or you can try another font, which will also look better if it's a true scalable font (but there isn't really any font with the same Unicode coverage as the Unifont; the proper solution there is to use fontconfig, which will pick a suitable font depending on what characters you are trying to render, but that'd be something for upstream, so you won't be able to render all of Unicode with just one scalable font).

Comment 14 Volker Fröhlich 2012-10-30 21:45:53 UTC
I found parts of SDL_gfx bundled. Please link the system library instead:

SDL_gfxBlitFunc.h
SDL_gfxBlitFunc.c

Comment 15 Volker Fröhlich 2012-10-30 21:59:17 UTC
Please use the name macro on Source1.

As you already said, the license for the data sub-package was found correct: http://lists.fedoraproject.org/pipermail/legal/2012-October/001992.html

Comment 16 Erik Schilling 2012-10-31 05:49:41 UTC
Hello, Thanks for the comments

I will talk with upstream about using a different font

Will find a way to link flare against bundeled SDL_gfx. Thanks for pointing out this duplication. Did not noticed it.

Will fix the makro.

Still waiting for reply to this one:
>Any comment about this?
>> For cosmetics: I actually place them for cosmetics :) I can read it better with it. Is it preferred without?

Regards
Erik

Comment 17 Volker Fröhlich 2012-10-31 10:07:29 UTC
Ad cosmetics:

You're adding an extra slash in front of "/usr" . It works and I personally don't mind.

rm -f %{buildroot}/%{_datadir}/%{name}/mods/default/fonts/LiberationSans-Regular.ttf

=>

rm -f /home/makerpm/rpmbuild/BUILDROOT/flare-0.17.1-4.fc16.x86_64//usr/share/flare/mods/default/fonts/LiberationSans-Regular.ttf


rm -f %{buildroot}%{_datadir}/%{name}/mods/default/fonts/LiberationSans-Regular.ttf

=>

rm -f /home/makerpm/rpmbuild/BUILDROOT/flare-0.17.1-4.fc16.x86_64/usr/share/flare/mods/default/fonts/LiberationSans-Regular.ttf

Comment 18 Erik Schilling 2012-11-02 23:54:18 UTC
Spec URL: http://ablu.fedorapeople.org/flare.spec
new SRPM URL: http://ablu.fedorapeople.org/flare-0.17.1-5.fc17.src.rpm

I again did no koji build because it takes ages to upload here. But i did local build with mock.

Changelog:
- Dropped / between path makros
- Made use of %%{name} makro in Source1
- Made sure that the binary links against system SDL_gfx parts
- Replaced unifont use with dejavu since the font was not packaged

Have a nice weekend
Erik

Comment 19 Volker Fröhlich 2012-11-11 16:20:07 UTC
The %find_lang macro must still be used. Careful about the files section then! As soon as that's implemented, the package is good to go.

reimplementation --> re-implementation

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
     such a file.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.

Also builds on PPC and PPC64

[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v3 or later)", "Unknown or generated", "zlib/libpng". 3 files have
     unknown license. Detailed output of licensecheck in
     /media/speicher1/makerpm/rpmbuild/SPECS/863571-flare/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.

Sub-package require each other mutually. The idea is to have a noarch sub-package
for the game data.

[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (flare_linux_v017_1.tar.gz)

No idea why fedora-review thinks that's wrong. I replaced the ! with a x.

[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Test run failed

Rpmlint
-------
Checking: flare-debuginfo-0.17.1-5.fc16.x86_64.rpm
          flare-data-0.17.1-5.fc16.noarch.rpm
          flare-0.17.1-5.fc16.src.rpm
          flare-0.17.1-5.fc16.x86_64.rpm
flare-data.noarch: E: explicit-lib-dependency liberation-sans-fonts
flare-data.noarch: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, impleme
ntation
flare-data.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare-data.noarch: W: spelling-error %description -l en_US png -> pg, ping, pang
flare-data.noarch: W: spelling-error %description -l en_US ogg -> egg, org, boggy
flare-data.noarch: W: no-documentation
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/default/fonts/LiberationSans-Regular.ttf /usr/share/fonts/liber
ation/LiberationSans-Regular.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Bold.ttf /usr/share/fonts/libe
ration/LiberationSans-Bold.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Italic.ttf /usr/share/fonts/li
beration/LiberationSans-Italic.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Regular.ttf /usr/share/fonts/l
iberation/LiberationSans-Regular.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu/DejaVu
Sans.ttf
flare.src: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementation
flare.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare.src: W: spelling-error %description -l en_US png -> pg, ping, pang
flare.src: W: spelling-error %description -l en_US ogg -> egg, org, boggy
flare.x86_64: W: spelling-error %description -l en_US reimplementation -> re implementation, re-implementation, implementati
on
flare.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
flare.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang
flare.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, boggy
4 packages and 0 specfiles checked; 1 errors, 18 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint flare-debuginfo flare-data flare
flare-debuginfo.x86_64: I: enchant-dictionary-not-found en_US
flare-data.noarch: E: explicit-lib-dependency liberation-sans-fonts
flare-data.noarch: W: no-documentation
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/default/fonts/LiberationSans-Regular.ttf /usr/share/fonts/liber
ation/LiberationSans-Regular.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Bold.ttf /usr/share/fonts/liberation/LiberationSans-Bold.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Italic.ttf /usr/share/fonts/liberation/LiberationSans-Italic.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/LiberationSans-Regular.ttf /usr/share/fonts/liberation/LiberationSans-Regular.ttf
flare-data.noarch: W: dangling-symlink /usr/share/flare/mods/fantasycore/fonts/DejaVuSans.ttf /usr/share/fonts/dejavu/DejaVuSans.ttf
3 packages and 0 specfiles checked; 1 errors, 6 warnings.
# echo 'rpmlint-done:'


Requires
--------
flare-debuginfo-0.17.1-5.fc16.x86_64.rpm (rpmlib, GLIBC filtered):
    

flare-data-0.17.1-5.fc16.noarch.rpm (rpmlib, GLIBC filtered):
    
    dejavu-sans-fonts  
    flare = 0.17.1-5.fc16
    liberation-sans-fonts  

flare-0.17.1-5.fc16.x86_64.rpm (rpmlib, GLIBC filtered):
    
    /bin/sh  
    flare-data = 0.17.1-5.fc16
    libSDL-1.2.so.0()(64bit)  
    libSDL_gfx.so.13()(64bit)  
    libSDL_image-1.2.so.0()(64bit)  
    libSDL_mixer-1.2.so.0()(64bit)  
    libSDL_ttf-2.0.so.0()(64bit)  
    libc.so.6()(64bit)  
    libgcc_s.so.1()(64bit)  
    libgcc_s.so.1(GCC_4.0.0)(64bit)  
    libm.so.6()(64bit)  
    libpthread.so.0()(64bit)  
    libstdc++.so.6()(64bit)  
    libstdc++.so.6(CXXABI_1.3)(64bit)  
    rtld(GNU_HASH)  



Provides
--------
flare-debuginfo-0.17.1-5.fc16.x86_64.rpm:
    
    flare-debuginfo = 0.17.1-5.fc16
    flare-debuginfo(x86-64) = 0.17.1-5.fc16

flare-data-0.17.1-5.fc16.noarch.rpm:
    
    flare-data = 0.17.1-5.fc16

flare-0.17.1-5.fc16.x86_64.rpm:
    
    flare = 0.17.1-5.fc16
    flare(x86-64) = 0.17.1-5.fc16



MD5-sum check
-------------
https://github.com/downloads/clintbellanger/flare-game/flare_linux_v017_1.tar.gz :
  CHECKSUM(SHA256) this package     : 42ef8e2778a397e71d1890a7595ae98ba0fa010af546c9f5a4b3a5cabb2b663b
  CHECKSUM(SHA256) upstream package : 42ef8e2778a397e71d1890a7595ae98ba0fa010af546c9f5a4b3a5cabb2b663b


Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-16-x86_64
Command line :/usr/bin/fedora-review -b 863571

Comment 20 Erik Schilling 2012-11-11 16:51:37 UTC
> The %find_lang macro must still be used. Careful about the files section then! As soon as that's implemented, the package is good to go.

hm. Don't i only need this for compiled translations? This project does not use real gettext. It uses an own implementation that only parses the .po files directly. I wonder how %find_lang works with this?

Regards
Erik

Comment 21 Kevin Kofler 2012-11-11 18:00:58 UTC
If %find_lang doesn't find your files, you need to use the %lang tag directly (a separate one per language).

Comment 22 Erik Schilling 2012-11-11 18:30:03 UTC
Is there a elegant way to prevent getting around adding all files except this ones in the %files section? (using %{_datadir}/%{name} will of course mark all as twice listed). Shall i do a seperate subpackage here?
%lang(gl) %{_datadir}/%{name}/mods/alpha_demo/languages/data.gl.po
%lang(fi) %{_datadir}/%{name}/mods/alpha_demo/languages/data.fi.po
%lang(de) %{_datadir}/%{name}/mods/alpha_demo/languages/data.de.po
%lang(ru) %{_datadir}/%{name}/mods/alpha_demo/languages/data.ru.po
%lang(ja) %{_datadir}/%{name}/mods/alpha_demo/languages/data.ja.po
%lang(nl) %{_datadir}/%{name}/mods/alpha_demo/languages/data.nl.po
%lang(fr) %{_datadir}/%{name}/mods/alpha_demo/languages/data.fr.po
%lang(uk) %{_datadir}/%{name}/mods/alpha_demo/languages/data.uk.po
%lang(it) %{_datadir}/%{name}/mods/alpha_demo/languages/data.it.po
%lang(gl) %{_datadir}/%{name}/mods/fantasycore/languages/data.gl.po
%lang(fi) %{_datadir}/%{name}/mods/fantasycore/languages/data.fi.po
%lang(de) %{_datadir}/%{name}/mods/fantasycore/languages/data.de.po
%lang(ru) %{_datadir}/%{name}/mods/fantasycore/languages/data.ru.po
%lang(ja) %{_datadir}/%{name}/mods/fantasycore/languages/data.ja.po
%lang(nl) %{_datadir}/%{name}/mods/fantasycore/languages/data.nl.po
%lang(fr) %{_datadir}/%{name}/mods/fantasycore/languages/data.fr.po
%lang(uk) %{_datadir}/%{name}/mods/fantasycore/languages/data.uk.po
%lang(it) %{_datadir}/%{name}/mods/fantasycore/languages/data.it.po
%lang(sk) %{_datadir}/%{name}/mods/default/languages/engine.sk.po
%lang(be) %{_datadir}/%{name}/mods/default/languages/engine.be.po
%lang(sv) %{_datadir}/%{name}/mods/default/languages/engine.sv.po
%lang(it) %{_datadir}/%{name}/mods/default/languages/engine.it.po
%lang(el) %{_datadir}/%{name}/mods/default/languages/engine.el.po
%lang(gl) %{_datadir}/%{name}/mods/default/languages/engine.gl.po
%lang(es) %{_datadir}/%{name}/mods/default/languages/engine.es.po
%lang(ja) %{_datadir}/%{name}/mods/default/languages/engine.ja.po
%lang(ru) %{_datadir}/%{name}/mods/default/languages/engine.ru.po
%lang(nl) %{_datadir}/%{name}/mods/default/languages/engine.nl.po
%lang(fi) %{_datadir}/%{name}/mods/default/languages/engine.fi.po
%lang(fr) %{_datadir}/%{name}/mods/default/languages/engine.fr.po
%lang(de) %{_datadir}/%{name}/mods/default/languages/engine.de.po
%lang(uk) %{_datadir}/%{name}/mods/default/languages/engine.uk.po

Comment 23 Erik Schilling 2012-11-11 19:23:09 UTC
Ok i talked with my sponsor about it. I will just add list of files in same package.

Comment 24 Erik Schilling 2012-11-11 21:04:55 UTC
new SRPM: http://ablu.fedorapeople.org/flare-0.17.1-6.fc17.src.rpm
updated spec: http://ablu.fedorapeople.org/flare.spec
no koji build again because of bad upload


Changelog:
- Spell-fix: reimplementation --> re-implementation
- Mark translation files with %%lang

Thanks a lot for all comments,

Erik

Comment 25 Kevin Kofler 2012-11-11 21:42:22 UTC
You're missing the directory ownership:
%dir %{_datadir}/%{name}
%dir %{_datadir}/%{name}/mods
%dir %{_datadir}/%{name}/mods/*
%dir %{_datadir}/%{name}/mods/*/languages

Comment 26 Erik Schilling 2012-11-12 21:32:11 UTC
This * somehow did not worked as intented. But i now made sure that all directories are owned.

New SRPM: http://ablu.fedorapeople.org/flare-0.17.1-7.fc17.src.rpm
Updated Spec: http://ablu.fedorapeople.org/flare.spec
no koji build again because it would take ages to upload for me again.

Changelog:
- Fixed directory ownership

Thanks a lot for your comments,
Erik

Comment 27 Kevin Kofler 2012-11-13 14:52:06 UTC
Are there also files (not just directories) in mods/? Then you can try:
%dir %{_datadir}/%{name}/mods/*/

But of course, listing all the directories explicitly as you did will also work.

Comment 28 Erik Schilling 2012-11-13 17:16:13 UTC
Hm. I think i maybe forgot the trailing /. I will try it locally. Will wait with uploading until there are other more "urgent" problems though :)

Thanks for pointing out.
Erik

Comment 29 Volker Fröhlich 2012-11-14 18:19:54 UTC
If you didn't change anything else, just upload the spec file. Then we can finish this.

Comment 30 Volker Fröhlich 2012-11-14 18:20:36 UTC
I just noticed you did.

Comment 31 Volker Fröhlich 2012-11-16 23:15:12 UTC
Release 7 is fine, package is approved!

Comment 32 Erik Schilling 2012-11-16 23:40:33 UTC
Hi :)

First thank you a lot for the review!

Now I made the directory listing a bit shorter/more flexible after Kevins comment. I am not that familiar with this packaging process yet. So I am asking: Can i just use my fixed (i only changed the few lines + pushed release number up by once) version? Or do i have to upload it here again?

Have a nice weekend,
Erik

Comment 33 Kevin Kofler 2012-11-16 23:53:37 UTC
AFAIK, the way most people handle this is that they import the version that was reviewed, then commit and push the fix and then do their first build.

Comment 34 Erik Schilling 2012-11-17 07:15:22 UTC
Ok. Will do that then. Thanks a lot

New Package SCM Request
=======================
Package Name: flare
Short Description: A single player, 2D-isometric, action Role-Playing Game
Owners: ablu
Branches: f16 f17 f18
InitialCC:

Comment 35 Gwyn Ciesla 2012-11-18 17:09:51 UTC
Git done (by process-git-requests).

Comment 36 Fedora Update System 2012-11-18 18:12:59 UTC
flare-0.17.1-8.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/flare-0.17.1-8.fc17

Comment 37 Fedora Update System 2012-11-18 18:14:11 UTC
flare-0.17.1-8.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/flare-0.17.1-8.fc18

Comment 38 Fedora Update System 2012-11-18 18:14:21 UTC
flare-0.17.1-8.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/flare-0.17.1-8.fc16

Comment 39 Fedora Update System 2012-11-19 02:24:57 UTC
flare-0.17.1-8.fc16 has been pushed to the Fedora 16 testing repository.

Comment 40 Fedora Update System 2012-11-23 07:47:26 UTC
flare-0.17.1-8.fc18 has been pushed to the Fedora 18 stable repository.

Comment 41 Fedora Update System 2012-11-28 11:35:50 UTC
flare-0.17.1-8.fc17 has been pushed to the Fedora 17 stable repository.

Comment 42 Fedora Update System 2012-11-28 11:58:59 UTC
flare-0.17.1-8.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.