Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 864936 - Product labels are not currently required to be unique.
Summary: Product labels are not currently required to be unique.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: WebUI
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: Unspecified
Assignee: Brad Buckingham
QA Contact: Corey Welton
URL:
Whiteboard:
Depends On:
Blocks: 874744
TreeView+ depends on / blocked
 
Reported: 2012-10-10 12:31 UTC by Brad Buckingham
Modified: 2019-09-25 20:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, a product label can be reused by another product in the same provider or organization. A unique label is now required for all products within the same organization. Using a duplicate label for different products in the same organization will generate an error.
Clone Of:
: 874744 (view as bug list)
Environment:
Last Closed: 2012-12-04 19:57:07 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:1543 0 normal SHIPPED_LIVE Important: CloudForms System Engine 1.1 update 2012-12-05 00:39:57 UTC

Description Brad Buckingham 2012-10-10 12:31:47 UTC 
Description of problem:

When creating a product for a provider, the user may set the product label to a value that is already used by another product in that provider or organization.

Should product labels be unique?  Note: The product label is included as part of the client's redhat.repo (e.g. [orglabel_productlabel_repolabel]).

If we need the labels to be unique, we'll need to ensure that the algorithm used for auto-setting them takes this in to account (e.g. label+dbid).  This will be necessary for both creation of custom products as well as those created as part of a manifest import.

Version-Release number of selected component (if applicable):
github master

How reproducible:
always

Steps to Reproduce:

1. Attempt to create multiple products with the same label.
  
Actual results:

katello> product create --org ACME_Corporation --provider prov1 --name product1 --label product1
Successfully created product [ product1 ]

katello> product create --org ACME_Corporation --provider prov1 --name product1 --label product1
Successfully created product [ product1 ]


Expected results:

Second product create should fail.

Additional info:
Comment 3 Brad Buckingham 2012-11-02 21:42:20 UTC 
katello github pull request : https://github.com/Katello/katello/pull/991

The above pull request ensures that product labels are unique within the organization where the product is created.  The following is the high-level behavior:

- UI:
  - If the user submits a request to create a product and and the request does not include a label, a unique label will be created and assigned. The user will be informed with a 'message' notice.
  - If the user submits a request to create a product and the request includes a label that has already been assigned to a product in that organization, a unique label will be created and assigned. The user will be informed with a 'message' notice.
  - If the user submits a request to create a product and the request includes a unique label, that label is assigned to the product.

- API/CLI:
  - If the user submits a request to create a product and the request does not include a label, a unique label will be created and assigned.
  - If the user submits a request to create a product and the request includes a label that has already been assigned to a product in that organization, a validation error is returned.
  - If the user submits a request to create a product and the request includes a unique label, that label is assigned to the product.
Comment 6 Corey Welton 2012-11-06 16:53:27 UTC 
QE Verified:

cfse> product create --org Test_Org_1352219207 --provider "Google Products_provider" --name product1 --label product1
Successfully created product [ product1 ]
cfse> product create --org Test_Org_1352219207 --provider "Google Products_provider" --name product1 --label product1
Validation failed: Label has already been taken


CloudForms System Engine Version: 1.1.12-20.el6cf
Comment 8 errata-xmlrpc 2012-12-04 19:57:07 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-1543.html
Comment 9 Mike McCune 2013-08-16 18:18:36 UTC 
getting rid of 6.0.0 version since that doesn't exist
Comment 10 Tomas Lestach 2014-06-05 10:11:12 UTC 
A very similar issue discovered in 6.0.3: Bug 1105061
Note You need to log in before you can comment on or make changes to this bug.