Bug 864961
| Summary: | Default VM display type overrides current VM display type in REST API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Ido Begun <ibegun> | ||||
| Component: | ovirt-engine-restapi | Assignee: | Ravi Nori <rnori> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ido Begun <ibegun> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.1.0 | CC: | dyasny, ecohen, hateya, iheim, michal.skrivanek, mpastern, oramraz, Rhev-m-bugs, sgrinber, ykaul | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | 3.2.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | virt | ||||||
| Fixed In Version: | sf1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-06-11 09:19:46 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 915537 | ||||||
| Attachments: |
|
||||||
|
Description
Ido Begun
2012-10-10 13:40:26 UTC
logs? Created attachment 624920 [details]
Logs
Relevant data appears at the end of logs.
Why is this a bug? VM properties did not change, the display type is still VNC. Run Once only overrides the current startup configuration which is not listed since it's transient. When you get a VM object you are supposed to get the configuration, so you may properly be able to edit it. I think the solution may be and RFE (if not exists) to extend the API to retrieve run once parameters, if the VMs was started using run once. Oded. per comment #3, please find out if there is another way to get this info, or convert this to an RFE to retrieve the run-once properties of a running VM. (In reply to comment #4) > Oded. per comment #3, please find out if there is another way to get this > info, or convert this to an RFE to retrieve the run-once properties of a > running VM. the meaning of the run-once command is: do-not-store, if you want to persist vm config, update vm. also such RFE won't be feasible. as it will break run-once concept. When I run the VM from UI using run once and choosing X display type , I see it with X display type under VM's tab , even when it defined with Y as default display type. Shouldn't the behavior be the same in API / CLI ? (In reply to comment #6) > When I run the VM from UI using run once and choosing X display type , I see > it with X display type under VM's tab , even when it defined with Y as > default display type. > Shouldn't the behavior be the same in API / CLI ? if vm running yes, if it's down, no, what was the state of the vm? (In reply to comment #7) > (In reply to comment #6) > > When I run the VM from UI using run once and choosing X display type , I see > > it with X display type under VM's tab , even when it defined with Y as > > default display type. > > Shouldn't the behavior be the same in API / CLI ? > > if vm running yes, if it's down, no, what was the state of the vm? When defining the VM with default display type=VNC, then running the VM using run-once with display type=spice, we get different values in UI and API (while VM is running): In UI - display type = spice In API - display type = VNC > When defining the VM with default display type=VNC, then running the VM
> using run-once with display type=spice, we get different values in UI and
> API (while VM is running):
> In UI - display type = spice
> In API - display type = VNC
then I suppose GUI should be changed to rather show the permanent value, just so you won't overwrite it accidentally while editing VM when it's run via Run Once.
sounds like a minor bug
(In reply to comment #9) > > When defining the VM with default display type=VNC, then running the VM > > using run-once with display type=spice, we get different values in UI and > > API (while VM is running): > > In UI - display type = spice > > In API - display type = VNC > then I suppose GUI should be changed to rather show the permanent value, > just so you won't overwrite it accidentally while editing VM when it's run > via Run Once. > > sounds like a minor bug It is not minor issue since those details are important and cannot retrieved easily, they also don't appear in the events logs. > > sounds like a minor bug > > It is not minor issue since those details are important and cannot retrieved > easily, they also don't appear in the events logs. don't understand. run time details are in the Vm status tab (the bottom one). These values should not be presented anywhere else, since it's only "run once" - comment #5. Or do you have anything else in mind? Link : http://gerrit.ovirt.org/#/c/8822/ Commit Hash: bab798835a194b4890f406bc30e72ebcf4ee70f3 OK - SF3 Display type now shows the correct value when using 'run once', and default display type is shown after VM powers off, as expected. 3.2 has been released 3.2 has been released |