Red Hat Bugzilla – Bug 865858
Potentially unnecessary file opens/closes performed around xattr read/writes
Last modified: 2016-02-17 19:12:48 EST
Description of problem:
The Gluster/Swift plugin code provides wrappers for get/set/removexattr
system calls which perform file open/close systems calls. The open/close
sequence appears to be unnecessary.
Version-Release number of selected component (if applicable):
Files are first opened, xattr key read/written/removed, then closed for
every metadata key stored (could have multiple keys stored, see
No open or close system call is made around xattr operations.
I created a permanent pastebin link with the output of an strace from a GET on an object.
Lines 222 - 240 are annotated to show where a read_metadata() calls starts and ends, and what do_getxattr() does for a file. Notice that 13 system calls are made. The two calls to fgetxattr in a row are the result of the pyxattr modules' behavior to first find out the size of the xattr value so that it can allocate memory for it and then fetch the full contents of it.
We should be able to remove the extra stat calls as well.
Probably would be helpful to actually include the link to the pastebin ...
Here are the results of the same operation but with a patch applied to remove the extra system calls (from 13 down to 3).
Created attachment 626189 [details]
Initial patch to remove the use of deprecated pyxattr methods.
Created attachment 626190 [details]
Actual fix to remove extra system calls.
CHANGE: http://review.gluster.org/4077 (Refactor to use pyxattr's get/set/remove methods) merged in master by Anand Avati (email@example.com)
CHANGE: http://review.gluster.org/4078 (Fix BZ 865858: remove unnecessary system calls around xattr ops) merged in master by Anand Avati (firstname.lastname@example.org)