Red Hat Bugzilla – Bug 865953
Busted package group results in bizarre and crash-happy dialog
Last modified: 2014-02-05 07:34:05 EST
Description of problem:
Booted smoke8 (18.16) netinst.iso. Picked the 'Cinnamon' environment from the Software Selection spoke. On leaving the spoke, anaconda said something along the lines of 'the cinnamon group does not exist. Would you like to skip this group and continue with installation?' (yes/no). I picked No, and it crashed.
In a hub and spoke design, the question seems like bad UI. It's not at all clear what each choice actually means. I had no idea which option I should pick, or what would happen in either case. I think this dialog needs to be reworked quite aside from the fact that neither choice should cause a crash.
Version-Release number of selected component:
libreport version: 2.0.14
cmdline: /usr/bin/python /sbin/anaconda
:The following was filed automatically by anaconda:
:anaconda 18.16 exception report
:Traceback (most recent call first):
: File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 1046, in _handleMissing
: File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 1073, in _applyYumSelections
: File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 1097, in checkSoftwareSelection
: File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/software.py", line 89, in checkSoftwareSelection
: File "/usr/lib64/python2.7/threading.py", line 504, in run
: self.__target(*self.__args, **self.__kwargs)
: File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run
: threading.Thread.run(self, *args, **kwargs)
Created attachment 626302 [details]
Created attachment 626303 [details]
Created attachment 626304 [details]
Created attachment 626305 [details]
Created attachment 626306 [details]
Created attachment 626307 [details]
Created attachment 626308 [details]
Created attachment 626309 [details]
Created attachment 626310 [details]
Created attachment 626311 [details]
Created attachment 626312 [details]
Created attachment 626313 [details]
Created attachment 626314 [details]
Created attachment 626315 [details]
note the initial error here is not anaconda's, the Cinnamon group in comps really *is* broken (well, I fixed it yesterday, but that change hasn't got mashed into the public mirrors yet, obviously). the problem in anaconda here is in the error handling.
CCing Mo in case she has thoughts on the wording/design of the dialog. I re-ran the test and hit Yes this time, just to see what would happen - that results in no crash, and the hub shows the Cinnamon env selected with no warning triangle. I didn't bother completing the install, but I expect I could then continue install and I'd get just whatever packages would be in the install set, ignoring the non-existent group. That seems like a reasonable outcome for saying Yes, but I still don't really know what No 'should' do. Put you back at the Software Selection spoke?
Stephanie and I reviewed this bug today. We agreed that it would be better if the dialog didn't pop up at all, and any broken package groups were removed from the user's available selections before entering the spoke. We talked to Chris and he said that anaconda doesn't do any sanity-checking on the repos, though, so we won't know if a given package group is broken until leaving the spoke.
It seems like maybe the big issue with the dialog that pops up is that it has a 'yes' 'no' and 'no' makes it crash, and 'yes' doesn't really do anything. So we think the best solution here is to get rid of the dialog completely, and add a warning to the notification area to let the user know there's a problem with the repo and which groups in their selection won't be installed because of the issue.
Basically, the user will go through the software selection spoke, exit to the hub, and:
- A /!\ will appear next to software selection after the user completes it and anaconda figures out one or more package groups are busted.
- The warning will basically say, 'Some selected package groups cannot be installed because of a repo error ($PACKAGE_GROUP_NAMES). We'll install everything else you picked.' <= or something along those lines
Please let me know next time there's a tree with this busted condition, and I will work on fixing this.
It's probably not going to come up very often, as it requires the names of groups in anaconda and in comps to be out of sync, so it's only likely to happen when we introduce new desktops and/or do big comps overhauls...
The reason for this dialog being there in the first place is not the interactive user, but kickstart. For interactive users, I think we can catch busted groups coming from comps elsewhere.
For kickstart users, we have a %packages --ignoreMissing flag that allows them to skip notification; otherwise we stop and tell them they gave a bad package in %packages. But, I've got to wonder if anyone actually cares about this functionality. Would it be better to just log the missing package and move on? Does anyone have any ideas about how to handle this situation?
This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '18'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 18's end of life.
Thank you for reporting this issue and we are sorry that we may not be
able to fix it before Fedora 18 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior to Fedora 18's end of life.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
Thank you for reporting this bug and we are sorry it could not be fixed.