RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 867265 - [storage.py]Using function "cross_check_host_app" to check AppVG overlaps with HostVG failed .
Summary: [storage.py]Using function "cross_check_host_app" to check AppVG overlaps wit...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: ovirt-node
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Fabian Deutsch
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-17 07:32 UTC by haiyang,dong
Modified: 2013-02-28 16:40 UTC (History)
12 users (show)

Fixed In Version: ovirt-node-2.5.0-11.el6
Doc Type: Bug Fix
Doc Text:
Previously, the hypervisor created LVM partitions for HostVG and AppVG using the same hard disk. The cross_check_host_app function, which checks whether there was an overlap between AppVG and HostVG, was called when the partition was initialized, so it did not work. Now, the overlap between AppVG and HostVG or RootVG is checked when the actual partitioning is performed, so cross_check_host_app works as expected.
Clone Of:
Environment:
Last Closed: 2013-02-28 16:40:41 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2013:0556 0 normal SHIPPED_LIVE ovirt-node bug fix and enhancement update 2013-02-28 21:29:06 UTC

Description haiyang,dong 2012-10-17 07:32:46 UTC 
Description of problem: 
Using function "cross_check_host_app" to check whether AppVG overlaps with HostVG or not failed

fixed this issue with follow python code:
    def cross_check_host_app(self):
        for hdrv in self.HOSTVGDRIVE:
            if hdrv in self.APPVGDRIVE:
                # Skip disk partitioning, AppVG overlaps with HostVG
                return False
            else:
                return True

[root@localhost Desktop]# diff storage.py.Old-Version storage.py.New-Version 
147c147
<             if hdrv in self.APPDRIVE:
---
>             if hdrv in self.APPVGDRIVE:


Version-Release number of selected component (if applicable): 
rhev-hypervisor6-6.3-20121015.0.rhev31.el6_3

How reproducible: 
100% 

Steps to Reproduce: 
1.boot to the kernel command line, use the following command to enable appvg, encrypt swap,
storage_init=/dev/mapper/3600*72b0;/dev/mapper/3600*72b0 storage_vol=:500::50:2048:500:600:700 swap_encrypt=Swap;Swap2 firstboot

Actual results: 
rhev-h will creating LVM partition(s) for HostVG and AppVG using the same hard disk

Expected results: 
Using function "cross_check_host_app" to check whether AppVG overlaps with HostVG or not should success.

Additional info: 
----------
Comment 2 Fabian Deutsch 2012-10-18 13:01:57 UTC 
Hey Hadong,

thanks for your patch, it's now upstream:
http://gerrit.ovirt.org/8657
Comment 7 Fabian Deutsch 2012-12-05 20:37:23 UTC 
I've reworked the patch to address some of it's shortcomings.

http://gerrit.virt.bos.redhat.com:8080/gerrit/#/c/419/

Patch Set 3

The detection of overlapping is now based on sets, this should work fine.
The overlapping itself is check when the partitioning is initiated an dnot in the constructor.

Please let me know if I missed something.

Tested as follows:
1. Boot with BOOTIF=link storage_init=/dev/sda,/dev/sdb;/dev/sda storage_vol=::::::100:200
2. Fails with correct message

1. Boot with BOOTIF=link storage_init=/dev/sda;/dev/sdb storage_vol=::::::100:200
2. Succeeds
Comment 16 haiyang,dong 2012-12-19 07:52:16 UTC 
Test version:
rhev-hypervisor6-6.4-20121212.1.el6 
ovirt-node-2.5.0-11.el6

Tested as follows:
1.BOOTIF=link storage_vol=::::::200:200 storage_init=/dev/sda,/dev/sdb;/dev/sda
Fails with overlap error about /dev/sda

2.BOOTIF=link storage_vol=::::::200:200 storage_init=/dev/sda;/dev/sda
Fails with overlap error about /dev/sda

3.BOOTIF=link storage_vol=::::::200:200 storage_init=/dev/sda;/dev/sdb
Succeeds

So crossing check between Host and AppVG successfully.
so this bug has been fixed, change the status into "VERIFIED"
Comment 18 errata-xmlrpc 2013-02-28 16:40:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0556.html
Note You need to log in before you can comment on or make changes to this bug.