RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 867412 - libvirt fails to clear async job when p2p migration fails early
Summary: libvirt fails to clear async job when p2p migration fails early
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.4
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Jiri Denemark
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-17 13:16 UTC by Jiri Denemark
Modified: 2013-02-21 07:10 UTC (History)
7 users (show)

Fixed In Version: libvirt-0.10.2-5.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 07:10:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0276 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2013-02-20 21:18:26 UTC

Description Jiri Denemark 2012-10-17 13:16:23 UTC 
Description of problem:

When p2p migration fails early because qemuMigrationIsAllowed or
qemuMigrationIsSafe say migration should be cancelled, we fail to clear
the migration-out async job. As a result of that, further APIs called
for the same domain may fail with Timed out during operation: cannot
acquire state change lock.

Version-Release number of selected component (if applicable):

libvirt-0.10.2-4.el6, introduced upstream in 0.9.5

How reproducible:

100%

Steps to Reproduce:
1. create and start a domain with disk on NFS and cache != none
2. virsh migrate --p2p $URI $DOM
3. virsh migrate --p2p $URI $DOM
  
Actual results:

Step 2 correctly results in:

error: Unsafe migration: Migration may lead to data corruption if disks use cache != none

Steps 3 will timeout after 30 seconds and report:

error: Timed out during operation: cannot acquire state change lock


Expected results:

No matter how many time we try to migrate the domain, it should still report error: Unsafe migration: Migration may lead to data corruption if disks use cache != none

Additional info:
Comment 1 Jiri Denemark 2012-10-17 13:17:47 UTC 
Patch sent upstream: https://www.redhat.com/archives/libvir-list/2012-October/msg00891.html
Comment 2 zhpeng 2012-10-18 02:48:50 UTC 
I can reproduce this with: libvirt-0.10.2-4.el6.x86_64

virsh # migrate aaa --p2p qemu+ssh://10.66.7.161/system --unsafe 
error: Timed out during operation: cannot acquire state change lock
Comment 3 Jiri Denemark 2012-10-18 09:17:58 UTC 
Fixed upstream by v0.10.2-191-g837993d":

commit 837993d845a32bb222959a84d1c03a0c47f785be
Author: Jiri Denemark <jdenemar>
Date:   Wed Oct 17 14:08:17 2012 +0200

    qemu: Clear async job when p2p migration fails early
    
    When p2p migration fails early because qemuMigrationIsAllowed or
    qemuMigrationIsSafe say migration should be cancelled, we fail to clear
    the migration-out async job. As a result of that, further APIs called
    for the same domain may fail with Timed out during operation: cannot
    acquire state change lock.
    
    Reported by Guido Winkelmann.
Comment 4 Jiri Denemark 2012-10-18 09:18:58 UTC 
In POST: http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-October/msg00920.html
Comment 6 zhpeng 2012-10-24 06:23:37 UTC 
Test with:


# virsh dumpxml rhel63q
...
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='writeback'/>
      <source file='/virt/rhel63q.img'/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </disk>
...

# virsh migrate rhel63q --p2p qemu+ssh://10.66.7.161/system --unsafe

and  "default", "writethrough", "directsync" result are same.


So it's verified.
Comment 7 zhpeng 2012-11-22 03:41:26 UTC 
correction：

 "default", "none", "writethrough", "writeback", and "unsafe" works well
our qemu not support "directsync"  yet.
Comment 8 errata-xmlrpc 2013-02-21 07:10:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html
Note You need to log in before you can comment on or make changes to this bug.