Spec URL: http://data-strzibny.rhcloud.com/rubygem-gem-nice-install-0.1.0-1.fc17.src.rpm SRPM URL: http://data-strzibny.rhcloud.com/rubygem-gem-nice-install.spec Description: A RubyGems plugin that improves gem installation user experience. If binary extension build fails, it tries to install its development dependencies. Fedora Account System Username: jstribny Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4614858 This is my second package review request for Fedora, so I need a sponsor. I wasn't sure about setting LANG env variable before `gem install` in the spec file, but it wouldn't work otherwise. I submitted this issue [1] to upstream. [1] https://github.com/voxik/gem-nice-install/issues/4
I'll take this for review and I can sponsor you as well.
* Source does not match upstream - According to review guidelines [1] "MUST: The sources used to build the package must match the upstream source, as provided in the spec URL." $ sha256sum gem-nice-install-0.1.0.gem* 427f3eab95874a839c8514910d4a40a49e8b2102437621cfebbad03a9f43748a \ gem-nice-install-0.1.0.gem 1fa0d05cc62d42981be5bc3b183d68c2b4c82347b5f6341af6a31b117e043345 \ gem-nice-install-0.1.0.gem.orig where the gem-nice-install-0.1.0.gem.orig is the gem I fetched from upstream * Remove the LANG=en_US.utf8 - It is not needed according to my tests and the package builds just fine without it in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4620593 Otherwise the package looks good. [1] http://fedoraproject.org/wiki/Packaging:ReviewGuidelines
Hi, it seems only RubyGems 1.8.0 is causing the trouble. After the upgrade to 1.8.24 `LANG=en_US.utf8` is not needed anymore. Updated SPEC & SRPM: SPEC: http://data-strzibny.rhcloud.com/rubygem-gem-nice-install.spec SRPM URL: http://data-strzibny.rhcloud.com/rubygem-gem-nice-install-0.1.0-2.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4624716
I have no other comments. The package looks good => APPROVED. Feel free to import it into Fedora once you are sponsored.
New Package SCM Request ======================= Package Name: rubygem-gem-nice-install Short Description: A RubyGems plugin that improves gem installation user experience Owners: jstribny vondruch bkabrda Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
rubygem-gem-nice-install-0.2.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-gem-nice-install-0.2.0-1.fc18
rubygem-gem-nice-install-0.2.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-gem-nice-install-0.2.0-1.fc17
rubygem-gem-nice-install-0.2.0-1.fc18 has been pushed to the Fedora 18 testing repository.
rubygem-gem-nice-install-0.2.0-1.fc18 has been pushed to the Fedora 18 stable repository.