Bug 869257 - RESTAPI: '?current' query parameter in PUT /api/vms/xxx/cdroms/yyy is inconsistent with rest of url parameters in api
Summary: RESTAPI: '?current' query parameter in PUT /api/vms/xxx/cdroms/yyy is incons...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-restapi
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Michael Pasternak
QA Contact: Barak Dagan
URL:
Whiteboard: infra
Depends On:
Blocks: 915537
TreeView+ depends on / blocked
 
Reported: 2012-10-23 12:20 UTC by Michael Pasternak
Modified: 2016-02-10 19:39 UTC (History)
9 users (show)

Fixed In Version: si23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 19:59:05 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Michael Pasternak 2012-10-23 12:20:11 UTC
Description of problem:

'?current' query parameter in PUT /api/vms/xxx/cdroms/yyy is inconsistent with the rest of url parameters in api, all url parameters (but query param) are 'matrix' type, while 'current' is 'query'.

[this change is required for clients (such as sdk) to consume url params
in generic way]

Comment 2 Michael Pasternak 2012-10-24 09:33:10 UTC
http://gerrit.ovirt.org/#/c/8765/

Comment 3 Michael Pasternak 2012-10-24 09:34:53 UTC
'?current=true' query parameter is depreciated and supported for backward compatibility only - should be dropped at 4.0,

new way to specify change-disk is: PUT /api/vms/xxx/cdroms/yyy;current

Comment 5 Barak Dagan 2012-11-14 15:48:46 UTC
verified on si24.1

tested:

?current=true
?current=false
;current=true
;current=false

getting the following results:


true
-----
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cdrom id="00000000-0000-0000-0000-000000000000">
    <file id="rhev-tools-setup.iso"/>
</cdrom>


false
-----
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cdrom id="00000000-0000-0000-0000-000000000000">
    <file id="rhev-tools-setup.iso"/>
</cdrom>


Note You need to log in before you can comment on or make changes to this bug.