Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 869257

Summary:	RESTAPI: '?current' query parameter in PUT /api/vms/xxx/cdroms/yyy is inconsistent with rest of url parameters in api
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Michael Pasternak <mpastern>
Component:	ovirt-engine-restapi	Assignee:	Michael Pasternak <mpastern>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Barak Dagan <bdagan>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	bazulay, dyasny, ecohen, iheim, mpastern, pstehlik, Rhev-m-bugs, sgrinber, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	si23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-04 19:59:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	915537

Description Michael Pasternak 2012-10-23 12:20:11 UTC

Description of problem:

'?current' query parameter in PUT /api/vms/xxx/cdroms/yyy is inconsistent with the rest of url parameters in api, all url parameters (but query param) are 'matrix' type, while 'current' is 'query'.

[this change is required for clients (such as sdk) to consume url params
in generic way]

Comment 2 Michael Pasternak 2012-10-24 09:33:10 UTC

http://gerrit.ovirt.org/#/c/8765/

Comment 3 Michael Pasternak 2012-10-24 09:34:53 UTC

'?current=true' query parameter is depreciated and supported for backward compatibility only - should be dropped at 4.0,

new way to specify change-disk is: PUT /api/vms/xxx/cdroms/yyy;current

Comment 5 Barak Dagan 2012-11-14 15:48:46 UTC

verified on si24.1

tested:

?current=true
?current=false
;current=true
;current=false

getting the following results:


true
-----
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cdrom id="00000000-0000-0000-0000-000000000000">
    <file id="rhev-tools-setup.iso"/>
</cdrom>


false
-----
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cdrom id="00000000-0000-0000-0000-000000000000">
    <file id="rhev-tools-setup.iso"/>
</cdrom>