Description of problem: The current rhts-mk-get-current-tag code can return the tag for the wrong test if the following test cases are created in the same git repo: testa testa-different If testa-different is updated after testa then when the user attempts to tag a newer version of testa it will pick up the tag from testa-different. All of the CURRENT_TAG code in the git section is too eager in its regex matching. CURRENT_TAG=$(git for-each-ref --count=1 --sort=-taggerdate --format="%(refname)" "refs/tags/${PACKAGE_NAME}*" | cut -c 11-) adding a -[0-9] may fix the issue, but if a developer writes a test with a -2 at the end it would get confused again. We should have a separator that can't be used in a test name. CURRENT_TAG=$(git for-each-ref --count=1 --sort=-taggerdate --format="%(refname)" "refs/tags/${PACKAGE_NAME}-[0-9]*" | cut -c 11-) Version-Release number of selected component (if applicable): rhts-devel-4.52-3
Patch was already supplied by Chao Wang <chaowang> back in April. http://gerrit.beaker-project.org/1427
Verified with rhts 4.53-1.el6eng. The fix works well. Reproduce steps: # mkdir bz869311 # cd bz869311/ # beaker-wizard testa ... # beaker-wizard testa2 ... # find . ./Sanity ./Sanity/testa ./Sanity/testa/PURPOSE ./Sanity/testa/Makefile ./Sanity/testa/runtest.sh ./Sanity/testa2 ./Sanity/testa2/PURPOSE ./Sanity/testa2/Makefile ./Sanity/testa2/runtest.sh # git init . # git add . # git commit -m "Initial" # cd Sanity/testa # make tag Tagging release as tmp-CoreOS-bz869311-Sanity-testa-1_0-1 # make tag Tagging release as tmp-CoreOS-bz869311-Sanity-testa-1_0-2 # cd ../testa2 # make tag Tagging release as tmp-CoreOS-bz869311-Sanity-testa2-1_0-1 # cd ../testa # make tag Tagging release as tmp-CoreOS-bz869311-Sanity-testa-1_0-2 fatal: tag 'tmp-CoreOS-bz869311-Sanity-testa-1_0-2' already exists make: *** [tag] Error 128
This has now been released
*** Bug 884331 has been marked as a duplicate of this bug. ***
Hi, I described an issue on #beaker and Dan Callaghan said it might be this BZ and to upgrade to 4.53 of rhts-devel but I'm on Fedora and there doesn't seem to be one for fedora here
i didn't mean to post comment 7. rmancy is working on creating an rpm for Fedora. please disregard