Bug 869399 - Maven RPM source test scope patch issue
Summary: Maven RPM source test scope patch issue
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: maven
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-10-23 19:23 UTC by Nick Cross
Modified: 2012-11-27 05:08 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-11-27 05:08:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nick Cross 2012-10-23 19:23:20 UTC
Description of problem:

Maven 3.0.3 and 3.0.4 RPMs appear to be patched and not using clean source

2011-08-30 - Stanislav Ochotnicky <sochotnicky> - 3.0.3-14 - Fix test scope skipping

I found this upstream ticket and patch here 
https://jira.codehaus.org/browse/MNG-5177

This ticket has been closed as invalid/won't fix. This patch breaks Maven maven.test.skip functionality. Can it be reverted please?


Version-Release number of selected component (if applicable):
3.0.3 and 3.0.4 releases.
This applies to F16/F17 and maybe F18. Possibly it might also apply to other RPM builds?

How reproducible:
Everytime

Comment 1 Stanislav Ochotnicky 2012-10-24 07:45:43 UTC
You are correct, the patch should have been conditional for mvn-rpmbuild use only. I'll fix it up in F17+

Comment 2 Mikolaj Izdebski 2012-10-24 08:16:12 UTC
Test scope is used primarly (and almost exclusively) for specifying dependencies of tests. This patch has worked just fine in Fedora for over a year, but I agree it could teoreticly be a problem with some uncommon configuration.

The only sane solution I can see is conditionally enabling or disabling resolution of dependencies in test scope depending on whether maven is running in local mode or not. Simply unapplying this patch would cause massive FTBFS of Fedora Java packages, which would have to be solved by applying numerous patches. (In F17+ something like "%pom_xpath_remove pom:dependecy[pom:scope[text()='test']]" could be used, but in F16 this functionality is absent, so tradiotional patches or sed would have to be used. Not very nice.)

Comment 3 Fedora Update System 2012-10-24 12:05:21 UTC
maven-3.0.4-14.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/maven-3.0.4-14.fc17

Comment 4 Fedora Update System 2012-10-24 12:05:42 UTC
maven-3.0.4-14.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/maven-3.0.4-14.fc18

Comment 5 Fedora Update System 2012-10-24 16:17:01 UTC
Package maven-3.0.4-14.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing maven-3.0.4-14.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-16797/maven-3.0.4-14.fc18
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2012-11-09 15:53:13 UTC
maven-3.0.4-21.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/maven-3.0.4-21.fc18

Comment 7 Fedora Update System 2012-11-27 05:08:45 UTC
maven-3.0.4-21.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.