Spec URL: http://lisas.de/~adrian/rpm/crtools.spec SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.2-1.fc17.src.rpm Description: crtools is the user-space part of CRIU, a project to implement checkpoint/restore functionality for Linux in user-space. This is needed for https://fedoraproject.org/wiki/Features/Checkpoint_Restore and cannot yet be tested without the required kernel config changes. Fedora Account System Username: adrian
Use name and version macro on Source0. Don't use macros for mkdir and install. You might want to leave a comment, why it only works on x86_64.
Thanks for the review. I have removed the macros for mkdir and install and added a comment why it only works on x86_64. As it is not required to use macros in Source0 I would rather leave it the way it is. Spec URL: http://lisas.de/~adrian/rpm/crtools.spec SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.2-2.fc17.src.rpm * Tue Aug 21 2012 Adrian Reber <adrian> - 0.2-2 - remove macros like %%{__mkdir_p} and %%{__install} - add comment why it is only x86_64 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Spec URL: http://lisas.de/~adrian/rpm/crtools.spec SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.3-1.fc18.src.rpm * Mon Jan 14 2013 Adrian Reber <adrian> - 0.3-1 - updated to 0.3 - fix building Documentation/ 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Review for this package: > Spec URL: http://lisas.de/~adrian/rpm/crtools.spec > SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.3-1.fc18.src.rpm Rpmlint is clean. Found one blocker: The package guidelines say there must me a bug mentioned in the spec file for every ExcludeArch used; that section has a lot of "MUST" and I'd say it can be expected to apply to ExclusiveArch, too. So I'd say: file one bug and mention it in the spec file, that should be sufficient. A few nit-picks: - I wonder if the summary would benefit from a "Tool for " - Explaining what CRIU actually means in the description would be wise, too - would be good if upstream would include a install section in the Makefile and could fix the stack-protector problem
Thanks for the review. Concerning the ExcludeArch: Without the package being imported I cannot file a bug. Reading https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Architecture_Build_Failures it seems okay to open the bug after importing the package once a bugzilla entry has been created. I will do that as soon as the package has passed review. I changed the Summary and Description and will contact upstream about the install section and the stack-protector problem. Spec URL: http://lisas.de/~adrian/rpm/crtools.spec SRPM URL: http://lisas.de/~adrian/rpm/crtools-0.3-2.fc18.src.rpm * Fri Jan 18 2013 Adrian Reber <adrian> - 0.3-2 - improved Summary and Description
In that case: APPROVED
New Package SCM Request ======================= Package Name: crtools Short Description: Tool for Checkpoint/Restore in User-space Owners: adrian Branches: InitialCC:
Git done (by process-git-requests).
ExclusiveArch blocker bug: https://bugzilla.redhat.com/show_bug.cgi?id=902875 http://koji.fedoraproject.org/koji/taskinfo?taskID=4894050
No additional SCM maintenance required.
*** Bug 1046622 has been marked as a duplicate of this bug. ***