Spec URL: http://gil.fedorapeople.org/glassfish-hk2.spec SRPM URL: http://gil.fedorapeople.org/glassfish-hk2-2.1.37-1.fc16.src.rpm Description: HK2 for Hundred Kilobytes Kernel is an abstraction to a module subsystem coupled with a simple yet powerful component model to build server side software. Fedora Account System Username: gil
Spec URL: http://gil.fedorapeople.org/glassfish-hk2.spec SRPM URL: http://gil.fedorapeople.org/glassfish-hk2-2.1.92-1.fc18.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines See below ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [x]: Pom files have correct Maven mapping [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- Error: Package: glassfish-hk2-dependency-verifier-2.1.92-1.fc20.noarch (/glassfish-hk2-dependency-verifier-2.1.92-1.fc20.noarch) Requires: glassfish-hk2-osgi-adapter = 2.1.92-1.fc20 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: glassfish-hk2-2.1.92-1.fc20.noarch.rpm glassfish-hk2-api-2.1.92-1.fc20.noarch.rpm glassfish-hk2-apt-2.1.92-1.fc20.noarch.rpm glassfish-hk2-class-model-2.1.92-1.fc20.noarch.rpm glassfish-hk2-core-2.1.92-1.fc20.noarch.rpm glassfish-hk2-dependency-verifier-2.1.92-1.fc20.noarch.rpm glassfish-hk2-dependency-visualizer-2.1.92-1.fc20.noarch.rpm glassfish-hk2-guice-bridge-2.1.92-1.fc20.noarch.rpm glassfish-hk2-inhabitant-generator-2.1.92-1.fc20.noarch.rpm glassfish-hk2-locator-2.1.92-1.fc20.noarch.rpm glassfish-hk2-maven-2.1.92-1.fc20.noarch.rpm glassfish-hk2-maven-plugins-2.1.92-1.fc20.noarch.rpm glassfish-hk2-osgi-2.1.92-1.fc20.noarch.rpm glassfish-hk2-runlevel-2.1.92-1.fc20.noarch.rpm glassfish-hk2-testing-2.1.92-1.fc20.noarch.rpm glassfish-hk2-utils-2.1.92-1.fc20.noarch.rpm glassfish-hk2-javadoc-2.1.92-1.fc20.noarch.rpm glassfish-hk2-apt.noarch: E: devel-dependency java-devel glassfish-hk2-dependency-visualizer.noarch: W: spelling-error %description -l en_US verifier -> versifier, verifies, verified glassfish-hk2-locator.noarch: E: explicit-lib-dependency cglib glassfish-hk2-maven-plugins.noarch: W: spelling-error %description -l en_US osgiversion -> diversion, perversion, version 17 packages and 0 specfiles checked; 2 errors, 2 warnings. false positives Requires -------- glassfish-hk2-guice-bridge (rpmlib, GLIBC filtered): atinject glassfish-hk2 glassfish-hk2-api google-guice jpackage-utils glassfish-hk2-dependency-visualizer (rpmlib, GLIBC filtered): args4j glassfish-hk2 jpackage-utils glassfish-hk2-core (rpmlib, GLIBC filtered): bea-stax-api glassfish-hk2 glassfish-hk2-locator glassfish-hk2-utils jpackage-utils glassfish-hk2-javadoc (rpmlib, GLIBC filtered): jpackage-utils glassfish-hk2 (rpmlib, GLIBC filtered): java jpackage-utils glassfish-hk2-inhabitant-generator (rpmlib, GLIBC filtered): atinject glassfish-hk2 glassfish-hk2-api jpackage-utils junit mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) objectweb-asm glassfish-hk2-osgi (rpmlib, GLIBC filtered): felix-bundlerepository felix-osgi-compendium felix-osgi-core glassfish-hk2 glassfish-hk2-api glassfish-hk2-core jpackage-utils glassfish-hk2-apt (rpmlib, GLIBC filtered): glassfish-hk2 glassfish-hk2-api glassfish-hk2-class-model glassfish-hk2-utils java-devel jpackage-utils tiger-types glassfish-hk2-maven (rpmlib, GLIBC filtered): felix-osgi-core glassfish-hk2 glassfish-hk2-core jpackage-utils mvn(org.apache.maven:maven-archiver) mvn(org.apache.maven:maven-artifact) mvn(org.apache.maven:maven-compat) mvn(org.apache.maven:maven-core) glassfish-hk2-api (rpmlib, GLIBC filtered): atinject glassfish-hk2 glassfish-hk2-utils jpackage-utils osgi-resource-locator glassfish-hk2-testing (rpmlib, GLIBC filtered): atinject glassfish-hk2 glassfish-hk2-api glassfish-hk2-locator jpackage-utils junit objectweb-asm glassfish-hk2-utils (rpmlib, GLIBC filtered): atinject glassfish-hk2 jpackage-utils junit glassfish-hk2-locator (rpmlib, GLIBC filtered): atinject bea-stax-api cglib glassfish-hk2 glassfish-hk2-api glassfish-hk2-utils jpackage-utils junit objectweb-asm tiger-types glassfish-hk2-maven-plugins (rpmlib, GLIBC filtered): glassfish-hk2 glassfish-hk2-core jpackage-utils mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.apache.maven.shared:maven-osgi) mvn(org.apache.maven:maven-plugin-api) glassfish-hk2-class-model (rpmlib, GLIBC filtered): felix-osgi-core glassfish-hk2 jpackage-utils junit objectweb-asm glassfish-hk2-runlevel (rpmlib, GLIBC filtered): glassfish-hk2 glassfish-hk2-api glassfish-hk2-locator jpackage-utils junit glassfish-hk2-dependency-verifier (rpmlib, GLIBC filtered): bcel felix-osgi-core glassfish-hk2 glassfish-hk2-core glassfish-hk2-osgi-adapter jpackage-utils Provides -------- glassfish-hk2-guice-bridge: glassfish-hk2-guice-bridge mvn(org.glassfish.hk2:guice-bridge) osgi(org.glassfish.hk2.guice-bridge) glassfish-hk2-dependency-visualizer: glassfish-hk2-dependency-visualizer mvn(org.glassfish.hk2:hk2-dependency-visualizer) glassfish-hk2-core: glassfish-hk2-core mvn(org.glassfish.hk2:core) osgi(org.glassfish.hk2.core) glassfish-hk2-javadoc: glassfish-hk2-javadoc glassfish-hk2: glassfish-hk2 mvn(org.glassfish.hk2:hk2-bom) mvn(org.glassfish.hk2:hk2-build) mvn(org.glassfish.hk2:hk2-kernel-parent) mvn(org.glassfish.hk2:hk2-parent) mvn(org.glassfish.hk2:hk2-public) glassfish-hk2-inhabitant-generator: glassfish-hk2-inhabitant-generator mvn(org.glassfish.hk2:hk2-inhabitant-generator) glassfish-hk2-osgi: glassfish-hk2-osgi mvn(org.glassfish.hk2:contract-bundle) mvn(org.glassfish.hk2:faux-sdp-bundle) mvn(org.glassfish.hk2:osgi) mvn(org.glassfish.hk2:osgi-adapter) mvn(org.glassfish.hk2:osgi-adapter-tests-parent) mvn(org.glassfish.hk2:sdp-management-bundle) mvn(org.glassfish.hk2:test-module-startup) osgi(org.glassfish.hk2.contract-bundle) osgi(org.glassfish.hk2.faux-sdp-bundle) osgi(org.glassfish.hk2.osgi-adapter) osgi(org.glassfish.hk2.sdp-management-bundle) osgi(org.glassfish.hk2.test-module-startup) glassfish-hk2-apt: glassfish-hk2-apt mvn(org.glassfish.hk2:auto-depends-plugin) glassfish-hk2-maven: glassfish-hk2-maven mvn(org.glassfish.hk2:hk2-maven) glassfish-hk2-api: glassfish-hk2-api mvn(org.glassfish.hk2:hk2-api) osgi(org.glassfish.hk2.api) glassfish-hk2-testing: glassfish-hk2-testing mvn(org.glassfish.hk2:hk2-junitrunner) mvn(org.glassfish.hk2:hk2-testing) osgi(org.glassfish.hk2.junitrunner) glassfish-hk2-utils: glassfish-hk2-utils mvn(org.glassfish.hk2:hk2-utils) osgi(org.glassfish.hk2.utils) glassfish-hk2-locator: glassfish-hk2-locator mvn(org.glassfish.hk2:hk2-locator) osgi(org.glassfish.hk2.locator) glassfish-hk2-maven-plugins: glassfish-hk2-maven-plugins mvn(org.glassfish.hk2:consolidatedbundle-maven-plugin) mvn(org.glassfish.hk2:osgiversion-maven-plugin) glassfish-hk2-class-model: glassfish-hk2-class-model mvn(org.glassfish.hk2:class-model) osgi(org.glassfish.hk2.class-model) glassfish-hk2-runlevel: glassfish-hk2-runlevel mvn(org.glassfish.hk2:hk2-runlevel) osgi(org.glassfish.hk2.runlevel) glassfish-hk2-dependency-verifier: glassfish-hk2-dependency-verifier mvn(org.glassfish.hk2:hk2-dependency-verifier) Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 871018 Issue: glassfish-hk2-dependency-verifier is not installable. It requires "hk2-osgi-adapter", but there is no such subpackage. It should probably require hk2-osgi instead, because this subpackage contains required artifact. Tips: -version 2.1.93 is available, please consider updating -it's not necessary to explicitly specify BR on following maven plugins: maven-compiler-plugin, maven-jar-plugin, maven-javadoc-plugin, maven-surefire-plugin, maven-surefire-provider-junit4 if your package BR maven-local, those maven plugins will be pulled in automatically. So this could simplify a spec file little bit.
Spec URL: http://gil.fedorapeople.org/glassfish-hk2.spec SRPM URL: http://gil.fedorapeople.org/glassfish-hk2-2.1.93-1.fc18.src.rpm - fixed broken requires - update to 2.1.93 - commented not neccessary maven plugins
Everything seems to be in order now, thanks. Approved.
New Package SCM Request ======================= Package Name: glassfish-hk2 Short Description: Hundred Kilobytes Kernel Owners: gil Branches: f18 f19 InitialCC: java-sig
Git done (by process-git-requests).
glassfish-hk2-2.1.93-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glassfish-hk2-2.1.93-1.fc19
glassfish-hk2-2.1.93-1.fc19 has been pushed to the Fedora 19 testing repository.
glassfish-hk2-2.1.93-1.fc19 has been pushed to the Fedora 19 stable repository.
glassfish-hk2-2.1.93-1.fc18 has been pushed to the Fedora 18 stable repository.