Red Hat Bugzilla – Bug 871104
Installer allows use of preexisting root filesystem
Last modified: 2012-11-08 04:38:37 EST
Description of problem:
Anaconda currently allows users to set as root a filesystem that existed prior to installation, which has been disallowed since F15 (see bug 629311).
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create a filesystem (ext4 or xfs)
2. Run the installer
3. Set the fs from step 1 as '/' but do not mark for reformat
Installer will happily try to install to the preexisting rootfs and will fail miserably if there is actually a previous installation on it.
Installer does not allow this highly dubious operation.
I have a tested patch ready to send out for review.
For many years I have created an empty filesystem before
I installed a Fedora on it. Will your patch allow that?
If not, can I ask that you modify your patch to allow it?
Discussed at 2012-10-31 NTH review meeting: http://meetbot.fedoraproject.org/fedora-qa/2012-10-31/f18beta-blocker-review-6.2012-10-31-16.00.log.txt . Accepted as NTH as this is a safe and clearly desirable change. For the record, the patch is https://lists.fedorahosted.org/pipermail/anaconda-patches/2012-October/001824.html .
Paul, I don't believe that would be a problem, this bug only intends to duplicate the pre-F18 behaviour.
Please think about people (like me) who doesn't have /home on a separate partition. There can be many reasons for that, e.g. a small disk (SSD for example). When I want to reinstall the system, I remove all directories except /home and then set the partition as / without reformatting it.
I wasn't using Anaconda back then, but installers from other distributions. The last time I needed to do it with Anaconda, the partitioning shuffling was pretty difficult, because Anaconda insisted on formatting /.
David, can Anaconda guard against bad uses cases (as in your original description) and still allow the one I just described?
"Please think about people (like me) who doesn't have /home on a separate partition. There can be many reasons for that, e.g. a small disk (SSD for example)."
Funnily enough, we have this great thing called 'LVM', which we use by default, which lets you easily adjust the size of different partitions, making this really not a big problem. You can install with a 10GB / and a 30GB /home or whatever, and adjust the ratios between them online without losing data later on if it turns out you need to.
My personal take is that your use case is a dumb one which we shouldn't support. We can't support _everything_.
anaconda-18.22-1.fc18 has been submitted as an update for Fedora 18.
(In reply to comment #1)
> For many years I have created an empty filesystem before
> I installed a Fedora on it. Will your patch allow that?
> If not, can I ask that you modify your patch to allow it?
My patch will not allow it. This was not allowed in Fedora 17, either.
If you really need non-default arguments passed to mke2fs you can either use kickstart (see the fsprofile option) or use an updates image to modify /etc/mke2fs.conf.
I realize we could support this in theory, but it involves writing a significant chunk of code to support a use-case that we already support in other ways (see above). It just isn't likely to bubble up to the top of anyone's todo list for that reason.
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-18.22-1.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
anaconda-18.23-1.fc18 has been submitted as an update for Fedora 18.
anaconda-18.24-1.fc18 has been submitted as an update for Fedora 18.
anaconda-18.25-1.fc18 has been submitted as an update for Fedora 18.
anaconda-18.26-1.fc18 has been submitted as an update for Fedora 18.
18.26 went stable. Closing. (Bodhi closing of bugs when updates go stable is currently broken).