Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
It is now possible to atomically persist configuration files. This feature allows users to update persisted files without overwriting the files' content and potentially breaking the system with misconfigured code.
Hello,
Currently there is no way to perform atomic store of configuration file. The persistence API of ovirtnode.ovirtfunctions can fail in many stages and leave system in unpredictable state.
I suggest an API like:
persist(file, destination)
1. cp file /config/destination.tmp
2. mv /config/destination.tmp /config/destination
3. rebind /config/destination destination
This way we have either the content of the new or old file.
---
BTW:
Looking at code, please try to do as much as you can in python. I don't understand the reason of calling system utilities such as:
system("mkdir -p /config/" + dirname)
->os.makedirs(os.path.join('/config', dirname))
system("rm -f /config"+ filename)
->shutil.rmtree(os.path.join('/config', dirname))
system_closefds("echo "+filename+" >> /config/files")
->with open('/config/files', 'a') as f:
f.write("%s\n" % filename)
ret = system_closefds("grep -q \"^$" + filename +"$\" " + \
" /config/files 2> /dev/null")
->with open('/config/files', 'r') as f:
if filename in f:
....
etc...
Using python only reduces the blocks that can fail, provide better control on code flow and much better perform.
In these small cases you must call external program, please try to avoid system() as it may route output and input of caller which is an unexpected behaviour of an API. Use subprocess.Popen().
Thank you.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2013-0556.html
Hello, Currently there is no way to perform atomic store of configuration file. The persistence API of ovirtnode.ovirtfunctions can fail in many stages and leave system in unpredictable state. I suggest an API like: persist(file, destination) 1. cp file /config/destination.tmp 2. mv /config/destination.tmp /config/destination 3. rebind /config/destination destination This way we have either the content of the new or old file. --- BTW: Looking at code, please try to do as much as you can in python. I don't understand the reason of calling system utilities such as: system("mkdir -p /config/" + dirname) ->os.makedirs(os.path.join('/config', dirname)) system("rm -f /config"+ filename) ->shutil.rmtree(os.path.join('/config', dirname)) system_closefds("echo "+filename+" >> /config/files") ->with open('/config/files', 'a') as f: f.write("%s\n" % filename) ret = system_closefds("grep -q \"^$" + filename +"$\" " + \ " /config/files 2> /dev/null") ->with open('/config/files', 'r') as f: if filename in f: .... etc... Using python only reduces the blocks that can fail, provide better control on code flow and much better perform. In these small cases you must call external program, please try to avoid system() as it may route output and input of caller which is an unexpected behaviour of an API. Use subprocess.Popen(). Thank you.