Bug 872103 - sigar: Java bindings are missing
Summary: sigar: Java bindings are missing
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: sigar
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Andrew Beekhof
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Elasticsearch
TreeView+ depends on / blocked
 
Reported: 2012-11-01 09:15 UTC by Martin Bacovsky
Modified: 2015-01-07 03:45 UTC (History)
8 users (show)

Fixed In Version: sigar-1.6.5-0.12.git58097d9.fc22
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-07 03:45:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch adding the java bindings (1.68 KB, patch)
2012-11-01 09:15 UTC, Martin Bacovsky
no flags Details | Diff
Added java bindings sub package (34.96 KB, patch)
2012-12-05 08:36 UTC, gil cattaneo
no flags Details | Diff
Added java bindings sub package (18.04 KB, patch)
2012-12-05 09:46 UTC, gil cattaneo
no flags Details | Diff
Added java bindings sub packages (17.55 KB, text/plain)
2014-09-06 00:01 UTC, gil cattaneo
no flags Details

Description Martin Bacovsky 2012-11-01 09:15:09 UTC
Created attachment 636511 [details]
Patch adding the java bindings

Description of problem:
Java bindings are not packaged in the builds. In the sources the bindings are available, but are not processed during the build.

Patch for the spec file is attached, but needs review. The patch is adding sigar-java subpackage with the bindings.

How reproducible:
Always
 
Actual results:
There are no java bindings available in the build

Comment 1 gil cattaneo 2012-12-05 08:36:56 UTC
Created attachment 658055 [details]
Added java bindings sub package

this patch remove all pre compiled java libraries, and use system libraries.
installed jni libraries in proper directories*.
build only linux jni libraries

* NOTE exist a new guidelines ready but they haven't been approved yet

Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4758384

Comment 2 gil cattaneo 2012-12-05 09:26:09 UTC
(In reply to comment #1)

> * NOTE exist a new guidelines ready but they haven't been approved yet
 see https://fedoraproject.org/w/index.php?title=User:Akurtakov/JavaPackagingDraftUpdate#Packaging_JAR_files_that_use_JNI

TODO: change "System.loadLibrary(name);" (line 52)
with the proper solution reportedin the previous guideline
bindings/java/src/org/hyperic/sigar/SigarLoader.java

Comment 3 gil cattaneo 2012-12-05 09:46:21 UTC
Created attachment 658098 [details]
Added java bindings sub package

clean up PATCH120

Comment 4 Fedora End Of Life 2013-07-03 19:43:01 UTC
This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '17'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 17's end of life.

Bug Reporter:  Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 17 is end of life. If you 
would still like  to see this bug fixed and are able to reproduce it 
against a later version  of Fedora, you are encouraged  change the 
'version' to a later Fedora version prior to Fedora 17's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2013-07-31 18:33:38 UTC
Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Miroslav Suchý 2013-08-01 07:51:49 UTC
Still valid for current rawhide. Reopening.

Comment 7 Jeffrey C. Ollie 2014-03-11 16:49:28 UTC
Elastic Search uses sigar's Java bindings, so it would be great if this could be fixed sometime.

Comment 8 gil cattaneo 2014-09-06 00:01:32 UTC
Created attachment 934925 [details]
Added java bindings sub packages

Comment 9 gil cattaneo 2014-09-06 00:02:52 UTC
(In reply to gil cattaneo from comment #8)
> Created attachment 934925 [details]
> Added java bindings sub packages

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7533176

Comment 10 Zbigniew Jędrzejewski-Szmek 2014-12-17 18:24:12 UTC
Patch looks fine mostly, but there's seems to be unnecessary noise (some xml tags are commented out) which makes it harder to see what is happening. Also, it does some cleanup to the spec (buildroot, etc). Can you split it out into two separate patches?

Maintainer should voice his opinion...

Comment 11 Andrew Beekhof 2015-01-04 22:37:42 UTC
Would anyone like to take over maintenance of this package?
I don't have much cause to use it anymore

Comment 12 Zbigniew Jędrzejewski-Szmek 2015-01-07 03:45:39 UTC
I now updated Gil's patch a bit and pushed it to rawhide. It seems safe enough. Hopefully this will allow ElasticSearch packaging to proceed.

I'll also build it for F21, since there were some cleanups which are useful for the stable release too.


Note You need to log in before you can comment on or make changes to this bug.