Bug 872361 - parted shouldn't de-reference symlinks for named md devices(?) - this is blocking Intel fwraid support for F18 Beta
Summary: parted shouldn't de-reference symlinks for named md devices(?) - this is bloc...
Alias: None
Product: Fedora
Classification: Fedora
Component: parted
Version: 18
Hardware: All
OS: All
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F18Beta, F18BetaBlocker
TreeView+ depends on / blocked
Reported: 2012-11-01 21:25 UTC by Adam Williamson
Modified: 2012-11-12 13:56 UTC (History)
4 users (show)

Fixed In Version: parted-3.1-9.fc18
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-11-12 13:56:57 UTC
Type: Bug

Attachments (Terms of Use)
strace of 'parted -s /dev/md126 p' on a fresh RAID-1 array booted from Beta TC7 desktop live (15.43 KB, text/plain)
2012-11-06 17:16 UTC, Adam Williamson
no flags Details

Description Adam Williamson 2012-11-01 21:25:10 UTC
This bug is being split off from https://bugzilla.redhat.com/show_bug.cgi?id=866519 . After a series of fixes for correctly presenting Intel fwraid devices in anaconda's disk picker, we eventually ran up against an issue in parted when anaconda tries to actually create the partitions for an installation to such a device.

I don't entirely grok the issue myself, but it is clear it's separate from 866519, it's in parted, and bcl ought to be dealing with it. Here's some strategic IRC copypasta:

<dlehman> bcl: it's not the p delimiter. it's that you instantiate a Device with a path and then when you access its path attr it's been resolved to a different path.
 so I do d=parted.Device(path="/dev/md/foo") ; print d.path => "/dev/md126p3"
<bcl> oh, ok. I misunderstood that one then.
 so foo is a symlink to ../md126p3
<dlehman> right. somewhere in parted it probably has code to not resolve the symlink for /dev/mapper/ paths. if so, it would just need to applied also to /dev/md/ paths.
<bcl> I'll have another look. got any way to reproduce that without special hardware?
<dlehman> you can make a partitioned md device
 should be as simple as making a disklabel on top of a regular (named) md array, adding partitions
<bcl> adamw: sounds like parted shouldn't de-reference symlinks.
<bcl> which may cause other issues, so we'll see what I find in the code.
<dlehman> bcl:fwiw  it doesn't dereference symlinks for /dev/mapper/ devices

Comment 1 Adam Williamson 2012-11-01 21:26:22 UTC
I'm going to skip the bureaucracy and mark this as accepted blocker as it can clearly inherit that status from 866519. That was an accepted blocker because it meant Intel fw RAID didn't work; now this bug is what's stopping Intel fw RAID from working. If that was a blocker, this necessarily must be. We're just splitting the issue out for clarity of assignment.

Comment 2 Fedora Update System 2012-11-02 17:32:57 UTC
parted-3.1-9.fc18 has been submitted as an update for Fedora 18.

Comment 3 Adam Williamson 2012-11-03 02:34:25 UTC
I checked this fix with an image Tim built, it works fine. Will confirm again with TC7 tpmorrow.

Comment 4 Fedora Update System 2012-11-03 19:26:45 UTC
Package parted-3.1-9.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing parted-3.1-9.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).

Comment 5 Adam Williamson 2012-11-06 01:52:26 UTC
verified fixed in TC7.

Comment 6 Adam Williamson 2012-11-06 17:16:34 UTC
Created attachment 639471 [details]
strace of 'parted -s /dev/md126 p' on a fresh RAID-1 array booted from Beta TC7 desktop live

I got strace output from the sticking parted command. Created the RAID-1 array afresh, booted F18 Beta TC7 live, installed strace, and ran 'strace -o parted.txt parted -s /dev/md126 p'. This attachment is the result.

Comment 7 Adam Williamson 2012-11-06 17:17:59 UTC
Damn, wrong bug. Sorry. Disregard above comment.

Comment 8 Kamil Páral 2012-11-12 13:56:57 UTC
parted-3.1-9.fc18 is now stable, closing.

Note You need to log in before you can comment on or make changes to this bug.