Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 872550

Summary: "java.io.NotSerializableException: org.drools.guvnor.server.security.rules.PackageNameTypeConverter" when session replication is enabled
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Jiri Locker <jlocker>
Component: BRM (Guvnor)Assignee: manstis
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: BRMS 5.3.1CC: manstis
Target Milestone: ER4   
Target Release: BRMS 5.3.1 GA   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
BRMS standalone package/EAP 5.1.2
Last Closed: 2025-02-10 03:21:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
server.log none

Description Jiri Locker 2012-11-02 12:20:58 UTC 
Created attachment 637056 [details]
server.log

Description of problem:
When working with Guvnor and session replication is enabled, java.io.NotSerializableException occurs very often during session replication.

Version-Release number of selected component (if applicable):
BRMS 5.3.1.ER3

How reproducible:
when session replication is enabled

Steps to Reproduce:
1. enable session replication by adding <distributable/> tag in the web.xml descriptor
2. log in into Guvnor
3. see server.log
  
Actual results:
2012-11-02 10:52:19,863 ERROR [org.jboss.cache.marshall.CacheMarshaller300] (http-127.0.0.1-8080-2) Error while marshalling object: ReplicateCommand{cmds=PutDataMapCommand{fqn=/JSESSION/jboss-brms_localhost/vAi6cR-MtVOLfLJsv0LZVA__, dataVersion=null, data={0=17, 1=1351849939589, 3=org.jboss.ha.framework.server.SimpleCachableMarshalledValue{raw=java.util.HashMap@1501266156serialized=false}}, globalTransaction=null, erase=false}}
java.io.NotSerializableException: org.drools.guvnor.server.security.rules.PackageNameTypeConverter

Expected results:
no exception during session replication

Additional info:
https://access.redhat.com/knowledge/solutions/22936
attached server.log with full exception stack trace
Comment 1 Geoffrey De Smet 2012-11-02 16:26:24 UTC 
Harmless fix, but we can't test it properly due to no session replication setup.

Pushed to master, 5.5.x and 5.4.x
https://github.com/droolsjbpm/guvnor/commit/9230d3e5a10cfd845f66929b997387a343bbccb8

Once we got the blocker+ tag, we can pull it to 5.3.x with
git cherry-pick -x b1ebc11f3408dd26184144264300dbedcf8e2219
Comment 2 manstis 2012-11-02 16:28:52 UTC 
Jiri, if you want this in 5.3.1 can you please organize the 5.3.1+ and blocker+ flags being set? Thanks.
Comment 3 Rajesh Rajasekaran 2012-11-05 13:36:46 UTC 
Setting the release flag and the pm ack and QE and Dev agree this is a blocker, a fix is ready and would not impact the schedule at this point.
Comment 4 Geoffrey De Smet 2012-11-05 14:12:23 UTC 
Backported to 5.3.x
https://github.com/droolsjbpm/guvnor/commit/f9eaa4b3e6c10a0ccca31a9ac555da7d8f0b6df8
Comment 5 Jiri Locker 2012-11-07 15:10:53 UTC 
I did a preliminary testing (just swapping the affected class in ER3 with the fixed one) and things went as expected: no error with PackageNameTypeConverter, however it seems there are still some classes left to be marked Serializable, e.g. PackageUUIDTypePermissionRule.

I'll try to find all of them and a pull request may follow.
Comment 6 Jiri Locker 2012-11-07 18:22:38 UTC 
Pull request ready https://github.com/droolsjbpm/guvnor/pull/73.

With this change NotSerializableException doesn't occur anymore. If it's ok, please merge the request and move this bug to modified so it can be included in the next build.
Comment 7 manstis 2012-11-08 11:28:12 UTC 
Pull Request merged. Thanks Jiri (and applied to 5.4.x, 5.5.x and master branches too).
Comment 8 Jiri Locker 2012-11-12 16:48:10 UTC 
Fix verified in ER4.
Comment 17 Red Hat Bugzilla 2025-02-10 03:21:03 UTC 
This product has been discontinued or is no longer tracked in Red Hat Bugzilla.