Bug 872771 - (qextserialport) Review Request: qextserialport - Qt interface class for old fashioned serial ports
Review Request: qextserialport - Qt interface class for old fashioned serial ...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dan Horák
Fedora Extras Quality Assurance
Depends On:
Blocks: kde-reviews 872971 872883
  Show dependency treegraph
Reported: 2012-11-02 20:28 EDT by Volker Fröhlich
Modified: 2014-12-03 13:34 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-11-14 21:26:56 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dan: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Volker Fröhlich 2012-11-02 20:28:23 EDT
Spec URL: http://www.geofrogger.net/review/qextserialport.spec
SRPM URL: http://www.geofrogger.net/review/qextserialport-1.2-0.1.beta2.fc16.src.rpm

QextSerialPort provides an interface to old fashioned
serial ports for Qt-based applications.

Fedora Account System Username: volter

Comment 2 Volker Fröhlich 2012-11-03 06:47:05 EDT
Already submitted patch for QGIS: http://hub.qgis.org/issues/6613
Comment 3 Kevin Kofler 2012-11-03 19:31:24 EDT
Also qlandkartegt:

Volker found a handful other upstream projects which use this, but it looks like only the GIS stuff is already in Fedora.
Comment 4 Dan Horák 2012-11-04 05:32:44 EST
formal review is here, see the notes explaining OK* and BAD statuses below:

BAD     source files match upstream:
            cc9e91f6e1bec987616066902fbf532937b120e5  qextserialport-1.2beta2.tar.gz
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros consistently.
OK      dist tag is present.
OK      license field matches the actual license.
OK      license is open source-compatible (MIT). License text included in package.
OK      latest version is being packaged.
OK      BuildRequires are proper.
OK      compiler flags are appropriate.
OK      package builds in mock (Rawhide/x86_64).
OK      debuginfo package looks complete.
OK      rpmlint is silent.
BAD     final provides and requires look sane.
N/A     %check is present and all tests pass.
OK      shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      correct scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      headers in devel subpackage
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      not a GUI app.

- please use the whole URL for the source archive - http://qextserialport.googlecode.com/files/qextserialport-1.2beta2.tar.gz works here, otherwise a comment is needed
- the devel subpackage should depend on qt4-devel, because %{_qt4_datadir}/mkspecs/features/
    would be unwned otherwise, also it's unusable without qt4-devel
- I prefer trailing slash when whole directory should be included => %{_includedir}/QtExtSerialPort/
Comment 5 Volker Fröhlich 2012-11-04 05:57:23 EST
Argh, those were stupid mistakes!

Spec URL: http://www.geofrogger.net/review/qextserialport.spec
SRPM URL: http://www.geofrogger.net/review/qextserialport-1.2-0.2.beta2.fc16.src.rpm
Comment 6 Dan Horák 2012-11-04 06:01:32 EST
all issues are fixed now, APPROVED
Comment 7 Volker Fröhlich 2012-11-04 06:12:54 EST
New Package SCM Request
Package Name: qextserialport
Short Description: Qt interface class for old fashioned serial ports
Owners: volter
Branches: f17 f18
Comment 8 Gwyn Ciesla 2012-11-05 08:08:35 EST
Git done (by process-git-requests).
Comment 9 Fedora Update System 2012-11-05 11:30:40 EST
qextserialport-1.2-0.2.beta2.fc17 has been submitted as an update for Fedora 17.
Comment 10 Fedora Update System 2012-11-05 11:31:21 EST
qextserialport-1.2-0.2.beta2.fc18 has been submitted as an update for Fedora 18.
Comment 11 Fedora Update System 2012-11-05 17:44:56 EST
qextserialport-1.2-0.2.beta2.fc18 has been pushed to the Fedora 18 testing repository.
Comment 12 Fedora Update System 2012-11-14 21:27:00 EST
qextserialport-1.2-0.2.beta2.fc17 has been pushed to the Fedora 17 stable repository.
Comment 13 Dave Johansen 2014-11-15 09:53:42 EST
Package Change Request
Package Name: qextserialport
New Branches: el6 epel7
Owners: dlj
InitialCC: volter
Comment 14 Gwyn Ciesla 2014-11-17 10:38:21 EST
Comments from primary maintainers?
Comment 15 Volker Fröhlich 2014-11-17 10:54:17 EST
That's fine!
Comment 16 Dave Johansen 2014-11-18 20:45:05 EST
Is there anything else needed before these branches can be created?
Comment 17 Gwyn Ciesla 2014-11-24 15:42:40 EST
dlj is not in the packager group.
Comment 18 Volker Fröhlich 2014-11-25 17:43:53 EST
I think the user name should be daveisfera and not dlj. Please correct your request, Dave!
Comment 19 Dave Johansen 2014-11-27 22:59:51 EST
Yes, my username is daveisfera.
Comment 20 Gwyn Ciesla 2014-12-01 13:24:39 EST
Request not yet corrected.
Comment 21 Dave Johansen 2014-12-03 12:28:16 EST
Here's the correction for comment 13:

Package Change Request
Package Name: qextserialport
New Branches: el6 epel7
Owners: daveisfera
InitialCC: volter
Comment 22 Gwyn Ciesla 2014-12-03 13:34:28 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.