Bug 872916 - [TEXT] webadmin: running move from disks tab while vm is powering up yields an unclear error message from canDoAction
Summary: [TEXT] webadmin: running move from disks tab while vm is powering up yields a...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.1.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
: 3.2.0
Assignee: Daniel Erez
QA Contact: Dafna Ron
URL:
Whiteboard: storage
Depends On:
Blocks: 915537
TreeView+ depends on / blocked
 
Reported: 2012-11-04 08:56 UTC by Dafna Ron
Modified: 2016-02-10 16:57 UTC (History)
8 users (show)

Fixed In Version: sf3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
log (76.18 KB, application/x-xz)
2012-11-04 08:56 UTC, Dafna Ron
no flags Details

Description Dafna Ron 2012-11-04 08:56:17 UTC
Created attachment 637918 [details]
log

Description of problem:

the move tab is not greyed out in the disks tab while vm is powering up
it is greyed out from the vm's tab. 

when you try to move the disk we would get an incorrect error message: 

Error while executing action: Cannot move Virtual Machine Disk. At least one of the VMs is not down.

Version-Release number of selected component (if applicable):

si23

How reproducible:

100%

Steps to Reproduce:
1. run a vm
2. move disk from disks tab while vm is powering up
3.
  
Actual results:

1. move tab is not greyed out in disks tab but greyed out in vm's tab
2. incorrect text on canDoAction

Expected results:

1. we should be consistent and grey out the move button until the vm is up
2. fix CanDoAction for API

Additional info: log

Comment 1 Ayal Baron 2012-11-07 22:22:17 UTC
(In reply to comment #0)
> Created attachment 637918 [details]
> log
> 
> Description of problem:
> 
> the move tab is not greyed out in the disks tab while vm is powering up
> it is greyed out from the vm's tab. 
> 
> when you try to move the disk we would get an incorrect error message: 
> 
> Error while executing action: Cannot move Virtual Machine Disk. At least one
> of the VMs is not down.
> 
> Version-Release number of selected component (if applicable):
> 
> si23
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 1. run a vm
> 2. move disk from disks tab while vm is powering up
> 3.
>   
> Actual results:
> 
> 1. move tab is not greyed out in disks tab but greyed out in vm's tab
> 2. incorrect text on canDoAction
> 
> Expected results:
> 
> 1. we should be consistent and grey out the move button until the vm is up

not going to happen as disks tab is a main tab and it runs a query every 5s. Fetching VM status for all the VMs of all the disks is just not realistic.

> 2. fix CanDoAction for API
> 
> Additional info: log

Comment 2 Ayal Baron 2012-12-19 11:07:12 UTC
Need to change the canDoAction to something like: "Move disk is only permitted while VM is either in 'Down' or 'Up' state"

Comment 3 Daniel Erez 2012-12-30 20:09:09 UTC
patch merged:
http://gerrit.ovirt.org/#/c/10154/
Change-Id: Iadcffa5748b58b1af40535b0447487dde6c2d6cb

Comment 4 Dafna Ron 2013-01-07 16:49:25 UTC
Error: Cannot move Virtual Machine Disk. VM TEST1 must be in status Down or Up.

verified on sf3

Comment 5 Itamar Heim 2013-06-11 09:06:54 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 09:06:54 UTC
3.2 has been released

Comment 7 Itamar Heim 2013-06-11 09:06:54 UTC
3.2 has been released

Comment 8 Itamar Heim 2013-06-11 09:07:07 UTC
3.2 has been released

Comment 9 Itamar Heim 2013-06-11 09:35:35 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.