Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 872969

Summary: engine [Storage Live Migration]: engine allows migration of shared disk if its not attached to more than one vm -> Task will fail in vdsm with no roll back on snapshot
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Daniel Erez <derez>
Status: CLOSED CURRENTRELEASE QA Contact: Dafna Ron <dron>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 3.1.0CC: abaron, amureini, dyasny, hateya, iheim, lpeer, Rhev-m-bugs, sgrinber, vvyazmin, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: SI24.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 19:58:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Dafna Ron 2012-11-04 17:08:38 UTC
Created attachment 638067 [details]
logs

Description of problem:

engine allows live migration of shared disk if its not attached to more than one vm. 
migration will fail in vdsm but snapshot will not be rolled back. 


Version-Release number of selected component (if applicable):

si23

How reproducible:

100%

Steps to Reproduce:
1. create and run a vm with multiple disk and 1 shared disk
2. move shared disk
3.
  
Actual results:

migration will be sent to vdsm which will fail action

Expected results:

we should not send command to vdsm

Additional info: logs

55e83c5-2158-432c-8077-f8591dd7f240::ERROR::2012-11-04 18:51:00,211::task::853::TaskManager.Task::(_setError) Task=`255e83c5-2158-432c-8077-f8591dd7f240`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 861, in _run
    return fn(*args, **kargs)
  File "/usr/share/vdsm/storage/task.py", line 320, in run
    return self.cmd(*self.argslist, **self.argsdict)
  File "/usr/share/vdsm/storage/securable.py", line 63, in wrapper
    return f(self, *args, **kwargs)
  File "/usr/share/vdsm/storage/sp.py", line 1797, in syncImageData
    syncType)
  File "/usr/lib64/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "/usr/lib64/python2.6/contextlib.py", line 113, in nested
    yield vars
  File "/usr/share/vdsm/storage/sp.py", line 1797, in syncImageData
    syncType)
  File "/usr/share/vdsm/storage/image.py", line 670, in syncData
    {'srcChain': srcChain, 'dstChain': dstChain})
  File "/usr/share/vdsm/storage/image.py", line 551, in _interImagesCopy
    srcLeafVol = chains['srcChain'][-1]
IndexError: list index out of range

Comment 1 Ayal Baron 2012-11-04 21:15:50 UTC
Since we require creation of a snapshot when starting lsm and we prevent snaps on shareable disks we should indeed prevent moving a shareable disk.

Comment 2 Daniel Erez 2012-11-05 08:50:09 UTC
Patch sent upstream:
http://gerrit.ovirt.org/#/c/9020/1
Change-Id: Ibd235a4c0634f246d7613e520af7f245ccdbc779

Comment 3 Allon Mureinik 2012-11-06 09:39:09 UTC
Merged Ibd235a4c0634f246d7613e520af7f245ccdbc779

Comment 4 Dafna Ron 2012-11-12 08:58:11 UTC
bug no longer reproduces in si24.1. 
there is a CanDoAction for move of shared disk

Comment 5 Dafna Ron 2012-11-12 09:02:18 UTC
bug no longer reproduces in si24.1. 
there is a CanDoAction for move of shared disk