Bug 873792 – libvirt: cancel migration is sent but migration continues

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 873792 - libvirt: cancel migration is sent but migration continues

Summary:	libvirt: cancel migration is sent but migration continues

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	6.3
Hardware:	x86_64 Linux

Priority	high Severity high
Target Milestone:	rc
Target Release:	---
Assigned To:	Michal Privoznik
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:	infra
Keywords:	ZStream

Depends On:	728904
Blocks:	867347 875770
	Show dependency tree / graph

Reported:	2012-11-06 12:39 EST by Dafna Ron
Modified:	2013-02-21 02:26 EST (History)
CC List:	13 users (show)

See Also:
Fixed In Version:	libvirt-0.10.2-8.el6
Doc Type:	Bug Fix
Doc Text:	Libvirt allows users to cancel an ongoing migration. Previously, if an attempt to cancel the migration was made in the migration preparation phase, qemu missed the request and the migration was not canceled. With this update, the virDomainAbortJob() function sets a flag when a cancel request is made and this flag is checked before the main phase of the migration starts. As a result, a migration can now be properly canceled even in the preparation phase.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2013-02-21 02:26:00 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
logs (1.37 MB, application/x-gzip) 2012-11-06 12:39 EST, Dafna Ron	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2013:0276	normal	SHIPPED_LIVE	Moderate: libvirt security, bug fix, and enhancement update	2013-02-20 16:18:26 EST

Groups: None (edit)

Description Dafna Ron 2012-11-06 12:39:29 EST

Created attachment 639477 [details]
logs

Description of problem:

I cancelled migration of a vm right after it started and migration continued.
Michal looked at the logs and determined that vdsm isued 'migrate_cancel' before libvirt gets to 'migrate' 

Version-Release number of selected component (if applicable):

vdsm-4.9.6-41.0.el6_3.x86_64
libvirt-0.9.10-21.el6_3.5.x86_64
qemu-kvm-rhev-0.12.1.2-2.295.el6_3.5.x86_64

How reproducible:

100%

Steps to Reproduce:
1. migrate a vm from one host to a second host 
2. cancel migration right at the beginning of the migration
3.
  
Actual results:

migration continues

Expected results:

migration should be cancelled. 

Additional info: logs

Comment 1 Michal Privoznik 2012-11-06 12:47:04 EST

This is race. The first thread (the one that starts migration) sets job and is preparing to issue monitor commands to qemu. However, meanwhile second thread jumps in and since the job is already set, it cancels the job, issue 'migrate_cancel' and quit. Right after the first thread finished preparation and starts the migration (executes 'migrate' on the monitor).

Comment 2 Jiri Denemark 2012-11-06 13:21:53 EST

This is also tracked upstream in bug 728904.

Comment 3 Michal Privoznik 2012-11-07 06:04:23 EST

Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2012-November/msg00356.html

Comment 4 weizhang 2012-11-08 01:13:41 EST

I can reproduce with
# virsh migrate --live vr-rhel6u3-x86_64-kvm qemu+ssh://10.66.84.16/system --verbose & usleep 700000; virsh domjobabort vr-rhel6u3-x86_64-kvm; echo "$?"

domjobabort return 0 but migration continued

version
libvirt-0.10.2-7.el6.x86_64
qemu-kvm-0.12.1.2-2.323.el6.x86_64
kernel-2.6.32-329.el6.x86_64

Comment 5 Michal Privoznik 2012-11-12 06:11:57 EST

Moving to POST:


http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-November/msg00103.html

Comment 8 weizhang 2012-11-14 07:19:24 EST

Verify pass on

libvirt-0.10.2-8.el6.x86_64
qemu-kvm-0.12.1.2-2.323.el6.x86_64
kernel-2.6.32-329.el6.x86_64


# virsh migrate --live vr-rhel6u3-x86_64-kvm qemu+ssh://10.66.84.16/system --verbose & usleep 500000; virsh domjobabort vr-rhel6u3-x86_64-kvm

error: operation aborted: migration out: canceled by client

Comment 9 errata-xmlrpc 2013-02-21 02:26:00 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html

Note You need to log in before you can comment on or make changes to this bug.