Bug 873963 - RFE: Add virt-install --force-url-distro to work with URLs that disable directory listing
Summary: RFE: Add virt-install --force-url-distro to work with URLs that disable direc...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-07 05:51 UTC by Tom Prince
Modified: 2014-12-10 19:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-10 19:01:02 UTC
Embargoed:


Attachments (Terms of Use)
virt-manager-ignore-error-403-on-directories.patch (873 bytes, patch)
2014-08-27 16:47 UTC, Leonardo Chiquitto
no flags Details | Diff

Description Tom Prince 2012-11-07 05:51:40 UTC
Description of problem:

virt-install tries to verifiy that a URL passed to --location is useable
by trying to connect to it. If a proxy like apt-cacher-ng is configured,
that doesn't return directory listings, this will fail, even if requests
for files under that directory would succeed.

Version-Release number of selected component (if applicable):
0.600.3

Comment 1 Cole Robinson 2013-04-21 19:12:26 UTC
virtinst has been merged into virt-manager.git. Moving all virtinst bugs to the virt-manager component.

Comment 2 Cole Robinson 2014-02-01 19:26:41 UTC
We should add an option like --force-url-distro, which just assumes that the passed --os-variant value is the distro we are trying to fetch. It's still not that easy, because within each distro category we still probe trees to figure out which layout they are using. Maybe we could swap out the hasFile implementation in this case to just download the file rather than check the directory listing.

Comment 3 Leonardo Chiquitto 2014-08-27 16:47:00 UTC
Created attachment 931592 [details]
virt-manager-ignore-error-403-on-directories.patch

I was also affected by this limitation and would like to suggest the attached patch. Could you consider it for upstream inclusion? Thanks.

Comment 4 Cole Robinson 2014-12-10 19:01:02 UTC
Sorry Leonardo, I missed your patch comment :/

I actually just applied a patch upstream that drops the initial directory listing check.

commit 24faf867507484323fea285bdf4097c545ccf71b
Author: Gabriel de Perthuis <g2p.code>
Date:   Mon Dec 8 22:43:38 2014 +0100

    URL installs: remove hasFile("") check

I think that should fix things for yall, so closing this bug. If not, please reopen and explain where things are still failing


Note You need to log in before you can comment on or make changes to this bug.