Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4663474 Description: Although made popular by Windows, INI files can be used on any system thanks to their flexibility. They allow a program to store configuration data, which can then be easily parsed and changed. Two notable systems that use the INI format are Samba and Trac. Fedora Account System Username: mcpierce
Taking I would appreciate it if you would review my review request bug 872909
First of all, please take a look at https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#RubyGems and change your spec file to match the current gem related packaging guidelines. (Especially, current guideline requests that gem is unpacked first using gem unpack)
Darryl, would you update this ticket first? (because this review request blocks bug 836368 , I cannot approve bug 836368 unless this one gets approved).
(In reply to comment #3) > Darryl, would you update this ticket first? (because this review request > blocks bug 836368 , I cannot approve bug 836368 unless this one gets > approved). Done. Sorry for the delay. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4783102
For -1.1: * Versioning - Please don't use ".1" for release unless needed. Please use just integer (and %{?dist}) c.f. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning * License - README.md says that this is under MIT. * Documentation - Current ruby guideline says test/ directory should not be shipped in binary rpm https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites - Also, "Rakefile" is something like Makefile, which is usually not not needed for binary rpm. * Enabling test suite - As this package contains test/ directory, please execute some tests in %check (like ruby -Ilib test/test_inifile.rb)
(In reply to comment #5) > For -1.1: > > * Versioning > - Please don't use ".1" for release unless needed. > Please use just integer (and %{?dist}) > c.f. > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning > > * License > - README.md says that this is under MIT. Fixed. > * Documentation > - Current ruby guideline says test/ directory should not be > shipped in binary rpm > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites Hrm, that should be in the -doc package. Looking in the packages built the test directory is with the docs, per the specfile. > - Also, "Rakefile" is something like Makefile, which is usually not > not needed for binary rpm. Same here. > * Enabling test suite > - As this package contains test/ directory, please execute > some tests in %check (like ruby -Ilib test/test_inifile.rb) Their tests require a separate gem be installed called bones. I would prefer not to package that as it's not useful to me and isn't a runtime requirement for inifile. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.2.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4796678
(In reply to comment #6) > > * Enabling test suite > > - As this package contains test/ directory, please execute > > some tests in %check (like ruby -Ilib test/test_inifile.rb) > > Their tests require a separate gem be installed called bones. I would prefer > not to package that as it's not useful to me and isn't a runtime requirement > for inifile. - That is needed when you try to execute test suite using rake (bones is used only in Rakefile). See: https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites the line "The tests should not be run using Rake". As I said before, it seems that "ruby -Ilib test/test_inifile.rb" does some test program, so please consider to enable %check section. > > * Documentation > > - Current ruby guideline says test/ directory should not be > > shipped in binary rpm > > > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > > Ruby#Running_test_suites > > Hrm, that should be in the -doc package. Looking in the packages built the > test directory is with the docs, per the specfile. - So the current guideline says test/ directory should not be included also in -doc subpackage (see "Do not ship tests" in https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites ) (If you think test/ directory in this gem is useful for users, I won't treat this as a blocker)
(In reply to comment #7) > (In reply to comment #6) > > > * Enabling test suite > > > - As this package contains test/ directory, please execute > > > some tests in %check (like ruby -Ilib test/test_inifile.rb) > > > > Their tests require a separate gem be installed called bones. I would prefer > > not to package that as it's not useful to me and isn't a runtime requirement > > for inifile. > > - That is needed when you try to execute test suite using rake > (bones is used only in Rakefile). See: > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > the line "The tests should not be run using Rake". As I said before, > it seems that "ruby -Ilib test/test_inifile.rb" does some test > program, so please consider to enable %check section. One of the author's tests is consistently failing. I will work with the upstream to fix this, and will enable tests after that is done. Since they're not required, this shouldn't be considered a blocker. > > > > * Documentation > > > - Current ruby guideline says test/ directory should not be > > > shipped in binary rpm > > > > > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > > > Ruby#Running_test_suites > > > > Hrm, that should be in the -doc package. Looking in the packages built the > > test directory is with the docs, per the specfile. > > - So the current guideline says test/ directory should not be > included also in -doc subpackage (see "Do not ship tests" in > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites ) > (If you think test/ directory in this gem is useful for users, > I won't treat this as a blocker) The tests and Rakefile are no longer shipping with either package. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-inifile-2.0.2-1.3.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4802664
Okay. ---------------------------------------------------------------- This package (rubygem-inifile) is APPROVED by mtasaka ----------------------------------------------------------------
Thank you. New Package SCM Request ======================= Package Name: rubygem-inifile Short Description: INI file reader and writer Owners: mcpierce Branches: f16 f17 f18 InitialCC: mcpierce
Git done (by process-git-requests).
Closing.