Bug 874845 - oo-admin-ctl-app accepts garbage for a command and returns success.
Summary: oo-admin-ctl-app accepts garbage for a command and returns success.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 1.2.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-08 22:46 UTC by Steve Reichard
Modified: 2017-03-08 17:34 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-31 20:32:32 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0220 0 normal SHIPPED_LIVE Important: Red Hat OpenShift Enterprise 1.1 update 2013-02-01 01:23:24 UTC

Description Steve Reichard 2012-11-08 22:46:02 UTC
Description of problem:

While the man pages list a set of valid commands for the '-c', however I passed in another value and was suprised to see it returned Success.


[root@Abroker2 ~]# oo-admin-ctl-app -l richard -a drupal -c GlobalThermalNuclearWar
Success
[root@Abroker2 ~]# 

BTW, it appeared that the user and app were checked.
 



Version-Release number of selected component (if applicable):
[root@Abroker2 ~]# yum list installed openshift-origin-broker-util
Loaded plugins: product-id, rhnplugin, security, subscription-manager
Updating certificate-based repositories.
Unable to read consumer identity
Installed Packages
openshift-origin-broker-util.noarch                             1.0.4-1.el6op                              @openshift_infrastructure
[root@Abroker2 ~]# 



How reproducible:

very

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Brenton Leanhardt 2012-11-09 13:39:58 UTC
This will be fixed shortly after 1.0.

Comment 3 Brenton Leanhardt 2012-12-11 19:02:38 UTC
Looks like this was fixed upstream in Bug #877347

Comment 4 Brenton Leanhardt 2012-12-11 20:18:07 UTC
This will ship with the next puddle.  One thing to note is that I backported the fix for oo-admin-ctl-district as well.

Comment 5 xjia 2012-12-12 08:23:46 UTC
Verify:

[root@broker ~]# oo-admin-ctl-app -l jia -a ruby -c GlobalThermalNuclearWar
Command must be one of: (start|stop|force-stop|restart|status|destroy|force-destroy)
== Synopsis

oo-admin-ctl-app: Control user applications

== Usage

oo-admin-ctl-app OPTIONS

Options:
-l|--rhlogin <rhlogin>
    Red Hat login (RHN or OpenShift login with OpenShift access) (required)
-a|--app     <application>
    Application name  (alphanumeric) (required)
-c|--command <command>
    (start|stop|force-stop|restart|status|destroy|force-destroy) (required)
-b|--bypass
    Ignore warnings
-h|--help
    Show Usage info

Version:
OpenShiftEnterprise/1.1.x/2012-12-11.3/

Comment 7 errata-xmlrpc 2013-01-31 20:32:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0220.html


Note You need to log in before you can comment on or make changes to this bug.