Spec URL: http://echevemaster.fedorapeople.org/xfce-theme-manager/1/xfce-theme-manager.spec RPMS URL: http://echevemaster.fedorapeople.org/xfce-theme-manager/1/xfce-theme-manager-0.1.18-1.fc17.src.rpm Description: A theme manager allowing easy configuration of themes, window borders, controls, icons and cursors for Xfce Fedora Account System Username: echevemaster rpmlint -v xfce-theme-manager.spec xfce-theme-manager.spec: I: checking-url http://aur.mfs.name/xfce-theme-manager/xfce-theme-manager-0.1.18.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -v xfce-theme-manager-0.1.18-1.fc17.src.rpm xfce-theme-manager.src: I: checking xfce-theme-manager.src: I: checking-url http://keithhedger.hostingsiteforfree.com/pages/apps.html#themeed (timeout 10 seconds)http://aur.mfs.name/xfce-theme-manager/xfce-theme-manager-0.1.18.tar.gz xfce-theme-manager.src: W: invalid-url URL: http://keithhedger.hostingsiteforfree.com/pages/apps.html#themeed <urlopen error timed out> xfce-theme-manager.src: I: checking-url http://aur.mfs.name/xfce-theme-manager/xfce-theme-manager-0.1.18.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Koji Build Rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=4682058 Koji Build F18 http://koji.fedoraproject.org/koji/taskinfo?taskID=4682060 Koji Build F17 http://koji.fedoraproject.org/koji/taskinfo?taskID=4682069 There are some issues with this package that I think fix soon 1.- No license text, I sent an email to upstream for include the license 2.- For some unknown reason the original site for downloading the tarball is innacesible for myself. But is a fact that the site is operating, So use this pristine source mirrored in http://aur.mfs.name/xfce-theme-manager/xfce-theme-manager-0.1.18.tar.gz
Created attachment 643973 [details] Fix prefix and strip program
Created attachment 643975 [details] Fix typos in desktop file
Created attachment 644063 [details] Alternate spec I have also done some initial packaging, maybe there is some hints to avoid the patches you are using.
I can try and review this in a while if no one beats me to it. ;)
(In reply to comment #3) > Created attachment 644063 [details] > Alternate spec > > I have also done some initial packaging, maybe there is some hints to avoid > the patches you are using. Thanks Tim. I'll wait to upstream provide me the license (In reply to comment #4) > I can try and review this in a while if no one beats me to it. ;) Thanks Kevin,
Hey Eduardo. Is this ready to review? Or would you care to fold in changes from Tim and update? Also, have you heard anything from upstream on the license?
(In reply to comment #6) > Hey Eduardo. Is this ready to review? Or would you care to fold in changes > from Tim and update? > > Also, have you heard anything from upstream on the license? Hi Kevin I 've talked with upstream and has released a new version with the license included http://keithhedger.hostingsiteforfree.com/zips/Xfce-Theme-Manager-0.1.19.tar.gz I'm packing this new version today, I let you know when it is ready
Hi kevin Here are the updated files ready for review: spec: http://echevemaster.fedorapeople.org/xfce-theme-manager/xfce-theme-manager-0.1.19/xfce-theme-manager.spec srpm: http://echevemaster.fedorapeople.org/xfce-theme-manager/xfce-theme-manager-0.1.19/xfce-theme-manager-0.1.19-1.fc17.src.rpm Regards
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv3) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. see below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Is there no upstream place to download the source? If it's not a easy to use url you can explain in a comment how to download it. 2. (nonblocker) You might mention to upstream the various warnings spit out in the build. 3. rpmlint says: xfce-theme-manager.i686: W: no-manual-page-for-binary xfce-theme-manager Might be nice to make a man page, but not a blocker. xfce-theme-manager-debuginfo.i686: E: debuginfo-without-sources debuginfo-without-sources: This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. You probibly need to patch the build process to use the normal rpm opt flags.
Hi kevin, Thanks for taking the review (In reply to comment #9) > Issues: > > 1. Is there no upstream place to download the source? If it's not a easy to > use url you > can explain in a comment how to download it. Comment added > 2. (nonblocker) You might mention to upstream the various warnings spit out > in the build. I'll send an email to upstream with the warnings > 3. rpmlint says: > > xfce-theme-manager.i686: W: no-manual-page-for-binary xfce-theme-manager > > Might be nice to make a man page, but not a blocker. I did a man page for the application, today sent it to upstream > xfce-theme-manager-debuginfo.i686: E: debuginfo-without-sources > > debuginfo-without-sources: > This debuginfo package appears to contain debug symbols but no source files. > This is often a sign of binaries being unexpectedly stripped too early during > the build, or being compiled without compiler debug flags (which again often > is a sign of distro's default compiler flags ignored which might have > security > consequences), or other compiler flags which result in rpmbuild's debuginfo > extraction not working as expected. Verify that the binaries are not > unexpectedly stripped and that the intended compiler flags are used. > > You probibly need to patch the build process to use the normal rpm opt flags. Solved SPEC: http://echevemaster.fedorapeople.org/xfce-theme-manager/2/xfce-theme-manager.spec SRPM: http://echevemaster.fedorapeople.org/xfce-theme-manager/2/xfce-theme-manager-0.1.19-2.fc17.src.rpm Koji scratch Builds: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727203 f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727214 f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727242
I'd use the upstream url in the Source0 line... if it's only failing for you there due to some network issue, it should hopefully work for anyone else who reads your spec. ;) I don't see any further blockers, you can fix the Source0 url before checking...
(In reply to comment #11) > I'd use the upstream url in the Source0 line... if it's only failing for you > there due to some network issue, it should hopefully work for anyone else > who reads your spec. ;) From that point of view you're right :). I fixed Source0 SPEC: http://echevemaster.fedorapeople.org/xfce-theme-manager/3/xfce-theme-manager.spec SRPM: http://echevemaster.fedorapeople.org/xfce-theme-manager/3/xfce-theme-manager-0.1.19-3.fc17.src.rpm
Hi Kevin since you have granted review, and has put his state in +, when I can give approval to this package? Thanks in advance and very grateful for the reviews- Kind Regards
Follow the process from: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner basically you add a scm request here and set the 'fedora-cvs' flag to ? and then scmadmins process it and you can import, build and push updates of the package.
(In reply to comment #14) > Follow the process from: > https://fedoraproject.org/wiki/ > Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management > _.28SCM.29_system_and_Set_Owner > > basically you add a scm request here and set the 'fedora-cvs' flag to ? and > then scmadmins process it and you can import, build and push updates of the > package. If I know, I think there is a misunderstanding here from me (by the language), as I not saw the word "approved". I thought you had something more to review, :) thanks again New Package SCM Request ======================= Package Name: xfce-theme-manager Short Description: A theme manager for Xfce Owners: echevemaster Branches: f17 f18 InitialCC:
Sorry if you were waiting for me. ;( Should be all set from my side.
Git done (by process-git-requests).
xfce-theme-manager-0.1.20-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.1.20-1.fc18
xfce-theme-manager-0.1.20-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.1.20-1.fc17
xfce-theme-manager-0.1.20-1.fc18 has been pushed to the Fedora 18 testing repository.
xfce-theme-manager-0.1.20-1.fc17 has been pushed to the Fedora 17 stable repository.
xfce-theme-manager-0.2.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.2.3-1.fc17
xfce-theme-manager-0.2.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.2.3-1.fc18
xfce-theme-manager-0.1.20-1.fc18 has been pushed to the Fedora 18 stable repository.
xfce-theme-manager-0.2.3-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
xfce-theme-manager-0.2.3-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
xfce-theme-manager-0.2.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.2.4-1.fc18
xfce-theme-manager-0.2.4-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xfce-theme-manager-0.2.4-1.fc17
xfce-theme-manager-0.2.4-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
xfce-theme-manager-0.2.4-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.