Bug 876726 - User profile page shows raw HTML
Summary: User profile page shows raw HTML
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Clayton Coleman
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-14 19:38 UTC by Alexander Todorov
Modified: 2015-05-15 01:15 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-19 19:25:41 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
Profile page showing raw HTML (31.08 KB, image/png)
2012-11-15 08:49 UTC, Alexander Todorov 		no flags Details
Editting my profile - no HTML present (16.45 KB, image/png)
2012-11-15 08:49 UTC, Alexander Todorov 		no flags Details
View All

Description Alexander Todorov 2012-11-14 19:38:52 UTC 
See screenshot:
Comment 1 Clayton Coleman 2012-11-14 22:03:29 UTC 
User profile doesn't support HTML
Comment 2 Alexander Todorov 2012-11-15 08:48:42 UTC 
Re-opening. I'm not inserting HTML into any of the fields. See screenshots
Comment 3 Alexander Todorov 2012-11-15 08:49:09 UTC 
Created attachment 645486 [details]
Profile page showing raw HTML
Comment 4 Alexander Todorov 2012-11-15 08:49:37 UTC 
Created attachment 645487 [details]
Editting my profile - no HTML present
Comment 5 Clayton Coleman 2012-11-15 20:18:10 UTC 
In Drupal, any field presented to the user as a textarea is assumed to be formatted according to the default input format (in this case, our default is markdown+some inline HTML, properly sanitized).  In the UI, we should strip tags everywhere except the about me page, and on the about me page we should follow the normal sanitization rules.

I made it so that every view that shows these attributes strips HTML, and removed some of the edge case checking that was unnecessary.

Fixed in: https://github.com/openshift/li/pull/626
Comment 6 Yujie Zhang 2012-11-16 05:42:21 UTC 
(In reply to comment #5)
Tested on devenv_2485, profile content will be displayed correctly without raw HTML, thanks.
Note You need to log in before you can comment on or make changes to this bug.