RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
virsh save guest with an no-exist xml should show error msg

Version-Release number of selected component (if applicable):
libvirt-0.10.2-8.el6.x86_64

How reproducible:
100%

Reproduce steps:

1. save guest when guest is running
[root@zhpeng ~]# virsh list
 Id    Name                           State
----------------------------------------------------
 1     aaa                            running

[root@zhpeng ~]# virsh save aaa /tmp/aaa.save --xml nofile.xml

[root@zhpeng ~]# echo $?
1

2.save guest when guest is shutdown
[root@zhpeng ~]# virsh list
 Id    Name                           State
----------------------------------------------------

[root@zhpeng ~]# virsh save aaa /tmp/aaa.save --xml nofile.xml

[root@zhpeng ~]# echo $?
1


Actual results:
no correct error msg.

Expected results:
step1: should show error like: xml file XXXXX not exist
step2: should show error like: guest xxx is not running\n xml file XXXXX not exist.(or only shows guest xxx is not running)

Additional info:
Not any error msg in /var/log/messages, /var/log/libvirt/libvirtd.log and /var/log/libvirt/qemu/guest.log

Upstream patch proposed:
https://www.redhat.com/archives/libvir-list/2012-November/msg00700.html

This reports
error: Failed to open file 'nofile.xml': No such file or directory
in both cases. I don't think we should care about the domain state if the command parameters are incorrect.

Fixed upstream by:
commit 58110b48870b4e8efd1d833e3ecbef41b62d1877
Author:     Ján Tomko <jtomko>
AuthorDate: 2012-11-15 14:25:09 +0100
Commit:     Eric Blake <eblake>
CommitDate: 2012-11-15 22:21:35 -0700

    virsh: save: report an error if XML file can't be read

Moving to POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-November/msg00161.html

Verifing the bug with libvirt-0.10.2-9.el6.x86_64:

# virsh start pxe
Domain pxe started

# virsh save pxe /tmp/pxe.save --xml nofile
error: Failed to open file 'nofile': No such file or directory

# echo $?
1

# virsh destroy pxe
Domain pxe destroyed

# virsh save pxe /tmp/pxe.save --xml nofile
error: Failed to open file 'nofile': No such file or directory

[root@libn755 xml]# echo $?
1

So seting VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html