Bug 877929
| Summary: | favicon is missing - main page is not well-formed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Libor Zoubek <lzoubek> | ||||||||
| Component: | UI | Assignee: | Mike Thompson <mithomps> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | JON 3.1.1 | CC: | fbrychta, hrupp, mithomps, myarboro, theute | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | JON 3.1.2 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2013-09-11 11:04:28 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
For JON312 triage, assuming its a trivial fix Newer versions of Firefox eliminate the favicon from the url bar and place it in the tab instead. The old favicon spot now houses a generic icon for SSL and extended validation. http://thenextweb.com/insider/2012/04/24/firefox-is-killing-off-the-favicon/ NOTE: I first cleared cache and then tested on FF16 and found the icon had gone away in the url but was present in the tab. I also went back and tested agains the FF8 and verified that it existed with the same server (codebase). See attached image. FF Version: 16.0.1 and Chrome: 23.0.1271.64 Requesting additional information on FF version tested and whether other icons for other sites could be seen? Created attachment 648123 [details]
FF16 favicon
I am on Firefox 16.0.2 and Chromium 23.0.1271.64. I've also checked on FF10 (on rhel 6.3) and it also does not show favicon, see screenshot Created attachment 648152 [details]
FF10 no favicon
Thanks Libor. You are correct. I rebuilt off of the release/jon3.1.x branch and I now see this as well. Your solution fixes the problem. cherry picked to release/jon3.1.x commit id: 362e6e0 NOTE: this fix is only for 3.1.2 and wont be checked into master because another better solution has already solved this issue by moving the js libraries from CoreGUI.html to CoreGUI.gwt.xml. This adds an additional level of safety, in that the external libaries are fully loaded and initialized before the gwt app is allowed to start. Ensuring that our gwt app doesn't start before the other external js libraries have loaded. Moving to ON_QA as available for test with build : https://brewweb.devel.redhat.com//buildinfo?buildID=244662. Verified on 3.1.2.ER2 |
Created attachment 647615 [details] page source in FF Description of problem: I've noticed that my browser does not show favicon. Version-Release number of selected component (if applicable): Version: 3.1.2.ER1 Build Number: 05cc75f:18fd619 GWT Version: 2.4.0 SmartGWT Version: 3.0 How reproducible: always in Firefox & Chromium (haven't tried others) Steps to Reproduce: 1. Clear all caches in your browser 2. Open coregui initial page 3. Actual results: there's no favicon Expected results: favicon should be shown Additional info: browsers do not show favicon because main page is not well-formed. I think the problematic part is : <script src="/coregui/js/jquery-1.7.2.min.js"/> I guess "script" element should not be single. (see screenshot)