Bug 878421 - Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL
Summary: Review Request: rubygem-bundler_ext - Load system gems via Bundler DSL
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bohuslav "Slavek" Kabrda
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-20 11:50 UTC by Vít Ondruch
Modified: 2013-07-30 14:17 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-30 14:17:34 UTC
bkabrda: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2012-11-20 11:50:12 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-1.fc19.src.rpm
Description: Simple library leveraging the Bundler Gemfile DSL to load gems already on the system and managed by the systems package manager (like yum/apt)
Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4708526

Comment 1 Bohuslav "Slavek" Kabrda 2012-11-20 11:51:16 UTC
I'll take this for a review.

Comment 2 Lukas Zapletal 2012-11-20 12:11:12 UTC
Guys can you please ping me before you submit this into Fedora/EPEL? We might need to bump version, do not expect big changes, just few oneliners. We are also considering renaming the project, I have asked to do this rather now (before this is going into fedora) then later:

https://github.com/aeolus-incubator/bundler_ext/issues/1

Thanks

Comment 3 Bohuslav "Slavek" Kabrda 2012-11-20 12:29:14 UTC
I have no objections so far, so let's wait for Lukas and use newer version, if one is released.

Comment 4 Lukas Zapletal 2012-11-20 16:53:07 UTC
Thanks guys, I will ping you then. Aeolus folks planned rename for the next sprint, let's release once it's done.

Comment 5 Vít Ondruch 2012-11-22 15:13:45 UTC
Hi, I added a few compatibility macros for older Fedora and RHEL:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-2.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4716627

Comment 6 Lukas Zapletal 2012-11-22 17:48:43 UTC
Vit: Thanks for adding RHEL6 related macros. Please add this:

%global gem_libdir %{gem_instdir}/lib

and also

%if 0%{?rhel} <= 6
BuildRequires: rubygems
%else
BuildRequires: rubygems-devel
%endif

And also I need to turn off %check section for RHEL6, rspec command is not found there (not sure why). Many thanks!!!

Comment 7 Vít Ondruch 2012-11-23 08:28:32 UTC
Hi, here we go ... not sure about the %check section though, but it should work I hope:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-3.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4720147

Comment 8 Lukas Zapletal 2012-11-28 09:01:26 UTC
I have an issue, when I build your package under Fedora 17, the content is in a wrong directory:

http://koji.katello.org/koji/taskinfo?taskID=13940

[lzap@lzapx Download]$ rpm -qlp rubygem-bundler_ext-0.1.0-3.fc17.noarch.rpm 
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/COPYING
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext.rb
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext/bundler_ext.rb
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext/version.rb
/builddir/.gem/ruby/1.9.1/specifications/bundler_ext-0.1.0.gemspec

Comment 9 Vít Ondruch 2012-11-28 10:50:51 UTC
(In reply to comment #8)
Sorry, you are right. The macros are not right. I made new revision fixing the issue:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-4.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4737159

Comment 10 Lukas Zapletal 2013-03-14 16:30:20 UTC
FYI We are good to go with the review, budnler_ext has been bumped to version 0.3 which has the new namespace. Thanks guys.

Comment 11 Christopher Meng 2013-07-18 06:10:11 UTC
NEWS?

We may need this package for some gitorious patches.

Comment 12 Vít Ondruch 2013-07-18 07:59:36 UTC
Sorry for the delay. Here is updated package:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.3.0-1.fc20.src.rpm

Comment 13 Ken Dreyer 2013-07-18 20:52:48 UTC
Hi Slavek, I know you have a lot on your plate, so if you would like to hand the review over to Christopher or myself, please un-assign this review.

Comment 14 Bohuslav "Slavek" Kabrda 2013-07-19 05:39:52 UTC
(In reply to Ken Dreyer from comment #13)
> Hi Slavek, I know you have a lot on your plate, so if you would like to hand
> the review over to Christopher or myself, please un-assign this review.

Huh, sorry, I totally forgot I'm assigned to this.

The package looks fine, just a small comment - is "0%{?rhel:1}" really necessary? Wouldn't "0%{?rhel}" suffice? (same applies to "0%{fedora:1}")

But this is just a nit and the package is ok otherwise, so APPROVED.

Comment 15 Lukas Zapletal 2013-07-22 08:05:47 UTC
Just to let you know guys, bundler_ext has been promoted as top level project this weekend :)

https://github.com/bundlerext/bundler_ext

Comment 16 Vít Ondruch 2013-07-30 13:22:10 UTC
Thanks for the review.



New Package SCM Request
=======================
Package Name: rubygem-bundler_ext
Short Description: Load system gems via Bundler DSL
Owners: vondruch
Branches: 
InitialCC:

Comment 17 Gwyn Ciesla 2013-07-30 13:40:51 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.