I'll take this for a review.

Guys can you please ping me before you submit this into Fedora/EPEL? We might need to bump version, do not expect big changes, just few oneliners. We are also considering renaming the project, I have asked to do this rather now (before this is going into fedora) then later:

https://github.com/aeolus-incubator/bundler_ext/issues/1

Thanks

I have no objections so far, so let's wait for Lukas and use newer version, if one is released.

Thanks guys, I will ping you then. Aeolus folks planned rename for the next sprint, let's release once it's done.

Hi, I added a few compatibility macros for older Fedora and RHEL:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-2.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4716627

Vit: Thanks for adding RHEL6 related macros. Please add this:

%global gem_libdir %{gem_instdir}/lib

and also

%if 0%{?rhel} <= 6
BuildRequires: rubygems
%else
BuildRequires: rubygems-devel
%endif

And also I need to turn off %check section for RHEL6, rspec command is not found there (not sure why). Many thanks!!!

Hi, here we go ... not sure about the %check section though, but it should work I hope:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-3.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4720147

I have an issue, when I build your package under Fedora 17, the content is in a wrong directory:

http://koji.katello.org/koji/taskinfo?taskID=13940

[lzap@lzapx Download]$ rpm -qlp rubygem-bundler_ext-0.1.0-3.fc17.noarch.rpm 
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/COPYING
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext.rb
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext/bundler_ext.rb
/builddir/.gem/ruby/1.9.1/gems/bundler_ext-0.1.0/lib/aeolus/ext/version.rb
/builddir/.gem/ruby/1.9.1/specifications/bundler_ext-0.1.0.gemspec

(In reply to comment #8)
Sorry, you are right. The macros are not right. I made new revision fixing the issue:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.1.0-4.fc19.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4737159

FYI We are good to go with the review, budnler_ext has been bumped to version 0.3 which has the new namespace. Thanks guys.

NEWS?

We may need this package for some gitorious patches.

Sorry for the delay. Here is updated package:

Spec URL: http://people.redhat.com/vondruch/rubygem-bundler_ext.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bundler_ext-0.3.0-1.fc20.src.rpm

Hi Slavek, I know you have a lot on your plate, so if you would like to hand the review over to Christopher or myself, please un-assign this review.

(In reply to Ken Dreyer from comment #13)
> Hi Slavek, I know you have a lot on your plate, so if you would like to hand
> the review over to Christopher or myself, please un-assign this review.

Huh, sorry, I totally forgot I'm assigned to this.

The package looks fine, just a small comment - is "0%{?rhel:1}" really necessary? Wouldn't "0%{?rhel}" suffice? (same applies to "0%{fedora:1}")

But this is just a nit and the package is ok otherwise, so APPROVED.

Just to let you know guys, bundler_ext has been promoted as top level project this weekend :)

https://github.com/bundlerext/bundler_ext

Thanks for the review.



New Package SCM Request
=======================
Package Name: rubygem-bundler_ext
Short Description: Load system gems via Bundler DSL
Owners: vondruch
Branches: 
InitialCC:

Git done (by process-git-requests).