Red Hat Bugzilla – Bug 878428
__git_ps1 not found
Last modified: 2013-02-06 14:48:51 EST
Description of problem:
As referenced in
the git-prompt.sh file isn't included in /etc/profile.d, causing the shell to complain of missing __git_ps1, (which makes yum go looking for matching packages, which means it's very slow to run any command).
I upgraded from F16 to F17 (via preupgrade) to F18 (via yum), in case that matters/helps.
Thanks for report. However this was intentional change. Please check bug #854061 for more details.
To fix this you must add something like
to your bashrc or to your profile.
Many (most!) git users have this setup by default.
This breaks all of those.
It has worked since forever, so I consider this a regression.
(In reply to comment #2)
> Many (most!) git users have this setup by default.
> This breaks all of those.
> It has worked since forever, so I consider this a regression.
Idea of moving __git_ps1() to separate script didn't come from Fedora git maintainers. Check this upstream commit:
And we cannot put __git_ps1() into profile.d because it can cause issues with other non-bash shells (as written in original description of bug #854061).
Although I agree this is a regression from user point of view, we have no idea how to fix it. Please use solution written in comment #1
(In reply to comment #1)
> To fix this you must add something like
> . /usr/share/git-core/contrib/completion/git-prompt.sh
> to your bashrc or to your profile.
Thanks for the fix Adam!
I too ran into this and consider it a regression. I'm loathe to add another distro specific path to my startup scripts.
Given that the reason indicated above that has not been fixed is compatibility with "other" shells, the semantics of /etc/bash_completion.d and /usr/share/bash-completion/completions (the former is for backwards compatibility and always loaded, the later is the new place from which completions are demand loaded) and the upstream developers motivation
in separating git-prompt.sh out to allow for both demand loading of the git completions and *more* compatiblity with other shells like zsh, I propose putting the main git completion file in
and the git-prompt.sh into
This way git-prompt.sh gets run all the time, but only in bash and only for interactive shells, and the main git completions (the larger of the two) get loaded on demand (this really should be the case regardless of the decision on this bug) as intended?
See #854061. This is a no-win position. If we always source git-prompt, someone considers it a bug that we're "polluting" the environment. If we don't, it's a bug that it must be sourced manually.
If/when upstream and/or other distros all agree on some common location for git-prompt.sh, we will move it there and likely add a symlink from the current location.
# With git-1.8, the completion and prompt bits were split. The allows lazy
# autoloading of the completion commands. But it means we have to source a
# different file to get __git_ps1().
if ! type __git_ps1 &>/dev/null && [[ -f $git_prompt ]]; then