Bug 878501 - Review Request: rubygem-ci_reporter - Generate XML for continuous integration systems
Summary: Review Request: rubygem-ci_reporter - Generate XML for continuous integration...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-11-20 14:58 UTC by Troy Dawson
Modified: 2013-01-11 23:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-01-11 23:57:15 UTC
Type: ---
Embargoed:
msuchy: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Troy Dawson 2012-11-20 14:58:01 UTC
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.7.3-1.fc18.src.rpm
Description: CI::Reporter is an add-on to Test::Unit, RSpec and Cucumber that allows you to generate XML reports of your test, spec and/or feature runs.
Fedora Account System Username: tdawson

RPMLINT OUTPUT:
rpmlint rubygem-ci_reporter.spec rubygem-ci_reporter-1.7.3-1.fc18.src.rpm rubygem-ci_reporter-1.7.3-1.fc18.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Miroslav Suchý 2012-11-28 19:50:16 UTC
I would suggest to add to the end of %install:
rm -rf %{buildroot}%{gem_instdir}/.yardoc
so rpmbuild --rebuild will pass on systems where rubygem-yard is installed. But
it is not crucial since in koji it is not installed.

Can you please create -doc subpackage and move there tests, /ri folder and all files not needed for runtime? 

no need to define gem_extdir macro, when it is not used.

This:
Requires: rubygem(rubyforge)
Requires: rubygem(hoe)
Requires: rubygem(rdoc)
is marked as devel deps on rubygems.org. Is it really needed for runtime?

export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
This is only needed for gems, which has library written in C.

Comment 2 Troy Dawson 2012-11-29 16:29:44 UTC
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.7.3-2.fc18.src.rpm

rm -rf %{buildroot}%{gem_instdir}/.yardoc - Done
doc subpackage - Done
gem_extdir macro - Removed
Requires: rubygem(rubyforge) - Removed
Requires: rubygem(hoe) - Removed
Requires: rubygem(rdoc) - Removed
(in the Gemfile, it is correct, but the Gemfile.lock has them all just listed as required.  My mistake)

export CONFIGURE_ARGS ... - Removed

Comment 3 Miroslav Suchý 2012-11-30 08:11:50 UTC
This gem contains spec tests. Any reason why you do not run them in %check?

Comment 4 Troy Dawson 2012-11-30 15:39:42 UTC
Yes.
Try as hard as I can, I cannot get any self-tests to run.
It doesn't help that this gem works with testing and generating reports on other gems, so there are several files with "test" in the name.
I have written an email to the developers asking if there are any self tests, and if there are, how are they run.

If you are able to run the tests, please let me know the commands and I'll put them in.

Comment 5 Miroslav Suchý 2012-12-06 11:58:53 UTC
This works for me:

rm Gemfile.lock
for i in spec/ci/reporter/*_spec.rb; do
  if [ $i = "spec/ci/reporter/report_manager_spec.rb" -o $i = "spec/ci/reporter/test_unit_spec.rb" ]; then
    continue
  fi
  rspec $i
done

And I had to add
  require 'test/unit/diff'
on top of 
  /usr/share/gems/gems/test-unit-2.4.5/lib/test/unit/ui/console/testrunner.rb


Please report it as bug to rubygem-test-unit and for add that above to %check as comments plus add as comment link to that test-unit bz. Plus link to reports to upstream that those two tests are failing (I think at least one is already reported).

And of course you have to add build requires on hoe and diff-lcs, to make this above work.

Comment 6 Troy Dawson 2012-12-06 22:59:33 UTC
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-1.fc18.src.rpm

That was the fix we needed for the test.
If we add "require 'test/unit/diff'" to the top of all the tests, then they wall work, even report_manager_spec.rb and test_unit_spec.rb.

I have informed upstream.
I have also tested it with a newer version of test-unit, and it works without having to do that.  But for now, I have a sed statement that fixes up the tests.  Once we have a newer version of test-unit in Fedora we can take that out.

Comment 7 Miroslav Suchý 2012-12-07 08:33:00 UTC
Looks good, but fails to build in mock. See:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4765761

Comment 8 Troy Dawson 2012-12-07 14:17:12 UTC
It fails to build in rawhide, I build it in F18
http://koji.fedoraproject.org/koji/taskinfo?taskID=4765286

This isn't the first package I've seen that builds fine in F18, but not in rawhide.  I think some of the main rubygems have changed what they provide and/or require.

Looking into it.

Comment 9 Troy Dawson 2012-12-10 18:28:55 UTC
Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-1.fc18.src.rpm

Test problem in rawhide ended up being a dependency problem for the version of cucumber in rawhide.  I have filed a bug on in.
https://bugzilla.redhat.com/show_bug.cgi?id=885822

Since tests are currently only a recommendation, I have made an if statement that bypasses the tests for F19+.  I have put a comment by it stating the bug number and that when the bug is fixed to remove the if statement.

I have tested and it builds in both F19 and F18

Comment 10 Miroslav Suchý 2012-12-11 16:56:02 UTC
I guess that you meant:
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-ci_reporter-1.8.2-2.fc18.src.rpm
(release is 2 instead of 1)
:)

Yes, that is good.
APPROVED.

Comment 11 Troy Dawson 2012-12-11 17:29:57 UTC
New Package SCM Request
=======================
Package Name: rubygem-ci_reporter
Short Description: Generate XML for continuous integration systems
Owners: tdawson
Branches: f18 f17
InitialCC:

Comment 12 Gwyn Ciesla 2012-12-11 17:44:33 UTC
Git done (by process-git-requests).

Comment 13 Fedora Update System 2012-12-11 19:45:41 UTC
rubygem-ci_reporter-1.8.2-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-ci_reporter-1.8.2-2.fc18

Comment 14 Fedora Update System 2012-12-11 23:29:29 UTC
rubygem-ci_reporter-1.8.2-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 15 Fedora Update System 2013-01-11 23:57:17 UTC
rubygem-ci_reporter-1.8.2-2.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.